mbox series

[0/3] Add devicetree support for ad5933

Message ID cover.1544292845.git.marcelo.schmitt1@gmail.com (mailing list archive)
Headers show
Series Add devicetree support for ad5933 | expand

Message

Marcelo Schmitt Dec. 8, 2018, 6:18 p.m. UTC
This series of patches change voltage regulator error handling for the
ad5933.
It also add an option to specify external clock reference using a clock
framework and remove the old platform data structure.
Finally it adds binding documentation for devicetree.

Marcelo Schmitt (3):
  staging: iio: ad5933: change regulator binging for vref
  staging: iio: ad5933: use clock framework for clock reference
  staging: iio: ad5933: add binding doc for ad5933

 .../iio/impedance-analyzer/ad5933.txt         | 26 +++++++++
 .../staging/iio/impedance-analyzer/ad5933.c   | 57 +++++++++----------
 2 files changed, 54 insertions(+), 29 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt

Comments

Marcelo Schmitt Dec. 8, 2018, 6:56 p.m. UTC | #1
Parts of this work came from contributions of Alexandru Ardelean and
Dragos Bogdan, I and Gabriel would like to thank for the insights
provided by their previous patches. Maybe it would be the case to add
them as co-authors of this patch set.
We also wanted to thank Jhonatan Cameron for giving us the pieces of
advice needed for this work.

Thanks,
Marcelo

Em sáb, 8 de dez de 2018 às 16:18, Marcelo Schmitt
<marcelo.schmitt1@gmail.com> escreveu:
>
> This series of patches change voltage regulator error handling for the
> ad5933.
> It also add an option to specify external clock reference using a clock
> framework and remove the old platform data structure.
> Finally it adds binding documentation for devicetree.
>
> Marcelo Schmitt (3):
>   staging: iio: ad5933: change regulator binging for vref
>   staging: iio: ad5933: use clock framework for clock reference
>   staging: iio: ad5933: add binding doc for ad5933
>
>  .../iio/impedance-analyzer/ad5933.txt         | 26 +++++++++
>  .../staging/iio/impedance-analyzer/ad5933.c   | 57 +++++++++----------
>  2 files changed, 54 insertions(+), 29 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/impedance-analyzer/ad5933.txt
>
> --
> 2.17.1
>
Greg KH Dec. 8, 2018, 9:10 p.m. UTC | #2
On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote:
> Parts of this work came from contributions of Alexandru Ardelean and
> Dragos Bogdan, I and Gabriel would like to thank for the insights
> provided by their previous patches. Maybe it would be the case to add
> them as co-authors of this patch set.

That's what the Co-developed-by: tag is for, please use it :)
Jonathan Cameron Dec. 10, 2018, 9:27 p.m. UTC | #3
On Sat, 8 Dec 2018 22:10:43 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote:
> > Parts of this work came from contributions of Alexandru Ardelean and
> > Dragos Bogdan, I and Gabriel would like to thank for the insights
> > provided by their previous patches. Maybe it would be the case to add
> > them as co-authors of this patch set.  
> 
> That's what the Co-developed-by: tag is for, please use it :)
> 
Alexandru, Dragos.  No idea how involved you were in the actual
patch...

Work amongst amongst the 4 of you what you would like to do and
let us know!

Patches look fine, though we need to let the DT maintainers have a few
days at least to get around to looking if they want to (they don't always
on simple bindings like these).

Jonathan
Alexandru Ardelean Dec. 11, 2018, 10:31 a.m. UTC | #4
On Mon, 2018-12-10 at 21:27 +0000, Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 22:10:43 +0100
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote:
> > > Parts of this work came from contributions of Alexandru Ardelean and
> > > Dragos Bogdan, I and Gabriel would like to thank for the insights
> > > provided by their previous patches. Maybe it would be the case to add
> > > them as co-authors of this patch set.  
> > 
> > That's what the Co-developed-by: tag is for, please use it :)
> > 
> 
> Alexandru, Dragos.  No idea how involved you were in the actual
> patch...
> 
> Work amongst amongst the 4 of you what you would like to do and
> let us know!
> 

Hey,

To give a bit of context, I sent some patches some time ago that deal with
this, but haven't had time to re-spin them [based on Jonathan's comments].

I've discussed with Dragos.
From our side, any version that is decided with respect to the `Co-
developed-by:` tag is fine. i.e. we don't need to be mentioned in the
commits.

I hope this is a sufficiently good answer [for the whole legal stuff].

> Patches look fine, though we need to let the DT maintainers have a few
> days at least to get around to looking if they want to (they don't always
> on simple bindings like these).
> 

Thanks
Alex

> Jonathan
>