| Message ID | 4a22502a318a65f144b3b6542cc5e711a1811c78.1544560544.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | .gitattributes: ensure t/oid-info/* has eol=lf | expand |
On Tue, Dec 11, 2018 at 12:35:46PM -0800, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee <dstolee@microsoft.com> > > The new test_oid machinery in the test library requires reading > some information from t/oid-info/hash-info and t/oid-info/oid. > The shell logic that reads from these files is sensitive to CRLF > line endings, causing a problem when the test suite is run on a > Windows machine that converts LF to CRLF. "What problem?" is what people will ask when they read this commit message in the future. Please include the relevant details in the commit message instead of the cover letter. > Exclude the files in this folder from this conversion. > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > --- > .gitattributes | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitattributes b/.gitattributes > index acf853e029..3738cea7eb 100644 > --- a/.gitattributes > +++ b/.gitattributes > @@ -13,3 +13,4 @@ > /Documentation/gitk.txt conflict-marker-size=32 > /Documentation/user-manual.txt conflict-marker-size=32 > /t/t????-*.sh conflict-marker-size=32 > +/t/oid-info/* eol=lf > -- > gitgitgadget
Hi Gábor, On Wed, 12 Dec 2018, SZEDER Gábor wrote: > On Tue, Dec 11, 2018 at 12:35:46PM -0800, Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee <dstolee@microsoft.com> > > > > The new test_oid machinery in the test library requires reading > > some information from t/oid-info/hash-info and t/oid-info/oid. > > The shell logic that reads from these files is sensitive to CRLF > > line endings, causing a problem when the test suite is run on a > > Windows machine that converts LF to CRLF. > > "What problem?" is what people will ask when they read this commit > message in the future. The test script (not test case) fails with the rather terrifying message error: bug in the test script: bad hash algorithm See e.g. line 958 of the Build & Test log in the Windows phase of https://dev.azure.com/git-for-windows/git/_build/results?buildId=26757 Ciao, Dscho > Please include the relevant details in the commit message instead of > the cover letter. > > > Exclude the files in this folder from this conversion. > > > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > > --- > > .gitattributes | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/.gitattributes b/.gitattributes > > index acf853e029..3738cea7eb 100644 > > --- a/.gitattributes > > +++ b/.gitattributes > > @@ -13,3 +13,4 @@ > > /Documentation/gitk.txt conflict-marker-size=32 > > /Documentation/user-manual.txt conflict-marker-size=32 > > /t/t????-*.sh conflict-marker-size=32 > > +/t/oid-info/* eol=lf > > -- > > gitgitgadget >
On Thu, Dec 13, 2018 at 02:01:15PM +0100, Johannes Schindelin wrote: > Hi Gábor, > > On Wed, 12 Dec 2018, SZEDER Gábor wrote: > > > On Tue, Dec 11, 2018 at 12:35:46PM -0800, Derrick Stolee via GitGitGadget wrote: > > > From: Derrick Stolee <dstolee@microsoft.com> > > > > > > The new test_oid machinery in the test library requires reading > > > some information from t/oid-info/hash-info and t/oid-info/oid. > > > The shell logic that reads from these files is sensitive to CRLF > > > line endings, causing a problem when the test suite is run on a > > > Windows machine that converts LF to CRLF. > > > > "What problem?" is what people will ask when they read this commit > > message in the future. > > The test script (not test case) fails with the rather terrifying message > > error: bug in the test script: bad hash algorithm > > See e.g. line 958 of the Build & Test log in the Windows phase of > https://dev.azure.com/git-for-windows/git/_build/results?buildId=26757 Yeah, I saw that in the cover letter. And that was my point, that I saw this there, not in the proposed commit log message: > > Please include the relevant details in the commit message instead of > > the cover letter.
Hi Gábor, On Thu, 13 Dec 2018, SZEDER Gábor wrote: > On Thu, Dec 13, 2018 at 02:01:15PM +0100, Johannes Schindelin wrote: > > > > On Wed, 12 Dec 2018, SZEDER Gábor wrote: > > > > > On Tue, Dec 11, 2018 at 12:35:46PM -0800, Derrick Stolee via GitGitGadget wrote: > > > > From: Derrick Stolee <dstolee@microsoft.com> > > > > > > > > The new test_oid machinery in the test library requires reading > > > > some information from t/oid-info/hash-info and t/oid-info/oid. > > > > The shell logic that reads from these files is sensitive to CRLF > > > > line endings, causing a problem when the test suite is run on a > > > > Windows machine that converts LF to CRLF. > > > > > > "What problem?" is what people will ask when they read this commit > > > message in the future. > > > > The test script (not test case) fails with the rather terrifying message > > > > error: bug in the test script: bad hash algorithm > > > > See e.g. line 958 of the Build & Test log in the Windows phase of > > https://dev.azure.com/git-for-windows/git/_build/results?buildId=26757 > > Yeah, I saw that in the cover letter. And that was my point, that I > saw this there, not in the proposed commit log message: > > > > Please include the relevant details in the commit message instead of > > > the cover letter. Oy, oy, oy. I missed that. Where is the coffee. Ciao, Dscho
diff --git a/.gitattributes b/.gitattributes index acf853e029..3738cea7eb 100644 --- a/.gitattributes +++ b/.gitattributes @@ -13,3 +13,4 @@ /Documentation/gitk.txt conflict-marker-size=32 /Documentation/user-manual.txt conflict-marker-size=32 /t/t????-*.sh conflict-marker-size=32 +/t/oid-info/* eol=lf