| Message ID | 20181116163916.29621-12-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: Allwinner MIPI-DSI Burst mode support | expand |
Hi Thierry and David, On Fri, Nov 16, 2018 at 10:10 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > Add panel driver for it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > MAINTAINERS | 6 + > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ > 4 files changed, 302 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3dac08d0b3cb..40c8bfc974f4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4620,6 +4620,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/tve200/ > > +DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS > +M: Jagan Teki <jagan@amarulasolutions.com> > +S: Maintained > +F: drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > +F: Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt > + > DRM DRIVER FOR ILITEK ILI9225 PANELS > M: David Lechner <david@lechnology.com> > S: Maintained > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index d0d4e60f5153..bc70896fe43c 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -47,6 +47,15 @@ config DRM_PANEL_SIMPLE > that it can be automatically turned off when the panel goes into a > low power state. > > +config DRM_PANEL_FEIYANG_FY07024DI26A30D > + tristate "Feiyang FY07024DI26A30-D MIPI-DSI LCD panel" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y if you want to enable support for panels based on the > + Feiyang FY07024DI26A30-D MIPI-DSI interface. > + Any comments on this?
On Fri, Nov 16, 2018 at 10:09:15PM +0530, Jagan Teki wrote: > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > Add panel driver for it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > MAINTAINERS | 6 + > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ > 4 files changed, 302 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3dac08d0b3cb..40c8bfc974f4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4620,6 +4620,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/tve200/ > > +DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS > +M: Jagan Teki <jagan@amarulasolutions.com> > +S: Maintained > +F: drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > +F: Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt > + > DRM DRIVER FOR ILITEK ILI9225 PANELS > M: David Lechner <david@lechnology.com> > S: Maintained > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index d0d4e60f5153..bc70896fe43c 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -47,6 +47,15 @@ config DRM_PANEL_SIMPLE > that it can be automatically turned off when the panel goes into a > low power state. > > +config DRM_PANEL_FEIYANG_FY07024DI26A30D > + tristate "Feiyang FY07024DI26A30-D MIPI-DSI LCD panel" > + depends on OF > + depends on DRM_MIPI_DSI > + depends on BACKLIGHT_CLASS_DEVICE > + help > + Say Y if you want to enable support for panels based on the > + Feiyang FY07024DI26A30-D MIPI-DSI interface. > + > config DRM_PANEL_ILITEK_IL9322 > tristate "Ilitek ILI9322 320x240 QVGA panels" > depends on OF && SPI > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index 88011f06edb8..e23c017639c7 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -3,6 +3,7 @@ obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o > obj-$(CONFIG_DRM_PANEL_BANANAPI_S070WV20_ICN6211) += panel-bananapi-s070wv20-icn6211.o > obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o > obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o > +obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o > obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o > obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o > diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > new file mode 100644 > index 000000000000..a4b46bd8fdbe > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > @@ -0,0 +1,286 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2018 Amarula Solutions > + * Author: Jagan Teki <jagan@amarulasolutions.com> > + */ > + > +#include <linux/backlight.h> > +#include <linux/delay.h> > +#include <linux/module.h> > +#include <linux/of_device.h> > + > +#include <linux/gpio/consumer.h> > +#include <linux/regulator/consumer.h> > + > +#include <drm/drmP.h> > +#include <drm/drm_mipi_dsi.h> > +#include <drm/drm_panel.h> > + > +struct feiyang { > + struct drm_panel panel; > + struct mipi_dsi_device *dsi; > + > + struct backlight_device *backlight; > + struct regulator *dvdd; > + struct regulator *avdd; > + struct gpio_desc *reset; > +}; > + > +static inline struct feiyang *panel_to_feiyang(struct drm_panel *panel) > +{ > + return container_of(panel, struct feiyang, panel); > +} > + > +struct feiyang_init_cmd { > + size_t len; > + const char *data; > +}; > + > +#define FY07024DI26A30D(...) { \ > + .len = sizeof((char[]){__VA_ARGS__}), \ > + .data = (char[]){__VA_ARGS__} } > + > +static const struct feiyang_init_cmd feiyang_init_cmds[] = { > + FY07024DI26A30D(0x80, 0x58), > + FY07024DI26A30D(0x81, 0x47), > + FY07024DI26A30D(0x82, 0xD4), > + FY07024DI26A30D(0x83, 0x88), > + FY07024DI26A30D(0x84, 0xA9), > + FY07024DI26A30D(0x85, 0xC3), > + FY07024DI26A30D(0x86, 0x82), > +}; These init cmds don't have to be so complicated. You've only got len == 2, so just hardcode it in and avoid the macro: #define FEIYANG_INIT_CMD_LEN 2 struct feiyang_init_cmd { u8 data[FEIYANG_INIT_CMD]; }; static const struct feiyang_init_cmd feiyang_init_cmds[] = { { .data = { 0x80, 0x58 } }, ... }; > + > +static int feiyang_prepare(struct drm_panel *panel) > +{ > + struct feiyang *ctx = panel_to_feiyang(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + unsigned int i; > + int ret; > + > + ret = regulator_enable(ctx->dvdd); > + if (ret) > + return ret; > + > + msleep(100); nit: You should do your best to correlate the sleeps with the timing parameters from the datasheet with a comment. ie: /* T1: > 100ms */ msleep(100); > + > + ret = regulator_enable(ctx->avdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 0); > + msleep(20); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(200); > + > + for (i = 0; i < ARRAY_SIZE(feiyang_init_cmds); i++) { > + const struct feiyang_init_cmd *cmd = > + &feiyang_init_cmds[i]; > + > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, cmd->len); ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, FEIYANG_INIT_CMD_LEN); > + if (ret < 0) > + return ret; > + } > + > + return 0; > +} > + > +static int feiyang_enable(struct drm_panel *panel) > +{ > + struct feiyang *ctx = panel_to_feiyang(panel); > + > + msleep(120); > + > + mipi_dsi_dcs_set_display_on(ctx->dsi); > + backlight_enable(ctx->backlight); > + > + return 0; > +} > + > +static int feiyang_disable(struct drm_panel *panel) > +{ > + struct feiyang *ctx = panel_to_feiyang(panel); > + > + backlight_disable(ctx->backlight); > + return mipi_dsi_dcs_set_display_on(ctx->dsi); set_display_on? You probably want set_display_off here :) > +} > + > +static int feiyang_unprepare(struct drm_panel *panel) > +{ > + struct feiyang *ctx = panel_to_feiyang(panel); > + int ret; > + > + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", > + ret); > + > + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", > + ret); > + > + msleep(100); > + > + regulator_disable(ctx->avdd); > + > + regulator_disable(ctx->dvdd); > + > + gpiod_set_value(ctx->reset, 0); > + > + gpiod_set_value(ctx->reset, 1); > + > + gpiod_set_value(ctx->reset, 0); Presumably this reset line toggle isn't needed since the rails are already disabled? > + > + return 0; > +} > + > +static const struct drm_display_mode feiyang_default_mode = { > + .clock = 55000, > + .vrefresh = 60, This doesn't add up correctly. The pixel clock should be equal to: (htotal * vtotal * vrefresh) / 1000 For this reason, we usually don't specify the refresh rate since it can be misleading. Your actual refresh rate with the pixel clock you specified is actually going to be 56.2Hz instead of the 60 you want. If you can only generate a 55MHz pixel clock, consider reducing your blanking periods so the calculation above matches. > + > + .hdisplay = 1024, > + .hsync_start = 1024 + 396, > + .hsync_end = 1024 + 396 + 20, > + .htotal = 1024 + 396 + 20 + 100, > + > + .vdisplay = 600, > + .vsync_start = 600 + 12, > + .vsync_end = 600 + 12 + 2, > + .vtotal = 600 + 12 + 2 + 21, > +}; > + > +static int feiyang_get_modes(struct drm_panel *panel) > +{ > + struct drm_connector *connector = panel->connector; > + struct feiyang *ctx = panel_to_feiyang(panel); > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(panel->drm, &feiyang_default_mode); > + if (!mode) { > + DRM_DEV_ERROR(&ctx->dsi->dev, "failed to add mode %ux%ux@%u\n", > + feiyang_default_mode.hdisplay, > + feiyang_default_mode.vdisplay, > + feiyang_default_mode.vrefresh); > + return -ENOMEM; > + } > + > + drm_mode_set_name(mode); > + > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; Just set these above. > + drm_mode_probed_add(connector, mode); > + > + return 1; > +} > + > +static const struct drm_panel_funcs feiyang_funcs = { > + .disable = feiyang_disable, > + .unprepare = feiyang_unprepare, > + .prepare = feiyang_prepare, > + .enable = feiyang_enable, > + .get_modes = feiyang_get_modes, > +}; > + > +static int feiyang_dsi_probe(struct mipi_dsi_device *dsi) > +{ > + struct device_node *np; > + struct feiyang *ctx; > + int ret; > + > + ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + mipi_dsi_set_drvdata(dsi, ctx); > + ctx->dsi = dsi; > + > + drm_panel_init(&ctx->panel); > + ctx->panel.dev = &dsi->dev; > + ctx->panel.funcs = &feiyang_funcs; > + > + ctx->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); > + if (IS_ERR(ctx->dvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); > + return PTR_ERR(ctx->dvdd); > + } > + > + ctx->avdd = devm_regulator_get(&dsi->dev, "avdd"); > + if (IS_ERR(ctx->avdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); > + return PTR_ERR(ctx->avdd); > + } > + > + ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(ctx->reset)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); > + return PTR_ERR(ctx->reset); > + } > + > + np = of_parse_phandle(dsi->dev.of_node, "backlight", 0); > + if (np) { > + ctx->backlight = of_find_backlight_by_node(np); > + of_node_put(np); > + > + if (!ctx->backlight) > + return -EPROBE_DEFER; > + } > + > + ret = drm_panel_add(&ctx->panel); > + if (ret < 0) > + goto put_backlight; > + > + dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST; > + dsi->format = MIPI_DSI_FMT_RGB888; > + dsi->lanes = 4; > + > + ret = mipi_dsi_attach(dsi); > + if (ret < 0) > + goto panel_remove; > + > + return ret; > + > +panel_remove: > + drm_panel_remove(&ctx->panel); > +put_backlight: > + if (ctx->backlight) > + put_device(&ctx->backlight->dev); > + > + return ret; > +} > + > +static int feiyang_dsi_remove(struct mipi_dsi_device *dsi) > +{ > + struct feiyang *ctx = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&ctx->panel); > + > + if (ctx->backlight) > + put_device(&ctx->backlight->dev); > + > + return 0; > +} > + > +static const struct of_device_id feiyang_of_match[] = { > + { .compatible = "feiyang,fy07024di26a30d", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, feiyang_of_match); > + > +static struct mipi_dsi_driver feiyang_driver = { > + .probe = feiyang_dsi_probe, > + .remove = feiyang_dsi_remove, > + .driver = { > + .name = "feiyang-fy07024di26a30d", > + .of_match_table = feiyang_of_match, > + }, > +}; > +module_mipi_dsi_driver(feiyang_driver); > + > +MODULE_AUTHOR("Jagan Teki <jagan@amarulasolutions.com>"); > +MODULE_DESCRIPTION("Feiyang FY07024DI26A30-D MIPI-DSI LCD panel"); > +MODULE_LICENSE("GPL"); > -- > 2.18.0.321.gffc6fa0e3 >
On Thu, Dec 13, 2018 at 8:37 PM Sean Paul <sean@poorly.run> wrote: > > On Fri, Nov 16, 2018 at 10:09:15PM +0530, Jagan Teki wrote: > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > > > Add panel driver for it. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > MAINTAINERS | 6 + > > drivers/gpu/drm/panel/Kconfig | 9 + > > drivers/gpu/drm/panel/Makefile | 1 + > > .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ > > 4 files changed, 302 insertions(+) > > create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 3dac08d0b3cb..40c8bfc974f4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -4620,6 +4620,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > > S: Maintained > > F: drivers/gpu/drm/tve200/ > > > > +DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS > > +M: Jagan Teki <jagan@amarulasolutions.com> > > +S: Maintained > > +F: drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > +F: Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt > > + > > DRM DRIVER FOR ILITEK ILI9225 PANELS > > M: David Lechner <david@lechnology.com> > > S: Maintained > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > index d0d4e60f5153..bc70896fe43c 100644 > > --- a/drivers/gpu/drm/panel/Kconfig > > +++ b/drivers/gpu/drm/panel/Kconfig > > @@ -47,6 +47,15 @@ config DRM_PANEL_SIMPLE > > that it can be automatically turned off when the panel goes into a > > low power state. > > > > +config DRM_PANEL_FEIYANG_FY07024DI26A30D > > + tristate "Feiyang FY07024DI26A30-D MIPI-DSI LCD panel" > > + depends on OF > > + depends on DRM_MIPI_DSI > > + depends on BACKLIGHT_CLASS_DEVICE > > + help > > + Say Y if you want to enable support for panels based on the > > + Feiyang FY07024DI26A30-D MIPI-DSI interface. > > + > > config DRM_PANEL_ILITEK_IL9322 > > tristate "Ilitek ILI9322 320x240 QVGA panels" > > depends on OF && SPI > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > > index 88011f06edb8..e23c017639c7 100644 > > --- a/drivers/gpu/drm/panel/Makefile > > +++ b/drivers/gpu/drm/panel/Makefile > > @@ -3,6 +3,7 @@ obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o > > obj-$(CONFIG_DRM_PANEL_BANANAPI_S070WV20_ICN6211) += panel-bananapi-s070wv20-icn6211.o > > obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o > > obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o > > +obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o > > obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o > > obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o > > obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o > > diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > new file mode 100644 > > index 000000000000..a4b46bd8fdbe > > --- /dev/null > > +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > @@ -0,0 +1,286 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright (C) 2018 Amarula Solutions > > + * Author: Jagan Teki <jagan@amarulasolutions.com> > > + */ > > + > > +#include <linux/backlight.h> > > +#include <linux/delay.h> > > +#include <linux/module.h> > > +#include <linux/of_device.h> > > + > > +#include <linux/gpio/consumer.h> > > +#include <linux/regulator/consumer.h> > > + > > +#include <drm/drmP.h> > > +#include <drm/drm_mipi_dsi.h> > > +#include <drm/drm_panel.h> > > + > > +struct feiyang { > > + struct drm_panel panel; > > + struct mipi_dsi_device *dsi; > > + > > + struct backlight_device *backlight; > > + struct regulator *dvdd; > > + struct regulator *avdd; > > + struct gpio_desc *reset; > > +}; > > + > > +static inline struct feiyang *panel_to_feiyang(struct drm_panel *panel) > > +{ > > + return container_of(panel, struct feiyang, panel); > > +} > > + > > +struct feiyang_init_cmd { > > + size_t len; > > + const char *data; > > +}; > > + > > +#define FY07024DI26A30D(...) { \ > > + .len = sizeof((char[]){__VA_ARGS__}), \ > > + .data = (char[]){__VA_ARGS__} } > > + > > +static const struct feiyang_init_cmd feiyang_init_cmds[] = { > > + FY07024DI26A30D(0x80, 0x58), > > + FY07024DI26A30D(0x81, 0x47), > > + FY07024DI26A30D(0x82, 0xD4), > > + FY07024DI26A30D(0x83, 0x88), > > + FY07024DI26A30D(0x84, 0xA9), > > + FY07024DI26A30D(0x85, 0xC3), > > + FY07024DI26A30D(0x86, 0x82), > > +}; > > These init cmds don't have to be so complicated. You've only got len == 2, so > just hardcode it in and avoid the macro: > > #define FEIYANG_INIT_CMD_LEN 2 > > struct feiyang_init_cmd { > u8 data[FEIYANG_INIT_CMD]; > }; > > static const struct feiyang_init_cmd feiyang_init_cmds[] = { > { .data = { 0x80, 0x58 } }, > ... > }; > > > + > > +static int feiyang_prepare(struct drm_panel *panel) > > +{ > > + struct feiyang *ctx = panel_to_feiyang(panel); > > + struct mipi_dsi_device *dsi = ctx->dsi; > > + unsigned int i; > > + int ret; > > + > > + ret = regulator_enable(ctx->dvdd); > > + if (ret) > > + return ret; > > + > > + msleep(100); > > nit: You should do your best to correlate the sleeps with the timing parameters > from the datasheet with a comment. > > ie: > /* T1: > 100ms */ > msleep(100); Sorry, what does this mean? > > > + > > + ret = regulator_enable(ctx->avdd); > > + if (ret) > > + return ret; > > + > > + msleep(20); > > + > > + gpiod_set_value(ctx->reset, 1); > > + msleep(50); > > + > > + gpiod_set_value(ctx->reset, 0); > > + msleep(20); > > + > > + gpiod_set_value(ctx->reset, 1); > > + msleep(200); > > + > > + for (i = 0; i < ARRAY_SIZE(feiyang_init_cmds); i++) { > > + const struct feiyang_init_cmd *cmd = > > + &feiyang_init_cmds[i]; > > + > > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, cmd->len); > > ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, > FEIYANG_INIT_CMD_LEN); > > > + if (ret < 0) > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static int feiyang_enable(struct drm_panel *panel) > > +{ > > + struct feiyang *ctx = panel_to_feiyang(panel); > > + > > + msleep(120); > > + > > + mipi_dsi_dcs_set_display_on(ctx->dsi); > > + backlight_enable(ctx->backlight); > > + > > + return 0; > > +} > > + > > +static int feiyang_disable(struct drm_panel *panel) > > +{ > > + struct feiyang *ctx = panel_to_feiyang(panel); > > + > > + backlight_disable(ctx->backlight); > > + return mipi_dsi_dcs_set_display_on(ctx->dsi); > > set_display_on? You probably want set_display_off here :) > > > +} > > + > > +static int feiyang_unprepare(struct drm_panel *panel) > > +{ > > + struct feiyang *ctx = panel_to_feiyang(panel); > > + int ret; > > + > > + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > > + if (ret < 0) > > + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", > > + ret); > > + > > + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > > + if (ret < 0) > > + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", > > + ret); > > + > > + msleep(100); > > + > > + regulator_disable(ctx->avdd); > > + > > + regulator_disable(ctx->dvdd); > > + > > + gpiod_set_value(ctx->reset, 0); > > + > > + gpiod_set_value(ctx->reset, 1); > > + > > + gpiod_set_value(ctx->reset, 0); > > Presumably this reset line toggle isn't needed since the rails are already > disabled? Yes, rails need to reset and turn off. will swap. > > > + > > + return 0; > > +} > > + > > +static const struct drm_display_mode feiyang_default_mode = { > > + .clock = 55000, > > + .vrefresh = 60, > > This doesn't add up correctly. The pixel clock should be equal to: > > (htotal * vtotal * vrefresh) / 1000 > > For this reason, we usually don't specify the refresh rate since it can be > misleading. Your actual refresh rate with the pixel clock you specified is > actually going to be 56.2Hz instead of the 60 you want. The actual BSP do work 55MHz[1], I do specify refresh rate unnecessarily. [1] https://gitlab.com/pine64-android/tools/blob/01b3d9388439106bdd9985cf738c1b876bd617d3/pack/chips/sun50iw1p1/configs/db1000_lcd/sys_config_rgmii.fex#L483
On Fri, Dec 14, 2018 at 12:56:03AM +0530, Jagan Teki wrote: > On Thu, Dec 13, 2018 at 8:37 PM Sean Paul <sean@poorly.run> wrote: > > > > On Fri, Nov 16, 2018 at 10:09:15PM +0530, Jagan Teki wrote: > > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > > > > > Add panel driver for it. > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > --- > > > MAINTAINERS | 6 + > > > drivers/gpu/drm/panel/Kconfig | 9 + > > > drivers/gpu/drm/panel/Makefile | 1 + > > > .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ > > > 4 files changed, 302 insertions(+) > > > create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > /snip > > > diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > new file mode 100644 > > > index 000000000000..a4b46bd8fdbe > > > --- /dev/null > > > +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c /snip > > > +static int feiyang_prepare(struct drm_panel *panel) > > > +{ > > > + struct feiyang *ctx = panel_to_feiyang(panel); > > > + struct mipi_dsi_device *dsi = ctx->dsi; > > > + unsigned int i; > > > + int ret; > > > + > > > + ret = regulator_enable(ctx->dvdd); > > > + if (ret) > > > + return ret; > > > + > > > + msleep(100); > > > > nit: You should do your best to correlate the sleeps with the timing parameters > > from the datasheet with a comment. > > > > ie: > > /* T1: > 100ms */ > > msleep(100); > > Sorry, what does this mean? On page 9 of the datasheet you sent me [1], it has the delays required to safely power up the panel. This delay is the time between dvdd going high and avdd going high. On the figure in the datasheet, this would be T2 (T1 is dvdd rise time and should be handled in the regulator subsystem (iirc)). Also according to the datasheet, T2 just needs to be > 0, so you don't even need this delay. You could replace this with a comment like: /* T1 (dvdd rise time) + T2 (dvdd->avdd) > 0 */ So for all of the msleeps below you should get the delays from the datasheet and add a comment referencing them. Sean [1] - http://files.pine64.org/doc/datasheet/pine64/FY07024DI26A30-D_feiyang_LCD_panel.pdf > > > > > > + > > > + ret = regulator_enable(ctx->avdd); > > > + if (ret) > > > + return ret; > > > + > > > + msleep(20); > > > + > > > + gpiod_set_value(ctx->reset, 1); > > > + msleep(50); > > > + > > > + gpiod_set_value(ctx->reset, 0); > > > + msleep(20); > > > + > > > + gpiod_set_value(ctx->reset, 1); > > > + msleep(200); > > > + > > > + for (i = 0; i < ARRAY_SIZE(feiyang_init_cmds); i++) { > > > + const struct feiyang_init_cmd *cmd = > > > + &feiyang_init_cmds[i]; > > > + > > > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, cmd->len); > > > > ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, > > FEIYANG_INIT_CMD_LEN); > > > > > + if (ret < 0) > > > + return ret; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int feiyang_enable(struct drm_panel *panel) > > > +{ > > > + struct feiyang *ctx = panel_to_feiyang(panel); > > > + > > > + msleep(120); > > > + > > > + mipi_dsi_dcs_set_display_on(ctx->dsi); > > > + backlight_enable(ctx->backlight); > > > + > > > + return 0; > > > +} > > > + > > > +static int feiyang_disable(struct drm_panel *panel) > > > +{ > > > + struct feiyang *ctx = panel_to_feiyang(panel); > > > + > > > + backlight_disable(ctx->backlight); > > > + return mipi_dsi_dcs_set_display_on(ctx->dsi); > > > > set_display_on? You probably want set_display_off here :) > > > > > +} > > > + > > > +static int feiyang_unprepare(struct drm_panel *panel) > > > +{ > > > + struct feiyang *ctx = panel_to_feiyang(panel); > > > + int ret; > > > + > > > + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > > > + if (ret < 0) > > > + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", > > > + ret); > > > + > > > + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > > > + if (ret < 0) > > > + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", > > > + ret); > > > + > > > + msleep(100); > > > + > > > + regulator_disable(ctx->avdd); > > > + > > > + regulator_disable(ctx->dvdd); > > > + > > > + gpiod_set_value(ctx->reset, 0); > > > + > > > + gpiod_set_value(ctx->reset, 1); > > > + > > > + gpiod_set_value(ctx->reset, 0); > > > > Presumably this reset line toggle isn't needed since the rails are already > > disabled? > > Yes, rails need to reset and turn off. will swap. > > > > > > + > > > + return 0; > > > +} > > > + > > > +static const struct drm_display_mode feiyang_default_mode = { > > > + .clock = 55000, > > > + .vrefresh = 60, > > > > This doesn't add up correctly. The pixel clock should be equal to: > > > > (htotal * vtotal * vrefresh) / 1000 > > > > For this reason, we usually don't specify the refresh rate since it can be > > misleading. Your actual refresh rate with the pixel clock you specified is > > actually going to be 56.2Hz instead of the 60 you want. > > The actual BSP do work 55MHz[1], I do specify refresh rate unnecessarily. Well, the BSP has a bug in it then :) You either want the refresh rate to be 60Hz or you want the pixel clock to be 55MHz, you can't have both with the timing you have now. You'll need to alter the pixel clock or porches to get 60Hz. Sean > > [1] https://gitlab.com/pine64-android/tools/blob/01b3d9388439106bdd9985cf738c1b876bd617d3/pack/chips/sun50iw1p1/configs/db1000_lcd/sys_config_rgmii.fex#L483
On Fri, Dec 14, 2018 at 1:25 AM Sean Paul <sean@poorly.run> wrote: > > On Fri, Dec 14, 2018 at 12:56:03AM +0530, Jagan Teki wrote: > > On Thu, Dec 13, 2018 at 8:37 PM Sean Paul <sean@poorly.run> wrote: > > > > > > On Fri, Nov 16, 2018 at 10:09:15PM +0530, Jagan Teki wrote: > > > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > > > > > > > Add panel driver for it. > > > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > > --- > > > > MAINTAINERS | 6 + > > > > drivers/gpu/drm/panel/Kconfig | 9 + > > > > drivers/gpu/drm/panel/Makefile | 1 + > > > > .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ > > > > 4 files changed, 302 insertions(+) > > > > create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > > > > /snip > > > > > diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > > new file mode 100644 > > > > index 000000000000..a4b46bd8fdbe > > > > --- /dev/null > > > > +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > /snip > > > > > +static int feiyang_prepare(struct drm_panel *panel) > > > > +{ > > > > + struct feiyang *ctx = panel_to_feiyang(panel); > > > > + struct mipi_dsi_device *dsi = ctx->dsi; > > > > + unsigned int i; > > > > + int ret; > > > > + > > > > + ret = regulator_enable(ctx->dvdd); > > > > + if (ret) > > > > + return ret; > > > > + > > > > + msleep(100); > > > > > > nit: You should do your best to correlate the sleeps with the timing parameters > > > from the datasheet with a comment. > > > > > > ie: > > > /* T1: > 100ms */ > > > msleep(100); > > > > Sorry, what does this mean? > > On page 9 of the datasheet you sent me [1], it has the delays required to safely > power up the panel. This delay is the time between dvdd going high and avdd > going high. On the figure in the datasheet, this would be T2 (T1 is dvdd rise time between dvdd going high and avdd going high is T1 + T3 right? T2 > 0ms T3 > 20ms In this case the delay can be msleep(20) ? > time and should be handled in the regulator subsystem (iirc)). Also according to > the datasheet, T2 just needs to be > 0, so you don't even need this delay. You > could replace this with a comment like: > > /* T1 (dvdd rise time) + T2 (dvdd->avdd) > 0 */ > > So for all of the msleeps below you should get the delays from the datasheet and > add a comment referencing them. T5 and T6 are delay between avdd to reset enable it can be 10 + 10 => 20ms and finally T12 which is 200 after reset. What about the delay between resets, I need to understand it a bit.
On Fri, Dec 14, 2018 at 04:35:11PM +0530, Jagan Teki wrote: > On Fri, Dec 14, 2018 at 1:25 AM Sean Paul <sean@poorly.run> wrote: > > > > On Fri, Dec 14, 2018 at 12:56:03AM +0530, Jagan Teki wrote: > > > On Thu, Dec 13, 2018 at 8:37 PM Sean Paul <sean@poorly.run> wrote: > > > > > > > > On Fri, Nov 16, 2018 at 10:09:15PM +0530, Jagan Teki wrote: > > > > > Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. > > > > > > > > > > Add panel driver for it. > > > > > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > > > --- > > > > > MAINTAINERS | 6 + > > > > > drivers/gpu/drm/panel/Kconfig | 9 + > > > > > drivers/gpu/drm/panel/Makefile | 1 + > > > > > .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ > > > > > 4 files changed, 302 insertions(+) > > > > > create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > > > > > > > /snip > > > > > > > diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > > > new file mode 100644 > > > > > index 000000000000..a4b46bd8fdbe > > > > > --- /dev/null > > > > > +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c > > > > /snip > > > > > > > +static int feiyang_prepare(struct drm_panel *panel) > > > > > +{ > > > > > + struct feiyang *ctx = panel_to_feiyang(panel); > > > > > + struct mipi_dsi_device *dsi = ctx->dsi; > > > > > + unsigned int i; > > > > > + int ret; > > > > > + > > > > > + ret = regulator_enable(ctx->dvdd); > > > > > + if (ret) > > > > > + return ret; > > > > > + > > > > > + msleep(100); > > > > > > > > nit: You should do your best to correlate the sleeps with the timing parameters > > > > from the datasheet with a comment. > > > > > > > > ie: > > > > /* T1: > 100ms */ > > > > msleep(100); > > > > > > Sorry, what does this mean? > > > > On page 9 of the datasheet you sent me [1], it has the delays required to safely > > power up the panel. This delay is the time between dvdd going high and avdd > > going high. On the figure in the datasheet, this would be T2 (T1 is dvdd rise > > time between dvdd going high and avdd going high is T1 + T3 right? > > T2 > 0ms > T3 > 20ms > > In this case the delay can be msleep(20) ? Hmm, yeah, I didn't notice that T3 was > 20ms, that's kind of confusing. So I think you're right, this should be T2 + T3 > 20ms (T1 is covered in the regulator_enable of dvdd). > > > time and should be handled in the regulator subsystem (iirc)). Also according to > > the datasheet, T2 just needs to be > 0, so you don't even need this delay. You > > could replace this with a comment like: > > > > /* T1 (dvdd rise time) + T2 (dvdd->avdd) > 0 */ > > > > So for all of the msleeps below you should get the delays from the datasheet and > > add a comment referencing them. > > T5 and T6 are delay between avdd to reset enable it can be 10 + 10 > => 20ms and finally T12 which is 200 after reset. > > What about the delay between resets, I need to understand it a bit. These are usually accounted for at the end of disable. Take a look at the sleep parameters in panel-simple for an example. Sean
diff --git a/MAINTAINERS b/MAINTAINERS index 3dac08d0b3cb..40c8bfc974f4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4620,6 +4620,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/tve200/ +DRM DRIVER FOR FEIYANG FY07024DI26A30-D MIPI-DSI LCD PANELS +M: Jagan Teki <jagan@amarulasolutions.com> +S: Maintained +F: drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c +F: Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.txt + DRM DRIVER FOR ILITEK ILI9225 PANELS M: David Lechner <david@lechnology.com> S: Maintained diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index d0d4e60f5153..bc70896fe43c 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -47,6 +47,15 @@ config DRM_PANEL_SIMPLE that it can be automatically turned off when the panel goes into a low power state. +config DRM_PANEL_FEIYANG_FY07024DI26A30D + tristate "Feiyang FY07024DI26A30-D MIPI-DSI LCD panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for panels based on the + Feiyang FY07024DI26A30-D MIPI-DSI interface. + config DRM_PANEL_ILITEK_IL9322 tristate "Ilitek ILI9322 320x240 QVGA panels" depends on OF && SPI diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 88011f06edb8..e23c017639c7 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -3,6 +3,7 @@ obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o obj-$(CONFIG_DRM_PANEL_BANANAPI_S070WV20_ICN6211) += panel-bananapi-s070wv20-icn6211.o obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o +obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c new file mode 100644 index 000000000000..a4b46bd8fdbe --- /dev/null +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c @@ -0,0 +1,286 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2018 Amarula Solutions + * Author: Jagan Teki <jagan@amarulasolutions.com> + */ + +#include <linux/backlight.h> +#include <linux/delay.h> +#include <linux/module.h> +#include <linux/of_device.h> + +#include <linux/gpio/consumer.h> +#include <linux/regulator/consumer.h> + +#include <drm/drmP.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_panel.h> + +struct feiyang { + struct drm_panel panel; + struct mipi_dsi_device *dsi; + + struct backlight_device *backlight; + struct regulator *dvdd; + struct regulator *avdd; + struct gpio_desc *reset; +}; + +static inline struct feiyang *panel_to_feiyang(struct drm_panel *panel) +{ + return container_of(panel, struct feiyang, panel); +} + +struct feiyang_init_cmd { + size_t len; + const char *data; +}; + +#define FY07024DI26A30D(...) { \ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +static const struct feiyang_init_cmd feiyang_init_cmds[] = { + FY07024DI26A30D(0x80, 0x58), + FY07024DI26A30D(0x81, 0x47), + FY07024DI26A30D(0x82, 0xD4), + FY07024DI26A30D(0x83, 0x88), + FY07024DI26A30D(0x84, 0xA9), + FY07024DI26A30D(0x85, 0xC3), + FY07024DI26A30D(0x86, 0x82), +}; + +static int feiyang_prepare(struct drm_panel *panel) +{ + struct feiyang *ctx = panel_to_feiyang(panel); + struct mipi_dsi_device *dsi = ctx->dsi; + unsigned int i; + int ret; + + ret = regulator_enable(ctx->dvdd); + if (ret) + return ret; + + msleep(100); + + ret = regulator_enable(ctx->avdd); + if (ret) + return ret; + + msleep(20); + + gpiod_set_value(ctx->reset, 1); + msleep(50); + + gpiod_set_value(ctx->reset, 0); + msleep(20); + + gpiod_set_value(ctx->reset, 1); + msleep(200); + + for (i = 0; i < ARRAY_SIZE(feiyang_init_cmds); i++) { + const struct feiyang_init_cmd *cmd = + &feiyang_init_cmds[i]; + + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, cmd->len); + if (ret < 0) + return ret; + } + + return 0; +} + +static int feiyang_enable(struct drm_panel *panel) +{ + struct feiyang *ctx = panel_to_feiyang(panel); + + msleep(120); + + mipi_dsi_dcs_set_display_on(ctx->dsi); + backlight_enable(ctx->backlight); + + return 0; +} + +static int feiyang_disable(struct drm_panel *panel) +{ + struct feiyang *ctx = panel_to_feiyang(panel); + + backlight_disable(ctx->backlight); + return mipi_dsi_dcs_set_display_on(ctx->dsi); +} + +static int feiyang_unprepare(struct drm_panel *panel) +{ + struct feiyang *ctx = panel_to_feiyang(panel); + int ret; + + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); + if (ret < 0) + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", + ret); + + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); + if (ret < 0) + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", + ret); + + msleep(100); + + regulator_disable(ctx->avdd); + + regulator_disable(ctx->dvdd); + + gpiod_set_value(ctx->reset, 0); + + gpiod_set_value(ctx->reset, 1); + + gpiod_set_value(ctx->reset, 0); + + return 0; +} + +static const struct drm_display_mode feiyang_default_mode = { + .clock = 55000, + .vrefresh = 60, + + .hdisplay = 1024, + .hsync_start = 1024 + 396, + .hsync_end = 1024 + 396 + 20, + .htotal = 1024 + 396 + 20 + 100, + + .vdisplay = 600, + .vsync_start = 600 + 12, + .vsync_end = 600 + 12 + 2, + .vtotal = 600 + 12 + 2 + 21, +}; + +static int feiyang_get_modes(struct drm_panel *panel) +{ + struct drm_connector *connector = panel->connector; + struct feiyang *ctx = panel_to_feiyang(panel); + struct drm_display_mode *mode; + + mode = drm_mode_duplicate(panel->drm, &feiyang_default_mode); + if (!mode) { + DRM_DEV_ERROR(&ctx->dsi->dev, "failed to add mode %ux%ux@%u\n", + feiyang_default_mode.hdisplay, + feiyang_default_mode.vdisplay, + feiyang_default_mode.vrefresh); + return -ENOMEM; + } + + drm_mode_set_name(mode); + + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; + drm_mode_probed_add(connector, mode); + + return 1; +} + +static const struct drm_panel_funcs feiyang_funcs = { + .disable = feiyang_disable, + .unprepare = feiyang_unprepare, + .prepare = feiyang_prepare, + .enable = feiyang_enable, + .get_modes = feiyang_get_modes, +}; + +static int feiyang_dsi_probe(struct mipi_dsi_device *dsi) +{ + struct device_node *np; + struct feiyang *ctx; + int ret; + + ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + mipi_dsi_set_drvdata(dsi, ctx); + ctx->dsi = dsi; + + drm_panel_init(&ctx->panel); + ctx->panel.dev = &dsi->dev; + ctx->panel.funcs = &feiyang_funcs; + + ctx->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); + if (IS_ERR(ctx->dvdd)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); + return PTR_ERR(ctx->dvdd); + } + + ctx->avdd = devm_regulator_get(&dsi->dev, "avdd"); + if (IS_ERR(ctx->avdd)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); + return PTR_ERR(ctx->avdd); + } + + ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(ctx->reset)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); + return PTR_ERR(ctx->reset); + } + + np = of_parse_phandle(dsi->dev.of_node, "backlight", 0); + if (np) { + ctx->backlight = of_find_backlight_by_node(np); + of_node_put(np); + + if (!ctx->backlight) + return -EPROBE_DEFER; + } + + ret = drm_panel_add(&ctx->panel); + if (ret < 0) + goto put_backlight; + + dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST; + dsi->format = MIPI_DSI_FMT_RGB888; + dsi->lanes = 4; + + ret = mipi_dsi_attach(dsi); + if (ret < 0) + goto panel_remove; + + return ret; + +panel_remove: + drm_panel_remove(&ctx->panel); +put_backlight: + if (ctx->backlight) + put_device(&ctx->backlight->dev); + + return ret; +} + +static int feiyang_dsi_remove(struct mipi_dsi_device *dsi) +{ + struct feiyang *ctx = mipi_dsi_get_drvdata(dsi); + + mipi_dsi_detach(dsi); + drm_panel_remove(&ctx->panel); + + if (ctx->backlight) + put_device(&ctx->backlight->dev); + + return 0; +} + +static const struct of_device_id feiyang_of_match[] = { + { .compatible = "feiyang,fy07024di26a30d", }, + { } +}; +MODULE_DEVICE_TABLE(of, feiyang_of_match); + +static struct mipi_dsi_driver feiyang_driver = { + .probe = feiyang_dsi_probe, + .remove = feiyang_dsi_remove, + .driver = { + .name = "feiyang-fy07024di26a30d", + .of_match_table = feiyang_of_match, + }, +}; +module_mipi_dsi_driver(feiyang_driver); + +MODULE_AUTHOR("Jagan Teki <jagan@amarulasolutions.com>"); +MODULE_DESCRIPTION("Feiyang FY07024DI26A30-D MIPI-DSI LCD panel"); +MODULE_LICENSE("GPL");
Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel. Add panel driver for it. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../drm/panel/panel-feiyang-fy07024di26a30d.c | 286 ++++++++++++++++++ 4 files changed, 302 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c