| Message ID | 20181214115650.12443-2-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Rejected |
| Commit | ec221af969205b4d006e51907ad34a6d35c8ae8b |
| Headers | show |
| Series | [1/3] arm64: defconfig: Enable R-Car thermal driver | expand |
Hi Simon > Enable the scu-simple-card which is used by > the R-Car E3 (r8a77990) based Ebisu board. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index f88190463481..b521159f5f33 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m > CONFIG_SND_SOC_RT5514_SPI=m > CONFIG_SND_SOC_RT5645=m > CONFIG_SND_SIMPLE_CARD=m > +CONFIG_SND_SIMPLE_SCU_CARD=m > CONFIG_SND_AUDIO_GRAPH_CARD=m > CONFIG_I2C_HID=m > CONFIG_USB=y Is Ebisu board using SIMPLE_SCU_CARD ? I guess it is SIMPLE or AUDIO_GRAPH CARD, not SCU_CARD.
On Mon, Dec 17, 2018 at 09:29:25AM +0900, Kuninori Morimoto wrote: > > Hi Simon > > > Enable the scu-simple-card which is used by > > the R-Car E3 (r8a77990) based Ebisu board. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index f88190463481..b521159f5f33 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m > > CONFIG_SND_SOC_RT5514_SPI=m > > CONFIG_SND_SOC_RT5645=m > > CONFIG_SND_SIMPLE_CARD=m > > +CONFIG_SND_SIMPLE_SCU_CARD=m > > CONFIG_SND_AUDIO_GRAPH_CARD=m > > CONFIG_I2C_HID=m > > CONFIG_USB=y > > Is Ebisu board using SIMPLE_SCU_CARD ? > I guess it is SIMPLE or AUDIO_GRAPH CARD, not SCU_CARD. > Hi Morimoto-san, Using renesas_defconfig as a base I find that without enabling CONFIG_SND_SIMPLE_SCU_CARD the following are enabled: CONFIG_SND_AUDIO_GRAPH_CARD CONFIG_SND_SIMPLE_CARD But I see: [ 12.209793] ALSA device list: [ 12.212799] No soundcards found. With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see: [ 14.087191] ALSA device list: [ 14.090195] #0: rsnd-ak4613 The above tested using renesas-drivers-2018-12-04-v4.20-rc5
Hi Simon > Using renesas_defconfig as a base I find that without enabling > CONFIG_SND_SIMPLE_SCU_CARD the following are enabled: > > CONFIG_SND_AUDIO_GRAPH_CARD > CONFIG_SND_SIMPLE_CARD > > But I see: > > [ 12.209793] ALSA device list: > [ 12.212799] No soundcards found. > > With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see: > > [ 14.087191] ALSA device list: > [ 14.090195] #0: rsnd-ak4613 Thanks. 56629fcba94c698d8c5be3413981506479566869 ("arm64: dts: renesas: ebisu: Enable Audio") is using "simple-scu-audio-card", but it should be "simple-audio-card". Can you add and test this patch ? CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think. -------------- diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 62bdddc..649d3fd 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts @@ -159,16 +159,13 @@ }; rsnd_ak4613: sound { - compatible = "simple-scu-audio-card"; + compatible = "simple-audio-card"; simple-audio-card,name = "rsnd-ak4613"; simple-audio-card,format = "left_j"; simple-audio-card,bitclock-master = <&sndcpu>; simple-audio-card,frame-master = <&sndcpu>; - simple-audio-card,prefix = "ak4613"; - simple-audio-card,routing = "ak4613 Playback", "DAI0 Playback", - "DAI0 Capture", "ak4613 Capture"; sndcpu: simple-audio-card,cpu { sound-dai = <&rcar_sound>; }; -------------- Best regards --- Kuninori Morimoto
On Mon, Dec 17, 2018 at 05:49:34PM +0900, Kuninori Morimoto wrote: > > Hi Simon > > > Using renesas_defconfig as a base I find that without enabling > > CONFIG_SND_SIMPLE_SCU_CARD the following are enabled: > > > > CONFIG_SND_AUDIO_GRAPH_CARD > > CONFIG_SND_SIMPLE_CARD > > > > But I see: > > > > [ 12.209793] ALSA device list: > > [ 12.212799] No soundcards found. > > > > With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see: > > > > [ 14.087191] ALSA device list: > > [ 14.090195] #0: rsnd-ak4613 > > Thanks. > 56629fcba94c698d8c5be3413981506479566869 > ("arm64: dts: renesas: ebisu: Enable Audio") > is using "simple-scu-audio-card", but it should be "simple-audio-card". > Can you add and test this patch ? > CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think. Thanks Morimoto-san, I confirm that Sound on Ebisu-4D appears to work with a) CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied. > > -------------- > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > index 62bdddc..649d3fd 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > @@ -159,16 +159,13 @@ > }; > > rsnd_ak4613: sound { > - compatible = "simple-scu-audio-card"; > + compatible = "simple-audio-card"; > > simple-audio-card,name = "rsnd-ak4613"; > simple-audio-card,format = "left_j"; > simple-audio-card,bitclock-master = <&sndcpu>; > simple-audio-card,frame-master = <&sndcpu>; > > - simple-audio-card,prefix = "ak4613"; > - simple-audio-card,routing = "ak4613 Playback", "DAI0 Playback", > - "DAI0 Capture", "ak4613 Capture"; > sndcpu: simple-audio-card,cpu { > sound-dai = <&rcar_sound>; > }; > -------------- > > > Best regards > --- > Kuninori Morimoto > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
Hi Simon > > Thanks. > > 56629fcba94c698d8c5be3413981506479566869 > > ("arm64: dts: renesas: ebisu: Enable Audio") > > is using "simple-scu-audio-card", but it should be "simple-audio-card". > > Can you add and test this patch ? > > CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think. > > > Thanks Morimoto-san, > > I confirm that Sound on Ebisu-4D appears to work with a) > CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied. Thank you for your test. OK, I will post patch for Ebisu. Best regards --- Kuninori Morimoto
On Tue, Dec 18, 2018 at 08:01:13AM +0900, Kuninori Morimoto wrote: > > Hi Simon > > > > Thanks. > > > 56629fcba94c698d8c5be3413981506479566869 > > > ("arm64: dts: renesas: ebisu: Enable Audio") > > > is using "simple-scu-audio-card", but it should be "simple-audio-card". > > > Can you add and test this patch ? > > > CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think. > > > > > > Thanks Morimoto-san, > > > > I confirm that Sound on Ebisu-4D appears to work with a) > > CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied. > > Thank you for your test. > OK, I will post patch for Ebisu. Thanks!
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f88190463481..b521159f5f33 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -491,6 +491,7 @@ CONFIG_SND_SOC_RT5514=m CONFIG_SND_SOC_RT5514_SPI=m CONFIG_SND_SOC_RT5645=m CONFIG_SND_SIMPLE_CARD=m +CONFIG_SND_SIMPLE_SCU_CARD=m CONFIG_SND_AUDIO_GRAPH_CARD=m CONFIG_I2C_HID=m CONFIG_USB=y
Enable the scu-simple-card which is used by the R-Car E3 (r8a77990) based Ebisu board. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)