| Message ID | 20181219155704.15264-3-pawel.mikolaj.chmiel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/exynos: rotator: Add support for s5pv210 | expand |
On Wed, 19 Dec 2018 at 17:04, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote: > > This commit documents new compatible for s5pv210 soc, > which will be also supported by this driver. > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > Documentation/devicetree/bindings/gpu/samsung-rotator.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > index 82cd1ed0be93..78658dec6941 100644 > --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > @@ -5,6 +5,7 @@ Required properties: > (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210 > (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412 > (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250 > + (d) "samsung,s5pv210-rotator" for Rotator IP in S5PV210 How about putting it at beginning as the oldest chipset? This would require reordering the list so maybe let's remove the a/b/c list enumerations? They are kind of useless. Best regards, Krzysztof
Dnia środa, 19 grudnia 2018 17:22:51 CET Krzysztof Kozlowski pisze: > On Wed, 19 Dec 2018 at 17:04, Paweł Chmiel > <pawel.mikolaj.chmiel@gmail.com> wrote: > > > > This commit documents new compatible for s5pv210 soc, > > which will be also supported by this driver. > > > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > --- > > Documentation/devicetree/bindings/gpu/samsung-rotator.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > index 82cd1ed0be93..78658dec6941 100644 > > --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > @@ -5,6 +5,7 @@ Required properties: > > (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210 > > (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412 > > (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250 > > + (d) "samsung,s5pv210-rotator" for Rotator IP in S5PV210 > > How about putting it at beginning as the oldest chipset? This would > require reordering the list so maybe let's remove the a/b/c list > enumerations? They are kind of useless. Ok, i'll send v2 of patchset with this change. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt index 82cd1ed0be93..78658dec6941 100644 --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt @@ -5,6 +5,7 @@ Required properties: (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210 (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412 (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250 + (d) "samsung,s5pv210-rotator" for Rotator IP in S5PV210 - reg : Physical base address of the IP registers and length of memory mapped region.
This commit documents new compatible for s5pv210 soc, which will be also supported by this driver. Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> --- Documentation/devicetree/bindings/gpu/samsung-rotator.txt | 1 + 1 file changed, 1 insertion(+)