| Message ID | 20181217212046.71017-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for immediate data to the SRP drivers | expand |
On 2018/12/18 5:20, Bart Van Assche wrote: > Hi Jason and Doug, > > Recently the ANSI T10 committee published the SRP2r04 draft. That document > specifies how to support immediate data with the SRP protocol. As you know > using immediate data reduces latency for small write requests. This patch > series adds immediate data support to the SRP initiator and target drivers. > > Please consider this patch series for kernel v4.21. > > Thanks, > > Bart. > > Changes compared to v1: > - Added a fix for a race in ib_srpt channel shutdown. > - Added a patch for ib_srpt that joins split strings. > > Bart Van Assche (15): > include/scsi/srp.h: Move response flag definitions into this file > include/scsi/srp.h: Add support for immediate data > RDMA/srp: Document srp_parse_in() arguments > RDMA/srp: Handle large SCSI CDBs correctly > RDMA/srp: Propagate ib_post_send() failures to the SCSI mid-layer > RDMA/srp: Move srp_rdma_ch.max_ti_iu_len declaration > RDMA/srp: Rework handling of the maximum information unit length > RDMA/srp: Add support for immediate data > RDMA/srpt: Fix a use-after-free in the channel release code > RDMA/srpt: Improve coding style conformance > RDMA/srpt: Join split strings > RDMA/srpt: Make kernel-doc headers complete Some similar patches can be merged as one. Zhu Yanjun > RDMA/srpt: Remove driver version and release date > RDMA/srpt: Rework the srpt_alloc_srq() error path > RDMA/srpt: Add support for immediate data > > drivers/infiniband/ulp/srp/ib_srp.c | 153 +++++++++++--- > drivers/infiniband/ulp/srp/ib_srp.h | 20 +- > drivers/infiniband/ulp/srpt/ib_srpt.c | 275 ++++++++++++++++++-------- > drivers/infiniband/ulp/srpt/ib_srpt.h | 44 ++++- > include/scsi/srp.h | 26 ++- > 5 files changed, 396 insertions(+), 122 deletions(-) >
On Tue, 2018-12-18 at 22:09 +0800, Yanjun Zhu wrote: > On 2018/12/18 5:20, Bart Van Assche wrote: > > Hi Jason and Doug, > > > > Recently the ANSI T10 committee published the SRP2r04 draft. That document > > specifies how to support immediate data with the SRP protocol. As you know > > using immediate data reduces latency for small write requests. This patch > > series adds immediate data support to the SRP initiator and target drivers. > > > > Please consider this patch series for kernel v4.21. > > > > Thanks, > > > > Bart. > > > > Changes compared to v1: > > - Added a fix for a race in ib_srpt channel shutdown. > > - Added a patch for ib_srpt that joins split strings. > > > > Bart Van Assche (15): > > include/scsi/srp.h: Move response flag definitions into this file > > include/scsi/srp.h: Add support for immediate data > > RDMA/srp: Document srp_parse_in() arguments > > RDMA/srp: Handle large SCSI CDBs correctly > > RDMA/srp: Propagate ib_post_send() failures to the SCSI mid-layer > > RDMA/srp: Move srp_rdma_ch.max_ti_iu_len declaration > > RDMA/srp: Rework handling of the maximum information unit length > > RDMA/srp: Add support for immediate data > > RDMA/srpt: Fix a use-after-free in the channel release code > > RDMA/srpt: Improve coding style conformance > > RDMA/srpt: Join split strings > > RDMA/srpt: Make kernel-doc headers complete > > Some similar patches can be merged as one. Some could, but it's not required. The series actually looks pretty good to me.
On Wed, 2018-12-19 at 15:05 -0500, Doug Ledford wrote: > On Tue, 2018-12-18 at 22:09 +0800, Yanjun Zhu wrote: > > On 2018/12/18 5:20, Bart Van Assche wrote: > > > Hi Jason and Doug, > > > > > > Recently the ANSI T10 committee published the SRP2r04 draft. That document > > > specifies how to support immediate data with the SRP protocol. As you know > > > using immediate data reduces latency for small write requests. This patch > > > series adds immediate data support to the SRP initiator and target drivers. > > > > > > Please consider this patch series for kernel v4.21. > > > > > > Thanks, > > > > > > Bart. > > > > > > Changes compared to v1: > > > - Added a fix for a race in ib_srpt channel shutdown. > > > - Added a patch for ib_srpt that joins split strings. > > > > > > Bart Van Assche (15): > > > include/scsi/srp.h: Move response flag definitions into this file > > > include/scsi/srp.h: Add support for immediate data > > > RDMA/srp: Document srp_parse_in() arguments > > > RDMA/srp: Handle large SCSI CDBs correctly > > > RDMA/srp: Propagate ib_post_send() failures to the SCSI mid-layer > > > RDMA/srp: Move srp_rdma_ch.max_ti_iu_len declaration > > > RDMA/srp: Rework handling of the maximum information unit length > > > RDMA/srp: Add support for immediate data > > > RDMA/srpt: Fix a use-after-free in the channel release code > > > RDMA/srpt: Improve coding style conformance > > > RDMA/srpt: Join split strings > > > RDMA/srpt: Make kernel-doc headers complete > > > > Some similar patches can be merged as one. > > Some could, but it's not required. The series actually looks pretty > good to me. > Build test passed, series applied, thanks.