| Message ID | 20181222001452.7474-9-okaya@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Specify CONFIG_PCI dependency explicitly | expand |
On 12/21/18 4:14 PM, Sinan Kaya wrote: > IOSF_MBI driver depends on CONFIG_PCI set but this is not specified > anywhere. wrong patch description...? > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- > sound/soc/intel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index 2fd1b61e8331..b0764b2fe001 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI > config SND_SST_ATOM_HIFI2_PLATFORM_ACPI > tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" > default ACPI > - depends on X86 && ACPI > + depends on X86 && ACPI && PCI > select SND_SST_IPC_ACPI > select SND_SST_ATOM_HIFI2_PLATFORM > select SND_SOC_ACPI_INTEL_MATCH >
On Sat, Dec 22, 2018 at 4:19 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > On 12/21/18 4:14 PM, Sinan Kaya wrote: > > IOSF_MBI driver depends on CONFIG_PCI set but this is not specified > > anywhere. > > wrong patch description...? Not really... Code does unconditional select for IOSF_MBI. > > > Signed-off-by: Sinan Kaya <okaya@kernel.org> > > --- > > sound/soc/intel/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > > index 2fd1b61e8331..b0764b2fe001 100644 > > --- a/sound/soc/intel/Kconfig > > +++ b/sound/soc/intel/Kconfig > > @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI > > config SND_SST_ATOM_HIFI2_PLATFORM_ACPI > > tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" > > default ACPI > > - depends on X86 && ACPI > > + depends on X86 && ACPI && PCI > > select SND_SST_IPC_ACPI > > select SND_SST_ATOM_HIFI2_PLATFORM > > select SND_SOC_ACPI_INTEL_MATCH > > > > > -- > ~Randy
On 12/22/2018 7:26 AM, Sinan Kaya wrote: > On Sat, Dec 22, 2018 at 4:19 AM Randy Dunlap<rdunlap@infradead.org> wrote: >> On 12/21/18 4:14 PM, Sinan Kaya wrote: >>> IOSF_MBI driver depends on CONFIG_PCI set but this is not specified >>> anywhere. >> wrong patch description...? > Not really... > Code does unconditional select for IOSF_MBI. > I'll put the above comment into the commit message to make this change cleaner.
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig index 2fd1b61e8331..b0764b2fe001 100644 --- a/sound/soc/intel/Kconfig +++ b/sound/soc/intel/Kconfig @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH
IOSF_MBI driver depends on CONFIG_PCI set but this is not specified anywhere. Signed-off-by: Sinan Kaya <okaya@kernel.org> --- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)