| Message ID | 20181227195221.GA11920@amd (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | fd10606f93a149a9f3d37574e5385b083b4a7b32 |
| Headers | show |
| Series | cpcap-charger: generate events for userspace | expand |
* Pavel Machek <pavel@ucw.cz> [181227 11:52]: > > The driver doesn't generate uevents on charger connect/disconnect. > This leads to UPower not detecting when AC is on or off... and that is > bad. Acked-by: Tony Lindgren <tony@atomide.com>
Hi, On Thu, Dec 27, 2018 at 08:52:21PM +0100, Pavel Machek wrote: > The driver doesn't generate uevents on charger connect/disconnect. > This leads to UPower not detecting when AC is on or off... and that is > bad. > > Reported by Arthur D. on github ( > https://github.com/maemo-leste/bugtracker/issues/206 ), thanks to > Merlijn Wajer for suggesting a fix. > > Cc: stable@kernel.org > Signed-off-by: Pavel Machek <pavel@ucw.cz> Thanks, queued to power-supply-next. -- Sebastian > diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c > index 9e8ff5c..7d8b4d5 100644 > --- a/drivers/power/supply/cpcap-charger.c > +++ b/drivers/power/supply/cpcap-charger.c > @@ -576,6 +576,7 @@ static void cpcap_usb_detect(struct work_struct *work) > goto out_err; > } > > + power_supply_changed(ddata->usb); > return; > > out_err: > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c index 9e8ff5c..7d8b4d5 100644 --- a/drivers/power/supply/cpcap-charger.c +++ b/drivers/power/supply/cpcap-charger.c @@ -576,6 +576,7 @@ static void cpcap_usb_detect(struct work_struct *work) goto out_err; } + power_supply_changed(ddata->usb); return; out_err:
The driver doesn't generate uevents on charger connect/disconnect. This leads to UPower not detecting when AC is on or off... and that is bad. Reported by Arthur D. on github ( https://github.com/maemo-leste/bugtracker/issues/206 ), thanks to Merlijn Wajer for suggesting a fix. Cc: stable@kernel.org Signed-off-by: Pavel Machek <pavel@ucw.cz>