Message ID | 20181228154609.14846-6-pawel.mikolaj.chmiel@gmail.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | Input: tm2-touchkey: Add support for Aries and Midas | expand |
On Fri, 28 Dec 2018 16:46:07 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote: > From: Jonathan Bakker <xc-racer2@live.ca> > > Document new optional property for setting custom keycodes. > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > Changes from v1: > - Because key codes could be bigger than 255, use ints for keycodes > --- > .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Fri, Dec 28, 2018 at 2:47 PM Rob Herring <robh@kernel.org> wrote: > > On Fri, 28 Dec 2018 16:46:07 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote: > > From: Jonathan Bakker <xc-racer2@live.ca> > > > > Document new optional property for setting custom keycodes. > > > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > --- > > Changes from v1: > > - Because key codes could be bigger than 255, use ints for keycodes > > --- > > .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Shouldn't this be "linux,keycodes" though? Thanks.
On Fri, Dec 28, 2018 at 4:52 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > On Fri, Dec 28, 2018 at 2:47 PM Rob Herring <robh@kernel.org> wrote: > > > > On Fri, 28 Dec 2018 16:46:07 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote: > > > From: Jonathan Bakker <xc-racer2@live.ca> > > > > > > Document new optional property for setting custom keycodes. > > > > > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > > --- > > > Changes from v1: > > > - Because key codes could be bigger than 255, use ints for keycodes > > > --- > > > .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Shouldn't this be "linux,keycodes" though? Sigh, yes. Rob
Dnia czwartek, 3 stycznia 2019 19:27:39 CET Rob Herring pisze: > On Fri, Dec 28, 2018 at 4:52 PM Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > > > On Fri, Dec 28, 2018 at 2:47 PM Rob Herring <robh@kernel.org> wrote: > > > > > > On Fri, 28 Dec 2018 16:46:07 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote: > > > > From: Jonathan Bakker <xc-racer2@live.ca> > > > > > > > > Document new optional property for setting custom keycodes. > > > > > > > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > > > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > > > --- > > > > Changes from v1: > > > > - Because key codes could be bigger than 255, use ints for keycodes > > > > --- > > > > .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Shouldn't this be "linux,keycodes" though? > > Sigh, yes. > > Rob I'll send v3 version with this property name fixed (both in documentation and in driver). Thanks
diff --git a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt index dfb3b9f0ee40..15d4bf4f307e 100644 --- a/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt +++ b/Documentation/devicetree/bindings/input/cypress,tm2-touchkey.txt @@ -10,6 +10,9 @@ Required properties: - vcc-supply : internal regulator output. 1.8V - vdd-supply : power supply for IC 3.3V +Optional properties: +- keycodes: array of keycodes (max 4), default KEY_PHONE and KEY_BACK + [0]: Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Example: @@ -23,5 +26,6 @@ Example: interrupts = <2 IRQ_TYPE_EDGE_FALLING>; vcc-supply=<&ldo32_reg>; vdd-supply=<&ldo33_reg>; + keycodes = <KEY_PHONE KEY_BACK>; }; };