| Message ID | 20190102181038.4418-7-okaya@kernel.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Specify CONFIG_PCI dependency explicitly | expand |
On Wed, Jan 02, 2019 at 06:10:33PM +0000, Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver depends on the PCI infrastructure but > the dependency has not been explicitly called out. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> Reviewed-by: Lukas Wunner <lukas@wunner.de> > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 7afb96cb1cd6..89f4b86244a7 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10 > config APPLE_GMUX > tristate "Apple Gmux Driver" > depends on ACPI > + depends on PCI > depends on PNP > depends on BACKLIGHT_CLASS_DEVICE > depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE > -- > 2.19.0
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <okaya@kernel.org> wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. This driver depends on the PCI infrastructure but > the dependency has not been explicitly called out. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 7afb96cb1cd6..89f4b86244a7 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10 > config APPLE_GMUX > tristate "Apple Gmux Driver" > depends on ACPI > + depends on PCI Can you stick with the same pattern you have used for the rest in this series? I.e. depends on ACPI && PCI > depends on PNP > depends on BACKLIGHT_CLASS_DEVICE > depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE > -- > 2.19.0 >
On Fri, Jan 4, 2019 at 4:12 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <okaya@kernel.org> wrote: > > > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > > satisfied implicitly through dependencies on CONFIG_ACPI have to be > > specified directly. This driver depends on the PCI infrastructure but > > the dependency has not been explicitly called out. > > > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > > Signed-off-by: Sinan Kaya <okaya@kernel.org> > > --- > > drivers/platform/x86/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > > index 7afb96cb1cd6..89f4b86244a7 100644 > > --- a/drivers/platform/x86/Kconfig > > +++ b/drivers/platform/x86/Kconfig > > @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10 > > config APPLE_GMUX > > tristate "Apple Gmux Driver" > > > depends on ACPI > > + depends on PCI > > Can you stick with the same pattern you have used for the rest in this series? > I.e. > depends on ACPI && PCI After satisfying it Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > > > depends on PNP > > depends on BACKLIGHT_CLASS_DEVICE > > depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE > > -- > > 2.19.0 > > > > > -- > With Best Regards, > Andy Shevchenko
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 7afb96cb1cd6..89f4b86244a7 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10 config APPLE_GMUX tristate "Apple Gmux Driver" depends on ACPI + depends on PCI depends on PNP depends on BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This driver depends on the PCI infrastructure but the dependency has not been explicitly called out. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya@kernel.org> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)