diff mbox series

Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB

Message ID 1546454264-11561-1-git-send-email-jackstocker.93@gmail.com (mailing list archive)
State Superseded
Headers show
Series Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB | expand

Commit Message

Jack Stocker Jan. 2, 2019, 6:37 p.m. UTC
To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
discussed here: https://github.com/ckb-next/ckb-next/issues/42.
Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.

Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
---
 drivers/usb/core/quirks.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Danilo Krummrich Jan. 2, 2019, 8:57 p.m. UTC | #1
You're referring to this patch
cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20")
I guess. Maybe you want to name it explicitly for better reference.

Acked-by: Danilo Krummrich <danilokrummrich@dk-develop.de>


On 2019-01-02 19:37, Jack Stocker wrote:
> To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
> USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
> discussed here: https://github.com/ckb-next/ckb-next/issues/42.
> Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
> 
> Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
> ---
>  drivers/usb/core/quirks.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7909262..4a9267d 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -377,7 +377,8 @@ static const struct usb_device_id usb_quirk_list[] 
> = {
>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
> 
>  	/* Corsair K70 RGB */
> -	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
> +	  USB_QUIRK_DELAY_CTRL_MSG },
> 
>  	/* Corsair Strafe RGB */
>  	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
diff mbox series

Patch

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7909262..4a9267d 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -377,7 +377,8 @@  static const struct usb_device_id usb_quirk_list[] = {
 			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
 
 	/* Corsair K70 RGB */
-	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
+	  USB_QUIRK_DELAY_CTRL_MSG },
 
 	/* Corsair Strafe RGB */
 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |