| Message ID | 20190103101245.15100-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Show machine type in error state | expand |
On 03/01/2019 10:12, Chris Wilson wrote: > As the question of 32b/64b kernels became relevant in the light of > certain bugs, include that information in the error state. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> I was thinking about it, thanks for doing this. Not sure about the content of the machine field though. Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 6238a06b6d4e..5533a741abeb 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -665,7 +665,9 @@ static void __err_print_to_sgl(struct drm_i915_error_state_buf *m, > > if (*error->error_msg) > err_printf(m, "%s\n", error->error_msg); > - err_printf(m, "Kernel: %s\n", init_utsname()->release); > + err_printf(m, "Kernel: %s %s\n", > + init_utsname()->release, > + init_utsname()->machine); > ts = ktime_to_timespec64(error->time); > err_printf(m, "Time: %lld s %ld us\n", > (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC);
Quoting Lionel Landwerlin (2019-01-03 10:42:22) > On 03/01/2019 10:12, Chris Wilson wrote: > > As the question of 32b/64b kernels became relevant in the light of > > certain bugs, include that information in the error state. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > > > I was thinking about it, thanks for doing this. > > Not sure about the content of the machine field though. uname -m i386 or x86_64 iirc. -Chris
On 03/01/2019 10:46, Chris Wilson wrote: > Quoting Lionel Landwerlin (2019-01-03 10:42:22) >> On 03/01/2019 10:12, Chris Wilson wrote: >>> As the question of 32b/64b kernels became relevant in the light of >>> certain bugs, include that information in the error state. >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> >>> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> >> >> I was thinking about it, thanks for doing this. >> >> Not sure about the content of the machine field though. > uname -m > i386 or x86_64 iirc. > -Chris > Awesome! You can make that : Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Thanks again!
Chris Wilson <chris@chris-wilson.co.uk> writes: > Quoting Lionel Landwerlin (2019-01-03 10:42:22) >> On 03/01/2019 10:12, Chris Wilson wrote: >> > As the question of 32b/64b kernels became relevant in the light of >> > certain bugs, include that information in the error state. >> > >> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> >> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> >> >> >> I was thinking about it, thanks for doing this. >> >> Not sure about the content of the machine field though. > > uname -m > i386 or x86_64 iirc. Yes, it shows 'x86_64'. But I am too late in here =) -Mika
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 6238a06b6d4e..5533a741abeb 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -665,7 +665,9 @@ static void __err_print_to_sgl(struct drm_i915_error_state_buf *m, if (*error->error_msg) err_printf(m, "%s\n", error->error_msg); - err_printf(m, "Kernel: %s\n", init_utsname()->release); + err_printf(m, "Kernel: %s %s\n", + init_utsname()->release, + init_utsname()->machine); ts = ktime_to_timespec64(error->time); err_printf(m, "Time: %lld s %ld us\n", (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC);
As the question of 32b/64b kernels became relevant in the light of certain bugs, include that information in the error state. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> --- drivers/gpu/drm/i915/i915_gpu_error.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)