diff mbox series

[1/6] ARM: dts: s5pv210: Use correct fimd variant

Message ID 20181228161819.18931-2-pawel.mikolaj.chmiel@gmail.com (mailing list archive)
State Accepted
Headers show
Series ARM: dts: s5pv210: aries: Enable more drivers present on Samsung Aries based devices | expand

Commit Message

Paweł Chmiel Dec. 28, 2018, 4:18 p.m. UTC
Since we have separate compatible for our SOC,
let's use it rather using one from exynos4210.

Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
---
 arch/arm/boot/dts/s5pv210.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Dec. 31, 2018, 11:37 a.m. UTC | #1
On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<pawel.mikolaj.chmiel@gmail.com> wrote:
>
> Since we have separate compatible for our SOC,
> let's use it rather using one from exynos4210.

Please fix
your editor
to wrap lines
matching Linux
style because
it is difficult
to read.

You have unusual configuration because most of the editors wrap git
commit as expected.
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633

Best regards,
Krzysztof

>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
>  arch/arm/boot/dts/s5pv210.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 75f454a210d6..3d6e5ad1ea35 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -511,7 +511,7 @@
>                 };
>
>                 fimd: fimd@f8000000 {
> -                       compatible = "samsung,exynos4210-fimd";
> +                       compatible = "samsung,s5pv210-fimd";
>                         interrupt-parent = <&vic2>;
>                         reg = <0xf8000000 0x20000>;
>                         interrupt-names = "fifo", "vsync", "lcd_sys";
> --
> 2.17.1
>
Krzysztof Kozlowski Jan. 7, 2019, 8:28 p.m. UTC | #2
On Fri, Dec 28, 2018 at 05:18:14PM +0100, Paweł Chmiel wrote:
> Since we have separate compatible for our SOC,
> let's use it rather using one from exynos4210.
> 
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
>  arch/arm/boot/dts/s5pv210.dtsi | 2 +-

Thanks, applied.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index 75f454a210d6..3d6e5ad1ea35 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -511,7 +511,7 @@ 
 		};
 
 		fimd: fimd@f8000000 {
-			compatible = "samsung,exynos4210-fimd";
+			compatible = "samsung,s5pv210-fimd";
 			interrupt-parent = <&vic2>;
 			reg = <0xf8000000 0x20000>;
 			interrupt-names = "fifo", "vsync", "lcd_sys";