| Message ID | 20190105155953.19583-1-nicolas.iooss@m4x.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/1] scripts/run-flake8: run on Python scripts not ending with .py | expand |
Nicolas Iooss <nicolas.iooss@m4x.org> writes: > When running flake8 on a directory, it does not analyze files without an > extension, like semanage_migrate_store, mlscolor-test, etc. Use grep to > find files with a Python shebang and build a list which is then given to > flake8. > > This commit is possible now that some clean-up patches have been > applied, such as commit 69c56bd2f6e9 ("python/chcat: improve the code > readability") and b7227aaec1da ("mcstrans: fix Python linter warnings on > test scripts") and 3cb974d2d2a7 ("semanage_migrate_store: fix many > Python linter warnings"). > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> Acked-by: Petr Lautrbach <plautrba@redhat.com> https://github.com/SELinuxProject/selinux/pull/128 > --- > scripts/run-flake8 | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/run-flake8 b/scripts/run-flake8 > index 6ad029fa6852..24b1202fde99 100755 > --- a/scripts/run-flake8 > +++ b/scripts/run-flake8 > @@ -4,6 +4,11 @@ > # Run on the base directory if no argument has been given > if [ $# -eq 0 ] ; then > cd "$(dirname -- "$0")/.." || exit $? > + > + # Run on both files ending with .py and Python files without extension > + # shellcheck disable=SC2046 > + set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u ) > + echo "Analyzing $# Python scripts" > fi > > # Assign each ignore warning on a line, in order to ease testing enabling the warning again
Petr Lautrbach <plautrba@redhat.com> writes: > Nicolas Iooss <nicolas.iooss@m4x.org> writes: > >> When running flake8 on a directory, it does not analyze files without an >> extension, like semanage_migrate_store, mlscolor-test, etc. Use grep to >> find files with a Python shebang and build a list which is then given to >> flake8. >> >> This commit is possible now that some clean-up patches have been >> applied, such as commit 69c56bd2f6e9 ("python/chcat: improve the code >> readability") and b7227aaec1da ("mcstrans: fix Python linter warnings on >> test scripts") and 3cb974d2d2a7 ("semanage_migrate_store: fix many >> Python linter warnings"). >> >> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > Acked-by: Petr Lautrbach <plautrba@redhat.com> > > https://github.com/SELinuxProject/selinux/pull/128 And it's merged now. > >> --- >> scripts/run-flake8 | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/scripts/run-flake8 b/scripts/run-flake8 >> index 6ad029fa6852..24b1202fde99 100755 >> --- a/scripts/run-flake8 >> +++ b/scripts/run-flake8 >> @@ -4,6 +4,11 @@ >> # Run on the base directory if no argument has been given >> if [ $# -eq 0 ] ; then >> cd "$(dirname -- "$0")/.." || exit $? >> + >> + # Run on both files ending with .py and Python files without extension >> + # shellcheck disable=SC2046 >> + set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u ) >> + echo "Analyzing $# Python scripts" >> fi >> >> # Assign each ignore warning on a line, in order to ease testing enabling the warning again
diff --git a/scripts/run-flake8 b/scripts/run-flake8 index 6ad029fa6852..24b1202fde99 100755 --- a/scripts/run-flake8 +++ b/scripts/run-flake8 @@ -4,6 +4,11 @@ # Run on the base directory if no argument has been given if [ $# -eq 0 ] ; then cd "$(dirname -- "$0")/.." || exit $? + + # Run on both files ending with .py and Python files without extension + # shellcheck disable=SC2046 + set -- $( (find . -name '*.py' ; grep --exclude-dir=.git -l -e '^#!\s*/usr/bin/python' -e '^#!/usr/bin/env python' -r .) | sort -u ) + echo "Analyzing $# Python scripts" fi # Assign each ignore warning on a line, in order to ease testing enabling the warning again
When running flake8 on a directory, it does not analyze files without an extension, like semanage_migrate_store, mlscolor-test, etc. Use grep to find files with a Python shebang and build a list which is then given to flake8. This commit is possible now that some clean-up patches have been applied, such as commit 69c56bd2f6e9 ("python/chcat: improve the code readability") and b7227aaec1da ("mcstrans: fix Python linter warnings on test scripts") and 3cb974d2d2a7 ("semanage_migrate_store: fix many Python linter warnings"). Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> --- scripts/run-flake8 | 5 +++++ 1 file changed, 5 insertions(+)