| Message ID | 20190109174956.43052-1-noralf@tronnes.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/tinydrm: Use damage helper for dirtyfb | expand |
Hi Noralf. > > I was really pleased to see that the damage helper had landed. Now I can > do framebuffer flushing solely through the display pipe functions. This > prepares the ground for the removal of struct tinydrm_device in my next > series. I browsed through the code - and the code paths I could follow looked good to me. I missed an update of Documentation/gpu/todo.rst as I think we can close a few items with this patch-set. You can add my: Acked-by: Sam Ravnborg <sam@ravnborg.org> to the full series. Sam
Den 09.01.2019 19.26, skrev Sam Ravnborg: > Hi Noralf. > >> >> I was really pleased to see that the damage helper had landed. Now I can >> do framebuffer flushing solely through the display pipe functions. This >> prepares the ground for the removal of struct tinydrm_device in my next >> series. > > I browsed through the code - and the code paths I could follow looked > good to me. > I missed an update of Documentation/gpu/todo.rst as I think we can > close a few items with this patch-set. > Yeah, you're right, I forgot about that one. I'll add a patch in the next version. > You can add my: > Acked-by: Sam Ravnborg <sam@ravnborg.org> > to the full series. > Thanks, Noralf.
On Wed, Jan 9, 2019 at 6:50 PM Noralf Trønnes <noralf@tronnes.org> wrote: > > Hi, > > I was really pleased to see that the damage helper had landed. Now I can > do framebuffer flushing solely through the display pipe functions. This > prepares the ground for the removal of struct tinydrm_device in my next > series. Awesome stuff! > Note: > The damage helper isn't in drm-misc-next yet, it will show up when -rc1 > arrives there. Maxime, can you pls do the backmerge for Noralf, with the above reason? $ dim backmerge drm-misc-next drm/drm-next should get the job done. Cheers, Daniel > > Noralf. > > Noralf Trønnes (4): > drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() > drm/damage-helper: Add drm_atomic_helper_damage_merged() > drm/tinydrm: Use struct drm_rect > drm/tinydrm: Use damage helper for dirtyfb > > drivers/gpu/drm/drm_damage_helper.c | 43 ++++++ > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 47 +++++- > drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 21 +-- > .../gpu/drm/tinydrm/core/tinydrm-helpers.c | 100 +------------ > drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 30 ---- > drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- > drivers/gpu/drm/tinydrm/ili9225.c | 138 +++++++----------- > drivers/gpu/drm/tinydrm/ili9341.c | 2 +- > drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +- > drivers/gpu/drm/tinydrm/mipi-dbi.c | 87 +++++++---- > drivers/gpu/drm/tinydrm/repaper.c | 42 +++--- > drivers/gpu/drm/tinydrm/st7586.c | 73 ++++----- > drivers/gpu/drm/tinydrm/st7735r.c | 2 +- > include/drm/drm_damage_helper.h | 3 + > include/drm/drm_gem_framebuffer_helper.h | 3 + > include/drm/tinydrm/mipi-dbi.h | 5 +- > include/drm/tinydrm/tinydrm-helpers.h | 20 +-- > include/drm/tinydrm/tinydrm.h | 26 ---- > 18 files changed, 281 insertions(+), 365 deletions(-) > > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, 2019-01-09 at 18:49 +0100, Noralf Trønnes wrote: > Hi, > > I was really pleased to see that the damage helper had landed. Now I > can > do framebuffer flushing solely through the display pipe functions. > This > prepares the ground for the removal of struct tinydrm_device in my > next > series. Hi Noralf, Not an expert of tinydrm but I followed the code and everything looked alright to me especially the usage of damage iterator. Yes the code to clear damage on plane state destroy was missing earlier and can be removed from the new helper you have. It is better to have damage in plane state as something else might need it. Thanks, Deepak > > Note: > The damage helper isn't in drm-misc-next yet, it will show up when > -rc1 > arrives there. > > Noralf. > > Noralf Trønnes (4): > drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() > drm/damage-helper: Add drm_atomic_helper_damage_merged() > drm/tinydrm: Use struct drm_rect > drm/tinydrm: Use damage helper for dirtyfb > > drivers/gpu/drm/drm_damage_helper.c | 43 ++++++ > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 47 +++++- > drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 21 +-- > .../gpu/drm/tinydrm/core/tinydrm-helpers.c | 100 +------------ > drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 30 ---- > drivers/gpu/drm/tinydrm/hx8357d.c | 2 +- > drivers/gpu/drm/tinydrm/ili9225.c | 138 +++++++--------- > -- > drivers/gpu/drm/tinydrm/ili9341.c | 2 +- > drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +- > drivers/gpu/drm/tinydrm/mipi-dbi.c | 87 +++++++---- > drivers/gpu/drm/tinydrm/repaper.c | 42 +++--- > drivers/gpu/drm/tinydrm/st7586.c | 73 ++++----- > drivers/gpu/drm/tinydrm/st7735r.c | 2 +- > include/drm/drm_damage_helper.h | 3 + > include/drm/drm_gem_framebuffer_helper.h | 3 + > include/drm/tinydrm/mipi-dbi.h | 5 +- > include/drm/tinydrm/tinydrm-helpers.h | 20 +-- > include/drm/tinydrm/tinydrm.h | 26 ---- > 18 files changed, 281 insertions(+), 365 deletions(-) >