[v3,0/6] media: adv748x: Implement dynamic routing support

Message

Jacopo Mondi Jan. 10, 2019, 2:02 p.m. UTC

Hello,
   third iteration for adv748x dynamic selection of video source.

Please refer to v1 and v2 cover letter for more details:
https://patchwork.kernel.org/cover/10723971/
https://patchwork.kernel.org/cover/10749535/

This version includes comments from Laurent and Kieran, on patches 1/6 and
mostly on 6/6, which resulted in a better implementation. Thanks.

I have tested this on Ebisu E3 where I can capture HDMI and CVBS inputs from
TXA, and on Salvator-x M3-W where I can capture HDMI from TXA, and CVBS from
both TXA and TXB, but only when setting the number of CSI-2 data lanes to 2 in
DTS.

It remains unresolved how to dynamically negotiate the number of CSI-2 data
lanes to use between the video source and the CSI-2 receiver, which prevents
using AFE->TXA routing on all Gen3 SoC which use 4 CSI-2 data lanes.

The series is based on media tree master with the following series from
Niklas applied on top:
[PATCH v4 0/4] i2c: adv748x: add support for CSI-2 TXA to work in 1-, 2- and 4-lane mode

Branch available for testing at:
git://jmondi.org/linux adv748x_dynamic-routing_v3

Thanks
  j

Jacopo Mondi (6):
  media: adv748x: Add is_txb()
  media: adv748x: Rename reset procedures
  media: adv748x: csi2: Link AFE with TXA and TXB
  media: adv748x: Store the source subdevice in TX
  media: adv748x: Store the TX sink in HDMI/AFE
  media: adv748x: Implement TX link_setup callback

 drivers/media/i2c/adv748x/adv748x-afe.c  |  2 +-
 drivers/media/i2c/adv748x/adv748x-core.c | 74 +++++++++++++++++++-----
 drivers/media/i2c/adv748x/adv748x-csi2.c | 64 +++++++++++++-------
 drivers/media/i2c/adv748x/adv748x-hdmi.c |  2 +-
 drivers/media/i2c/adv748x/adv748x.h      | 10 ++++
 5 files changed, 112 insertions(+), 40 deletions(-)

--
2.20.1

Comments

Kieran Bingham Jan. 14, 2019, 2:22 p.m. UTC | #1

Hi Jacopo,

for this series:

Tested-by: Kieran Bingham <[e-mail]>

For anyone else who wants to use this series, please remember that if
you reset links on the media controller you will now have to set up the
links between the HDMI/AFE and TXA/TXB with this series in place.

The driver will default to the current configuration at startup.

--
Kieran


On 10/01/2019 14:02, Jacopo Mondi wrote:
> Hello,
>    third iteration for adv748x dynamic selection of video source.
> 
> Please refer to v1 and v2 cover letter for more details:
> https://patchwork.kernel.org/cover/10723971/
> https://patchwork.kernel.org/cover/10749535/
> 
> This version includes comments from Laurent and Kieran, on patches 1/6 and
> mostly on 6/6, which resulted in a better implementation. Thanks.
> 
> I have tested this on Ebisu E3 where I can capture HDMI and CVBS inputs from
> TXA, and on Salvator-x M3-W where I can capture HDMI from TXA, and CVBS from
> both TXA and TXB, but only when setting the number of CSI-2 data lanes to 2 in
> DTS.
> 
> It remains unresolved how to dynamically negotiate the number of CSI-2 data
> lanes to use between the video source and the CSI-2 receiver, which prevents
> using AFE->TXA routing on all Gen3 SoC which use 4 CSI-2 data lanes.
> 
> The series is based on media tree master with the following series from
> Niklas applied on top:
> [PATCH v4 0/4] i2c: adv748x: add support for CSI-2 TXA to work in 1-, 2- and 4-lane mode
> 
> Branch available for testing at:
> git://jmondi.org/linux adv748x_dynamic-routing_v3
> 
> Thanks
>   j
> 
> Jacopo Mondi (6):
>   media: adv748x: Add is_txb()
>   media: adv748x: Rename reset procedures
>   media: adv748x: csi2: Link AFE with TXA and TXB
>   media: adv748x: Store the source subdevice in TX
>   media: adv748x: Store the TX sink in HDMI/AFE
>   media: adv748x: Implement TX link_setup callback
> 
>  drivers/media/i2c/adv748x/adv748x-afe.c  |  2 +-
>  drivers/media/i2c/adv748x/adv748x-core.c | 74 +++++++++++++++++++-----
>  drivers/media/i2c/adv748x/adv748x-csi2.c | 64 +++++++++++++-------
>  drivers/media/i2c/adv748x/adv748x-hdmi.c |  2 +-
>  drivers/media/i2c/adv748x/adv748x.h      | 10 ++++
>  5 files changed, 112 insertions(+), 40 deletions(-)
> 
> --
> 2.20.1
>