| Message ID | 20190116152758.2211-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/etnaviv: don't restrict to certain architectures | expand |
On Wed, Jan 16, 2019 at 04:27:58PM +0100, Lucas Stach wrote: > The Vivante GPU cores are found in many different SoCs and the driver > does not depend on anything architecture specific, so just drop the > architecture restriction. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> For good measure I throwed this after my (limited) build setup. Passed build with no warnings on ia64, alpha and x86. So: Acked-by: Sam Ravnborg <sam@ravnborg.org>
On Wed, Jan 16, 2019 at 04:27:58PM +0100, Lucas Stach wrote: > The Vivante GPU cores are found in many different SoCs and the driver > does not depend on anything architecture specific, so just drop the > architecture restriction. With my Debian kernel team member hat on I don't like changes like this. I don't know in which machines the etnaviv IP is available. Should the Debian kernel enable it on x86? powerpc? riscv? If MXC + DOVE isn't enough, it's your opportunity to not waste time of people who don't know etnaviv by heart and only expand the dependency carefully. Having said that I see the benefit of being able to enable the driver on a wide variety of machines. It's flexible and everyone who doesn't want that driver can still just disable it. But when making this change, please consider also all the people who will see ETNAVIV (DRM support for Vivante GPU IP cores) (DRM_ETNAVIV) [N/y/m/?] (NEW) in their next run of make oldconfig and need to decide if this driver is useful for them. Also note they only see DRM driver for Vivante GPUs. when pressing '?'. Best regards Uwe
diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig index 041a77e400d4..21df44b78df3 100644 --- a/drivers/gpu/drm/etnaviv/Kconfig +++ b/drivers/gpu/drm/etnaviv/Kconfig @@ -2,7 +2,6 @@ config DRM_ETNAVIV tristate "ETNAVIV (DRM support for Vivante GPU IP cores)" depends on DRM - depends on ARCH_MXC || ARCH_DOVE || (ARM && COMPILE_TEST) depends on MMU select SHMEM select SYNC_FILE
The Vivante GPU cores are found in many different SoCs and the driver does not depend on anything architecture specific, so just drop the architecture restriction. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- drivers/gpu/drm/etnaviv/Kconfig | 1 - 1 file changed, 1 deletion(-)