diff mbox series

[v2,1/6] usb: fsl: Set USB_EN bit to select ULPI phy

Message ID 20190121102601.4735-1-yinbo.zhu@nxp.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/6] usb: fsl: Set USB_EN bit to select ULPI phy | expand

Commit Message

Yinbo Zhu Jan. 21, 2019, 10:25 a.m. UTC
From: Nikhil Badola <nikhil.badola@freescale.com>

Set USB_EN bit to select ULPI phy for USB controller version 2.5

Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
Change in v2:
		replace Yinbo.Zhu with Yinbo Zhu 

 drivers/usb/host/ehci-fsl.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Greg KH Jan. 22, 2019, 8:08 a.m. UTC | #1
On Mon, Jan 21, 2019 at 10:25:00AM +0000, Yinbo Zhu wrote:
> From: Nikhil Badola <nikhil.badola@freescale.com>
> 
> Set USB_EN bit to select ULPI phy for USB controller version 2.5
> 
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
> Change in v2:
> 		replace Yinbo.Zhu with Yinbo Zhu 
> 
>  drivers/usb/host/ehci-fsl.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

This patch doesn't apply against my usb-next branch, what did you
generate it against?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 0a9fd20..71c4661 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -118,6 +118,12 @@  static int fsl_ehci_drv_probe(struct platform_device *pdev)
 		clrsetbits_be32(hcd->regs + FSL_SOC_USB_CTRL,
 				CONTROL_REGISTER_W1C_MASK, 0x4);
 
+	/* Set USB_EN bit to select ULPI phy for USB controller version 2.5 */
+	if (pdata->controller_ver == FSL_USB_VER_2_5 &&
+		pdata->phy_mode == FSL_USB2_PHY_ULPI)
+		iowrite32be(USB_CTRL_USB_EN, hcd->regs + FSL_SOC_USB_CTRL);
+
+
 	/*
 	 * Enable UTMI phy and program PTS field in UTMI mode before asserting
 	 * controller reset for USB Controller version 2.5