| Message ID | 1548138816-1149-4-git-send-email-alokc@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add interconnect support for GENI QUPs | expand |
On Tue, Jan 22, 2019 at 12:03:33PM +0530, Alok Chauhan wrote: > Get the interconnect paths for I2C based Serial Engine device > and vote accordingly based on maximum supported I2C frequency. > > Signed-off-by: Alok Chauhan <alokc@codeaurora.org> Acked-by: Wolfram Sang <wsa@the-dreams.de>
On 2019-01-22 07:33, Alok Chauhan wrote: > Get the interconnect paths for I2C based Serial Engine device > and vote accordingly based on maximum supported I2C frequency. > > Signed-off-by: Alok Chauhan <alokc@codeaurora.org> > --- > drivers/i2c/busses/i2c-qcom-geni.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index db075bc..e8fe63a 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -14,6 +14,7 @@ > #include <linux/pm_runtime.h> > #include <linux/qcom-geni-se.h> > #include <linux/spinlock.h> > +#include <linux/interconnect.h> Please keep the includes sorted. Probably applies for the other patches in the series as well? Cheers, Peter
On 2019-01-22 14:43, Peter Rosin wrote: > On 2019-01-22 07:33, Alok Chauhan wrote: >> Get the interconnect paths for I2C based Serial Engine device >> and vote accordingly based on maximum supported I2C frequency. >> >> Signed-off-by: Alok Chauhan <alokc@codeaurora.org> >> --- >> drivers/i2c/busses/i2c-qcom-geni.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c >> b/drivers/i2c/busses/i2c-qcom-geni.c >> index db075bc..e8fe63a 100644 >> --- a/drivers/i2c/busses/i2c-qcom-geni.c >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >> @@ -14,6 +14,7 @@ >> #include <linux/pm_runtime.h> >> #include <linux/qcom-geni-se.h> >> #include <linux/spinlock.h> >> +#include <linux/interconnect.h> > > Please keep the includes sorted. Probably applies for the other patches > in the series as well? > > Cheers, > Peter Sure, will do. Thanks for your comment.
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan <alokc@codeaurora.org> wrote: > > Get the interconnect paths for I2C based Serial Engine device > and vote accordingly based on maximum supported I2C frequency. > > Signed-off-by: Alok Chauhan <alokc@codeaurora.org> > --- > drivers/i2c/busses/i2c-qcom-geni.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index db075bc..e8fe63a 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -14,6 +14,7 @@ > #include <linux/pm_runtime.h> > #include <linux/qcom-geni-se.h> > #include <linux/spinlock.h> > +#include <linux/interconnect.h> > > #define SE_I2C_TX_TRANS_LEN 0x26c > #define SE_I2C_RX_TRANS_LEN 0x270 > @@ -508,6 +509,15 @@ static int geni_i2c_probe(struct platform_device *pdev) > return ret; > } > > + /* Set the bus quota to a reasonable value */ > + gi2c->se.avg_bw = Bps_to_icc(1000); > + gi2c->se.peak_bw = Bps_to_icc(76800000); Can you compute a real bandwidth based on the i2c bus speed, rather than some max vote?
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index db075bc..e8fe63a 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -14,6 +14,7 @@ #include <linux/pm_runtime.h> #include <linux/qcom-geni-se.h> #include <linux/spinlock.h> +#include <linux/interconnect.h> #define SE_I2C_TX_TRANS_LEN 0x26c #define SE_I2C_RX_TRANS_LEN 0x270 @@ -508,6 +509,15 @@ static int geni_i2c_probe(struct platform_device *pdev) return ret; } + /* Set the bus quota to a reasonable value */ + gi2c->se.avg_bw = Bps_to_icc(1000); + gi2c->se.peak_bw = Bps_to_icc(76800000); + ret = geni_interconnect_init(&gi2c->se); + if (ret) { + dev_err(&pdev->dev, "interconnect_init failed %d\n", ret); + return ret; + } + ret = device_property_read_u32(&pdev->dev, "clock-frequency", &gi2c->clk_freq_out); if (ret) { @@ -611,6 +621,8 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) gi2c->suspended = 1; } + geni_icc_update_bw(&gi2c->se, false); + return 0; } @@ -619,6 +631,7 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) int ret; struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); + geni_icc_update_bw(&gi2c->se, true); ret = geni_se_resources_on(&gi2c->se); if (ret) return ret;
Get the interconnect paths for I2C based Serial Engine device and vote accordingly based on maximum supported I2C frequency. Signed-off-by: Alok Chauhan <alokc@codeaurora.org> --- drivers/i2c/busses/i2c-qcom-geni.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)