| Message ID | 20190123134833.119031-1-chris.brandt@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | dt-bindings: arm: renesas: Document RZ/A2M EVB | expand |
On Wed, Jan 23, 2019 at 7:48 AM Chris Brandt <chris.brandt@renesas.com> wrote: > > Add the RZ/A2M Evaluation board. > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com> > --- > Documentation/devicetree/bindings/arm/renesas.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml > index 5e9d4864a600..474eb2647829 100644 > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > @@ -29,6 +29,8 @@ properties: > - const: renesas,r7s72100 > > - description: RZ/A2 (R7S9210) > + - enum: > + - renesas,rza2mevb # RZ/A2M Eval Board (RTK7921053S00000BE) Please check your changes with 'dt_binding_check' target. This will fail. 'description' already has a value, so you can't add a list to it. And description has to be a string. > items: Move the 2 lines here. > - const: renesas,r7s9210 > > -- > 2.16.1 >
On Wednesday, January 23, 2019, Rob Herring wrote: > Please check your changes with 'dt_binding_check' target. This will > fail. 'description' already has a value, so you can't add a list to > it. And description has to be a string. > > > items: > > Move the 2 lines here. > > > - const: renesas,r7s9210 I can't find 'dt_binding_check' (I guess it's only in the DT tree). But, I can see my mistake (now that you pointed it out). Chris
Hi Chris, On Wed, Jan 23, 2019 at 3:10 PM Chris Brandt <Chris.Brandt@renesas.com> wrote: > On Wednesday, January 23, 2019, Rob Herring wrote: > > Please check your changes with 'dt_binding_check' target. This will > > fail. 'description' already has a value, so you can't add a list to > > it. And description has to be a string. > > > > > items: > > > > Move the 2 lines here. > > > > > - const: renesas,r7s9210 > > I can't find 'dt_binding_check' (I guess it's only in the DT tree). This seems to be a make target: "make dt_binding_check" (included in last renesas-drivers). This needs "dt-mk-schema", which you can find in https://github.com/robherring/yaml-bindings Cloned, patch sent for missing python3-pip dependency, installed, put in $PATH, and now it seems to like your v2. Gr{oetje,eeting}s, Geert
Hi Geert, On Wednesday, January 23, 2019, Geert Uytterhoeven wrote: > > I can't find 'dt_binding_check' (I guess it's only in the DT tree). > > This seems to be a make target: "make dt_binding_check" > (included in last renesas-drivers). > > This needs "dt-mk-schema", which you can find in > https://github.com/robherring/yaml-bindings > > Cloned, patch sent for missing python3-pip dependency, installed, put in > $PATH, > and now it seems to like your v2. Thank you!!! Chris
On Wed, Jan 23, 2019 at 8:09 AM Chris Brandt <Chris.Brandt@renesas.com> wrote: > > On Wednesday, January 23, 2019, Rob Herring wrote: > > Please check your changes with 'dt_binding_check' target. This will > > fail. 'description' already has a value, so you can't add a list to > > it. And description has to be a string. > > > > > items: > > > > Move the 2 lines here. > > > > > - const: renesas,r7s9210 > > I can't find 'dt_binding_check' (I guess it's only in the DT tree). It's a make target added in 5.0-rc1. You need 'yaml-bindings' installed. See Documentation/devicetree/writing-schemas.md for details. Rob
diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml index 5e9d4864a600..474eb2647829 100644 --- a/Documentation/devicetree/bindings/arm/renesas.yaml +++ b/Documentation/devicetree/bindings/arm/renesas.yaml @@ -29,6 +29,8 @@ properties: - const: renesas,r7s72100 - description: RZ/A2 (R7S9210) + - enum: + - renesas,rza2mevb # RZ/A2M Eval Board (RTK7921053S00000BE) items: - const: renesas,r7s9210
Add the RZ/A2M Evaluation board. Signed-off-by: Chris Brandt <chris.brandt@renesas.com> --- Documentation/devicetree/bindings/arm/renesas.yaml | 2 ++ 1 file changed, 2 insertions(+)