| Message ID | 20190126192732.15263-1-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/1] drm: drop drm_bus from todo | expand |
Hey On Sat, Jan 26, 2019 at 8:27 PM Sam Ravnborg <sam@ravnborg.org> wrote: > David Herrmann removed the last bits of drm_bus in: > c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!") > > Remove the todo item. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: David Herrmann <dh.herrmann@gmail.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Sean Paul <sean@poorly.run> > --- > Documentation/gpu/todo.rst | 19 ------------------- > 1 file changed, 19 deletions(-) I miss drm_bus! Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Thanks David > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 38360ede1221..d9515b17d36f 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days. > Subsystem-wide refactorings > =========================== > > -De-midlayer drivers > -------------------- > - > -With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required > -to have a ``drm_bus`` structure set up. Drivers can directly set up the > -``drm_device`` structure instead of relying on bus methods in ``drm_usb.c`` > -and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` / > -``->unload`` callbacks and open-code the load/unload sequence properly, using > -the new two-stage ``drm_device`` setup/teardown. > - > -Once all existing drivers are converted we can also remove those bus support > -files for USB and platform devices. > - > -All you need is a GPU for a non-converted driver (currently almost all of > -them, but also all the virtual ones used by KVM, so everyone qualifies). > - > -Contact: Daniel Vetter, Thierry Reding, respective driver maintainers > - > - > Remove custom dumb_map_offset implementations > --------------------------------------------- > > -- > 2.12.0 >
On Sun, Jan 27, 2019 at 12:00:37PM +0100, David Herrmann wrote: > Hey > > On Sat, Jan 26, 2019 at 8:27 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > David Herrmann removed the last bits of drm_bus in: > > c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!") > > > > Remove the todo item. > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > Cc: David Herrmann <dh.herrmann@gmail.com> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > > Cc: Sean Paul <sean@poorly.run> > > --- > > Documentation/gpu/todo.rst | 19 ------------------- > > 1 file changed, 19 deletions(-) > > I miss drm_bus! > > Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Sam, want drm-misc commit rights to start merging your own stuff? Assuming you plan to stick around ofc ... I'll also ask the drm-misc maintainers whether that's ok. Thanks, Daniel > > Thanks > David > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 38360ede1221..d9515b17d36f 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days. > > Subsystem-wide refactorings > > =========================== > > > > -De-midlayer drivers > > -------------------- > > - > > -With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required > > -to have a ``drm_bus`` structure set up. Drivers can directly set up the > > -``drm_device`` structure instead of relying on bus methods in ``drm_usb.c`` > > -and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` / > > -``->unload`` callbacks and open-code the load/unload sequence properly, using > > -the new two-stage ``drm_device`` setup/teardown. > > - > > -Once all existing drivers are converted we can also remove those bus support > > -files for USB and platform devices. > > - > > -All you need is a GPU for a non-converted driver (currently almost all of > > -them, but also all the virtual ones used by KVM, so everyone qualifies). > > - > > -Contact: Daniel Vetter, Thierry Reding, respective driver maintainers > > - > > - > > Remove custom dumb_map_offset implementations > > --------------------------------------------- > > > > -- > > 2.12.0 > >
Hi Daniel. > > Sam, want drm-misc commit rights to start merging your own stuff? Assuming > you plan to stick around ofc ... I'll also ask the drm-misc maintainers > whether that's ok. The plan is to re-submit the Atmel LCDC DRM driver when I find enough time to finish it. All coding is done and it builds, I 'only' need to make it work. When I submit the driver the plan is to share the maintainer role for both Atmel based DRM drivers (hlcdc + lcdc). So it would make sense to gain drm-misc commit rights at least then. Last time I looked at it I was stucked in the keys required and the tools I needed to learn. This was not really where I had energy to spend the effort. Sam
On Tue, Jan 29, 2019 at 3:54 AM Daniel Vetter <daniel@ffwll.ch> wrote: > > On Sun, Jan 27, 2019 at 12:00:37PM +0100, David Herrmann wrote: > > Hey > > > > On Sat, Jan 26, 2019 at 8:27 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > > David Herrmann removed the last bits of drm_bus in: > > > c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!") > > > > > > Remove the todo item. > > > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > > Cc: David Herrmann <dh.herrmann@gmail.com> > > > Cc: David Airlie <airlied@linux.ie> > > > Cc: Daniel Vetter <daniel@ffwll.ch> > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > > > Cc: Sean Paul <sean@poorly.run> > > > --- > > > Documentation/gpu/todo.rst | 19 ------------------- > > > 1 file changed, 19 deletions(-) > > > > I miss drm_bus! > > > > Reviewed-by: David Herrmann <dh.herrmann@gmail.com> > > Sam, want drm-misc commit rights to start merging your own stuff? Assuming > you plan to stick around ofc ... I'll also ask the drm-misc maintainers > whether that's ok. > Acked-by: Sean Paul <sean@poorly.run> > Thanks, Daniel > > > > > Thanks > > David > > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > > index 38360ede1221..d9515b17d36f 100644 > > > --- a/Documentation/gpu/todo.rst > > > +++ b/Documentation/gpu/todo.rst > > > @@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days. > > > Subsystem-wide refactorings > > > =========================== > > > > > > -De-midlayer drivers > > > -------------------- > > > - > > > -With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required > > > -to have a ``drm_bus`` structure set up. Drivers can directly set up the > > > -``drm_device`` structure instead of relying on bus methods in ``drm_usb.c`` > > > -and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` / > > > -``->unload`` callbacks and open-code the load/unload sequence properly, using > > > -the new two-stage ``drm_device`` setup/teardown. > > > - > > > -Once all existing drivers are converted we can also remove those bus support > > > -files for USB and platform devices. > > > - > > > -All you need is a GPU for a non-converted driver (currently almost all of > > > -them, but also all the virtual ones used by KVM, so everyone qualifies). > > > - > > > -Contact: Daniel Vetter, Thierry Reding, respective driver maintainers > > > - > > > - > > > Remove custom dumb_map_offset implementations > > > --------------------------------------------- > > > > > > -- > > > 2.12.0 > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
On Tue, Jan 29, 2019 at 03:18:00PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > > > > Sam, want drm-misc commit rights to start merging your own stuff? Assuming > > you plan to stick around ofc ... I'll also ask the drm-misc maintainers > > whether that's ok. > > The plan is to re-submit the Atmel LCDC DRM driver when I find enough time > to finish it. All coding is done and it builds, I 'only' need to make it work. > > When I submit the driver the plan is to share the maintainer role for > both Atmel based DRM drivers (hlcdc + lcdc). > So it would make sense to gain drm-misc commit rights at least then. > > Last time I looked at it I was stucked in the keys required and the tools > I needed to learn. This was not really where I had energy to spend the effort. Can I motivate you some more? I'm happy to ramp up people for a bit, but I can't do patch review&applying for everyone. Wouldn't scale. Expect me to become increasingly annoying about this :-) -Daniel
On Sun, Jan 27, 2019 at 12:00:37PM +0100, David Herrmann wrote: > Hey > > On Sat, Jan 26, 2019 at 8:27 PM Sam Ravnborg <sam@ravnborg.org> wrote: > > David Herrmann removed the last bits of drm_bus in: > > c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!") > > > > Remove the todo item. > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > Cc: David Herrmann <dh.herrmann@gmail.com> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > > Cc: Sean Paul <sean@poorly.run> > > --- > > Documentation/gpu/todo.rst | 19 ------------------- > > 1 file changed, 19 deletions(-) > > I miss drm_bus! > > Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Applied and pushed to drm-misc-next Sam
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 38360ede1221..d9515b17d36f 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -10,25 +10,6 @@ graphics subsystem useful as newbie projects. Or for slow rainy days. Subsystem-wide refactorings =========================== -De-midlayer drivers -------------------- - -With the recent ``drm_bus`` cleanup patches for 3.17 it is no longer required -to have a ``drm_bus`` structure set up. Drivers can directly set up the -``drm_device`` structure instead of relying on bus methods in ``drm_usb.c`` -and ``drm_pci.c``. The goal is to get rid of the driver's ``->load`` / -``->unload`` callbacks and open-code the load/unload sequence properly, using -the new two-stage ``drm_device`` setup/teardown. - -Once all existing drivers are converted we can also remove those bus support -files for USB and platform devices. - -All you need is a GPU for a non-converted driver (currently almost all of -them, but also all the virtual ones used by KVM, so everyone qualifies). - -Contact: Daniel Vetter, Thierry Reding, respective driver maintainers - - Remove custom dumb_map_offset implementations ---------------------------------------------
David Herrmann removed the last bits of drm_bus in: c5786fe5f1c50941dbe27fc8b4aa1afee46ae893 ("drm: Goody bye, drm_bus!") Remove the todo item. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: David Herrmann <dh.herrmann@gmail.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Sean Paul <sean@poorly.run> --- Documentation/gpu/todo.rst | 19 ------------------- 1 file changed, 19 deletions(-)