| Message ID | 20190129152522.GA24872@nishad (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | MIPS: Select PINCTRL_RT2880 when RALINK is enabled | expand |
Hi Nishad, On Tue, Jan 29, 2019 at 08:55:27PM +0530, Nishad Kamdar wrote: > This patch selects config PINCTRL_RT2880 when config RALINK is > enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL > is also selected when RALINK is enabled to avoid config dependency > warnings. > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > --- > arch/mips/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index e2fc88da0223..cea529cf6284 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -623,6 +623,8 @@ config RALINK > select CLKDEV_LOOKUP > select ARCH_HAS_RESET_CONTROLLER > select RESET_CONTROLLER > + select PINCTRL > + select PINCTRL_RT2880 > > config SGI_IP22 > bool "SGI IP22 (Indy/Indigo2)" Wouldn't this also require selecting STAGING? Perhaps that's why it wasn't done in the first place? Thanks, Paul
On Tue, Jan 29, 2019 at 08:09:07PM +0000, Paul Burton wrote: > Hi Nishad, > > On Tue, Jan 29, 2019 at 08:55:27PM +0530, Nishad Kamdar wrote: > > This patch selects config PINCTRL_RT2880 when config RALINK is > > enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL > > is also selected when RALINK is enabled to avoid config dependency > > warnings. > > > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > > --- > > arch/mips/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > index e2fc88da0223..cea529cf6284 100644 > > --- a/arch/mips/Kconfig > > +++ b/arch/mips/Kconfig > > @@ -623,6 +623,8 @@ config RALINK > > select CLKDEV_LOOKUP > > select ARCH_HAS_RESET_CONTROLLER > > select RESET_CONTROLLER > > + select PINCTRL > > + select PINCTRL_RT2880 > > > > config SGI_IP22 > > bool "SGI IP22 (Indy/Indigo2)" > > Wouldn't this also require selecting STAGING? Perhaps that's why it > wasn't done in the first place? > > Thanks, > Paul Ok, got it. Thanks for the review. Regards, Nishad
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index e2fc88da0223..cea529cf6284 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -623,6 +623,8 @@ config RALINK select CLKDEV_LOOKUP select ARCH_HAS_RESET_CONTROLLER select RESET_CONTROLLER + select PINCTRL + select PINCTRL_RT2880 config SGI_IP22 bool "SGI IP22 (Indy/Indigo2)"
This patch selects config PINCTRL_RT2880 when config RALINK is enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL is also selected when RALINK is enabled to avoid config dependency warnings. Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> --- arch/mips/Kconfig | 2 ++ 1 file changed, 2 insertions(+)