diff mbox series

[v10,15/40] drm: removing the DP Errata msg and its msg id

Message ID 1548917996-28081-16-git-send-email-ramalingam.c@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Implement HDCP2.2 | expand

Commit Message

Ramalingam C Jan. 31, 2019, 6:59 a.m. UTC
Since DP ERRATA message is not defined at spec, those structure
definition is removed from drm_hdcp.h

Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 include/drm/drm_hdcp.h | 6 ------
 1 file changed, 6 deletions(-)

Comments

Daniel Vetter Jan. 31, 2019, 8:02 a.m. UTC | #1
On Thu, Jan 31, 2019 at 12:29:31PM +0530, Ramalingam C wrote:
> Since DP ERRATA message is not defined at spec, those structure
> definition is removed from drm_hdcp.h
> 
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  include/drm/drm_hdcp.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index d4e98b11b4aa..f243408ecf26 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -69,7 +69,6 @@
>  #define HDCP_2_2_REP_SEND_ACK			15
>  #define HDCP_2_2_REP_STREAM_MANAGE		16
>  #define HDCP_2_2_REP_STREAM_READY		17
> -#define HDCP_2_2_ERRATA_DP_STREAM_TYPE		50
>  
>  #define HDCP_2_2_RTX_LEN			8
>  #define HDCP_2_2_RRX_LEN			8
> @@ -220,11 +219,6 @@ struct hdcp2_rep_stream_ready {
>  	u8	m_prime[HDCP_2_2_MPRIME_LEN];
>  } __packed;
>  
> -struct hdcp2_dp_errata_stream_type {
> -	u8	msg_id;
> -	u8	stream_type;
> -} __packed;
> -
>  /* HDCP2.2 TIMEOUTs in mSec */
>  #define HDCP_2_2_CERT_TIMEOUT_MS		100
>  #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS	1000
> -- 
> 2.7.4
>
Shankar, Uma Feb. 4, 2019, 2:35 p.m. UTC | #2
>-----Original Message-----
>From: C, Ramalingam
>Sent: Thursday, January 31, 2019 12:30 PM
>To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
>daniel.vetter@ffwll.ch; Winkler, Tomas <tomas.winkler@intel.com>; Shankar,
>Uma <uma.shankar@intel.com>
>Cc: C, Ramalingam <ramalingam.c@intel.com>
>Subject: [PATCH v10 15/40] drm: removing the DP Errata msg and its msg id
>
>Since DP ERRATA message is not defined at spec, those structure definition is
>removed from drm_hdcp.h

I believe we still want to have it but inside the driver isn't it ?, would be good to
add a comment on that.

With that fixed.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>
>Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
>Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>


>---
> include/drm/drm_hdcp.h | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index
>d4e98b11b4aa..f243408ecf26 100644
>--- a/include/drm/drm_hdcp.h
>+++ b/include/drm/drm_hdcp.h
>@@ -69,7 +69,6 @@
> #define HDCP_2_2_REP_SEND_ACK			15
> #define HDCP_2_2_REP_STREAM_MANAGE		16
> #define HDCP_2_2_REP_STREAM_READY		17
>-#define HDCP_2_2_ERRATA_DP_STREAM_TYPE		50
>
> #define HDCP_2_2_RTX_LEN			8
> #define HDCP_2_2_RRX_LEN			8
>@@ -220,11 +219,6 @@ struct hdcp2_rep_stream_ready {
> 	u8	m_prime[HDCP_2_2_MPRIME_LEN];
> } __packed;
>
>-struct hdcp2_dp_errata_stream_type {
>-	u8	msg_id;
>-	u8	stream_type;
>-} __packed;
>-
> /* HDCP2.2 TIMEOUTs in mSec */
> #define HDCP_2_2_CERT_TIMEOUT_MS		100
> #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS	1000
>--
>2.7.4
diff mbox series

Patch

diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index d4e98b11b4aa..f243408ecf26 100644
--- a/include/drm/drm_hdcp.h
+++ b/include/drm/drm_hdcp.h
@@ -69,7 +69,6 @@ 
 #define HDCP_2_2_REP_SEND_ACK			15
 #define HDCP_2_2_REP_STREAM_MANAGE		16
 #define HDCP_2_2_REP_STREAM_READY		17
-#define HDCP_2_2_ERRATA_DP_STREAM_TYPE		50
 
 #define HDCP_2_2_RTX_LEN			8
 #define HDCP_2_2_RRX_LEN			8
@@ -220,11 +219,6 @@  struct hdcp2_rep_stream_ready {
 	u8	m_prime[HDCP_2_2_MPRIME_LEN];
 } __packed;
 
-struct hdcp2_dp_errata_stream_type {
-	u8	msg_id;
-	u8	stream_type;
-} __packed;
-
 /* HDCP2.2 TIMEOUTs in mSec */
 #define HDCP_2_2_CERT_TIMEOUT_MS		100
 #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS	1000