| Message ID | 20190125114155.32062-1-vkuznets@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | i386/kvm/hyper-v: refactor and implement 'hv-stimer-direct' and 'hv-all' enlightenments | expand |
Patchew URL: https://patchew.org/QEMU/20190125114155.32062-1-vkuznets@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH RFC 0/8] i386/kvm/hyper-v: refactor and implement 'hv-stimer-direct' and 'hv-all' enlightenments Type: series Message-id: 20190125114155.32062-1-vkuznets@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' dabb4951b0 i386/kvm: add support for Direct Mode for Hyper-V synthetic timers 223e993ccd i386/kvm: hv-tlbflush/ipi require hv-vpindex 3051f4d3de i386/kvm: hv-stimer requires hv-time and hv-synic 6ca6a10f0a i386/kvm: hv-evmcs requires hv-vapic c8aeebcffd i386/kvm: Implement 'hv-all' pass-through mode 79a00f19c1 i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties() 69c92de59b i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID 345a0718e2 Update linux headers (5.0-rc2) === OUTPUT BEGIN === 1/8 Checking commit 345a0718e21e (Update linux headers (5.0-rc2)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1646: new file mode 100644 ERROR: code indent should never use tabs #3980: FILE: scripts/update-linux-headers.sh:126: +^Icp "$tmpdir/include/asm/unistd_n64.h" "$output/linux-headers/asm-mips/"$ WARNING: line over 80 characters #3983: FILE: scripts/update-linux-headers.sh:129: + cp "$tmpdir/include/asm/unistd_32.h" "$output/linux-headers/asm-powerpc/" WARNING: line over 80 characters #3984: FILE: scripts/update-linux-headers.sh:130: + cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-powerpc/" ERROR: code indent should never use tabs #3984: FILE: scripts/update-linux-headers.sh:130: +^Icp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-powerpc/"$ total: 2 errors, 3 warnings, 3838 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit 69c92de59b5d (i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID) 3/8 Checking commit 79a00f19c1c4 (i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties()) 4/8 Checking commit c8aeebcffd5a (i386/kvm: Implement 'hv-all' pass-through mode) 5/8 Checking commit 6ca6a10f0a12 (i386/kvm: hv-evmcs requires hv-vapic) 6/8 Checking commit 3051f4d3de1e (i386/kvm: hv-stimer requires hv-time and hv-synic) 7/8 Checking commit 223e993ccd15 (i386/kvm: hv-tlbflush/ipi require hv-vpindex) 8/8 Checking commit dabb4951b005 (i386/kvm: add support for Direct Mode for Hyper-V synthetic timers) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190125114155.32062-1-vkuznets@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org writes: > === OUTPUT BEGIN === > 1/8 Checking commit 345a0718e21e (Update linux headers (5.0-rc2)) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #1646: > new file mode 100644 > > ERROR: code indent should never use tabs > #3980: FILE: scripts/update-linux-headers.sh:126: > +^Icp "$tmpdir/include/asm/unistd_n64.h" "$output/linux-headers/asm-mips/"$ > > WARNING: line over 80 characters > #3983: FILE: scripts/update-linux-headers.sh:129: > + cp "$tmpdir/include/asm/unistd_32.h" "$output/linux-headers/asm-powerpc/" > > WARNING: line over 80 characters > #3984: FILE: scripts/update-linux-headers.sh:130: > + cp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-powerpc/" > > ERROR: code indent should never use tabs > #3984: FILE: scripts/update-linux-headers.sh:130: > +^Icp "$tmpdir/include/asm/unistd_64.h" "$output/linux-headers/asm-powerpc/"$ > I saw these before submitting, however, these are linux headers and we take them as-is with scripts/update-linux-headers.sh: I don't think it is worth it to modify these headers just to silence patchew.