| Message ID | 20190201135512.68220-2-koraktor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/2] describe: setup working tree for --dirty | expand |
Sebastian Staudt <koraktor@gmail.com> writes: > This ensures that nothing breaks the basic functionality of describe for > bare repositories. Please note that --broken and --dirty need a working > tree. > > Signed-off-by: Sebastian Staudt <koraktor@gmail.com> > --- > t/t6120-describe.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh > index 7cfed77c52..ea2c3dbe1c 100755 > --- a/t/t6120-describe.sh > +++ b/t/t6120-describe.sh > @@ -418,4 +418,9 @@ test_expect_success 'describe complains about missing object' ' > test_must_fail git describe $ZERO_OID > ' > > +test_expect_success 'describe works from outside repo using --git-dir' ' > + git clone --bare "$TRASH_DIRECTORY" "$TRASH_DIRECTORY/bare" && > + git --git-dir "$TRASH_DIRECTORY/bare" describe > +' OK, it demonstrates that the command exits with status 0. Do we want to validate its output, too?
Am Fr., 1. Feb. 2019 um 19:53 Uhr schrieb Junio C Hamano <gitster@pobox.com>: > > Sebastian Staudt <koraktor@gmail.com> writes: > > > This ensures that nothing breaks the basic functionality of describe for > > bare repositories. Please note that --broken and --dirty need a working > > tree. > > > > Signed-off-by: Sebastian Staudt <koraktor@gmail.com> > > --- > > t/t6120-describe.sh | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh > > index 7cfed77c52..ea2c3dbe1c 100755 > > --- a/t/t6120-describe.sh > > +++ b/t/t6120-describe.sh > > @@ -418,4 +418,9 @@ test_expect_success 'describe complains about missing object' ' > > test_must_fail git describe $ZERO_OID > > ' > > > > +test_expect_success 'describe works from outside repo using --git-dir' ' > > + git clone --bare "$TRASH_DIRECTORY" "$TRASH_DIRECTORY/bare" && > > + git --git-dir "$TRASH_DIRECTORY/bare" describe > > +' > > OK, it demonstrates that the command exits with status 0. Do we > want to validate its output, too? It won‘t hurt. I‘ll move this test further up, so it is executed when the working tree is still clean. That way we can use the same regex as for the other checks. Thanks.
diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index 7cfed77c52..ea2c3dbe1c 100755 --- a/t/t6120-describe.sh +++ b/t/t6120-describe.sh @@ -418,4 +418,9 @@ test_expect_success 'describe complains about missing object' ' test_must_fail git describe $ZERO_OID ' +test_expect_success 'describe works from outside repo using --git-dir' ' + git clone --bare "$TRASH_DIRECTORY" "$TRASH_DIRECTORY/bare" && + git --git-dir "$TRASH_DIRECTORY/bare" describe +' + test_done
This ensures that nothing breaks the basic functionality of describe for bare repositories. Please note that --broken and --dirty need a working tree. Signed-off-by: Sebastian Staudt <koraktor@gmail.com> --- t/t6120-describe.sh | 5 +++++ 1 file changed, 5 insertions(+)