| Message ID | e944650d-514f-3727-2e68-b318aab9ee7f@web.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] arm64: dts: hikey: Give wifi some time after power-on | expand |
Hi Jan, On 1/24/2019 7:52 AM, Jan Kiszka wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > Somewhere along recent changes to power control of the wl1835, power-on > became very unreliable on the hikey, failing like this: > > wl1271_sdio: probe of mmc2:0001:1 failed with error -16 > wl1271_sdio: probe of mmc2:0001:2 failed with error -16 > > After playing with some dt parameters and comparing to other users of > this chip, it turned out we need some power-on delay to make things > stable again. In contrast to those other users which define 200 ms, the > hikey would already be happy with 1 ms. Still, we use the safer 10 ms, > like on the Ultra96. > > Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Applied to the hisilicon soc dt tree. Thanks! Best Regards, Wei > --- > > Changes in v2: > - set delay to 10 ms > - updated changelog > > Who will take care of updating also the Hikey firmware dts with this > change? > > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index 610235028cc7..ba946543dd0a 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -118,6 +118,7 @@ > reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; > clocks = <&pmic>; > clock-names = "ext_clock"; > + post-power-on-delay-ms = <10>; > power-off-delay-us = <10>; > }; > > -- > 2.16.4 > > . >
On Fri, 1 Feb 2019 at 17:34, Wei Xu <xuwei5@hisilicon.com> wrote: > > Hi Jan, > > On 1/24/2019 7:52 AM, Jan Kiszka wrote: > > From: Jan Kiszka <jan.kiszka@siemens.com> > > > > Somewhere along recent changes to power control of the wl1835, power-on > > became very unreliable on the hikey, failing like this: > > > > wl1271_sdio: probe of mmc2:0001:1 failed with error -16 > > wl1271_sdio: probe of mmc2:0001:2 failed with error -16 > > > > After playing with some dt parameters and comparing to other users of > > this chip, it turned out we need some power-on delay to make things > > stable again. In contrast to those other users which define 200 ms, the > > hikey would already be happy with 1 ms. Still, we use the safer 10 ms, > > like on the Ultra96. > > > > Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> > > Applied to the hisilicon soc dt tree. Wei, can you please also add a stable tag to it? [...] Thanks and kind regards Uffe
Hi Ulf, On 2/4/2019 6:06 AM, Ulf Hansson wrote: > On Fri, 1 Feb 2019 at 17:34, Wei Xu <xuwei5@hisilicon.com> wrote: >> >> Hi Jan, >> >> On 1/24/2019 7:52 AM, Jan Kiszka wrote: >>> From: Jan Kiszka <jan.kiszka@siemens.com> >>> >>> Somewhere along recent changes to power control of the wl1835, power-on >>> became very unreliable on the hikey, failing like this: >>> >>> wl1271_sdio: probe of mmc2:0001:1 failed with error -16 >>> wl1271_sdio: probe of mmc2:0001:2 failed with error -16 >>> >>> After playing with some dt parameters and comparing to other users of >>> this chip, it turned out we need some power-on delay to make things >>> stable again. In contrast to those other users which define 200 ms, the >>> hikey would already be happy with 1 ms. Still, we use the safer 10 ms, >>> like on the Ultra96. >>> >>> Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") >>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >>> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> >> >> Applied to the hisilicon soc dt tree. > > Wei, can you please also add a stable tag to it? Yes, added below tag into this patch. Cc: <stable@vger.kernel.org> #4.12+ Thanks for your kindly reminder :) Best Regards, Wei > > [...] > > Thanks and kind regards > Uffe > > . >
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts index 610235028cc7..ba946543dd0a 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts @@ -118,6 +118,7 @@ reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; clocks = <&pmic>; clock-names = "ext_clock"; + post-power-on-delay-ms = <10>; power-off-delay-us = <10>; };