Message ID | 20190205170510.21984-1-peter.maydell@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20190205170510.21984-1-peter.maydell@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/22] target-arm queue Type: series Message-id: 20190205170510.21984-1-peter.maydell@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190205170510.21984-1-peter.maydell@linaro.org -> patchew/20190205170510.21984-1-peter.maydell@linaro.org Switched to a new branch 'test' 6ffc7d7c6e target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI 30bbbd5fe4 hw/arm/boot: Support DTB autoload for firmware-only boots 7bd500bd87 hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info 25e1889da8 hw/arm/boot: Factor out "set up firmware boot" code 50de45269e hw/arm/boot: Factor out "direct kernel boot" code into its own function aca9c240aa hw/arm/boot: Fix block comment style in arm_load_kernel() 78941d8842 gdbstub: allow killing QEMU via vKill command 721a4323d6 target/arm: Enable TBI for user-only 362b79acbb target/arm: Compute TB_FLAGS for TBI for user-only 1fc2220bbf target/arm: Clean TBI for data operations in the translator 0f5454a0fe target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore 959de989c7 tests/tcg/aarch64: Add pauth smoke test 642c75987d linux-user: Implement PR_PAC_RESET_KEYS 39bd3e614f target/arm: Enable BTI for -cpu max 45c6a616a9 target/arm: Set btype for indirect branches 668e1edaf5 target/arm: Reset btype for direct branches d58c736883 target/arm: Default handling of BTYPE during translation a853f2b383 target/arm: Cache the GP bit for a page in MemTxAttrs 74d53e27f0 exec: Add target-specific tlb bits to MemTxAttrs 1f99e8c899 target/arm: Add BT and BTYPE to tb->flags a95068bf12 target/arm: Add PSTATE.BTYPE a20e5cc7a6 target/arm: Introduce isar_feature_aa64_bti === OUTPUT BEGIN === 1/22 Checking commit a20e5cc7a61e (target/arm: Introduce isar_feature_aa64_bti) 2/22 Checking commit a95068bf1254 (target/arm: Add PSTATE.BTYPE) 3/22 Checking commit 1f99e8c899f8 (target/arm: Add BT and BTYPE to tb->flags) 4/22 Checking commit 74d53e27f036 (exec: Add target-specific tlb bits to MemTxAttrs) ERROR: spaces prohibited around that ':' (ctx:WxW) #31: FILE: include/exec/memattrs.h:47: + unsigned int target_tlb_bit0 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #32: FILE: include/exec/memattrs.h:48: + unsigned int target_tlb_bit1 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #33: FILE: include/exec/memattrs.h:49: + unsigned int target_tlb_bit2 : 1; ^ total: 3 errors, 0 warnings, 16 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit a853f2b383d2 (target/arm: Cache the GP bit for a page in MemTxAttrs) 6/22 Checking commit d58c736883d2 (target/arm: Default handling of BTYPE during translation) ERROR: return is not a function, parentheses are not required #99: FILE: target/arm/translate-a64.c:13796: + return (tlb_hit(entry->addr_code, addr) && total: 1 errors, 0 warnings, 196 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 668e1edaf5b8 (target/arm: Reset btype for direct branches) 8/22 Checking commit 45c6a616a907 (target/arm: Set btype for indirect branches) 9/22 Checking commit 39bd3e614f92 (target/arm: Enable BTI for -cpu max) 10/22 Checking commit 642c75987d31 (linux-user: Implement PR_PAC_RESET_KEYS) 11/22 Checking commit 959de989c7b4 (tests/tcg/aarch64: Add pauth smoke test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Patch 11/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/22 Checking commit 0f5454a0fe1d (target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore) 13/22 Checking commit 1fc2220bbf43 (target/arm: Clean TBI for data operations in the translator) WARNING: Block comments use a leading /* on a separate line #514: FILE: target/arm/translate-a64.c:3256: + do_gpr_ld(s, tcg_rt, clean_addr, size, /* is_signed */ false, total: 0 errors, 1 warnings, 574 lines checked Patch 13/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/22 Checking commit 362b79acbbb0 (target/arm: Compute TB_FLAGS for TBI for user-only) 15/22 Checking commit 721a4323d693 (target/arm: Enable TBI for user-only) 16/22 Checking commit 78941d8842e8 (gdbstub: allow killing QEMU via vKill command) 17/22 Checking commit aca9c240aa47 (hw/arm/boot: Fix block comment style in arm_load_kernel()) 18/22 Checking commit 50de45269e4d (hw/arm/boot: Factor out "direct kernel boot" code into its own function) 19/22 Checking commit 25e1889da8c6 (hw/arm/boot: Factor out "set up firmware boot" code) 20/22 Checking commit 7bd500bd874d (hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info) 21/22 Checking commit 30bbbd5fe454 (hw/arm/boot: Support DTB autoload for firmware-only boots) 22/22 Checking commit 6ffc7d7c6eef (target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190205170510.21984-1-peter.maydell@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190205170510.21984-1-peter.maydell@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190205170510.21984-1-peter.maydell@linaro.org Subject: [Qemu-devel] [PULL 00/22] target-arm queue Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 01a9a51..68df0c3 master -> master - [tag update] patchew/20190205151810.571-1-peter.maydell@linaro.org -> patchew/20190205151810.571-1-peter.maydell@linaro.org * [new tag] patchew/20190205165927.26599-1-samuel.thibault@ens-lyon.org -> patchew/20190205165927.26599-1-samuel.thibault@ens-lyon.org * [new tag] patchew/20190205170510.21984-1-peter.maydell@linaro.org -> patchew/20190205170510.21984-1-peter.maydell@linaro.org Switched to a new branch 'test' 6ffc7d7 target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI 30bbbd5 hw/arm/boot: Support DTB autoload for firmware-only boots 7bd500b hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info 25e1889 hw/arm/boot: Factor out "set up firmware boot" code 50de452 hw/arm/boot: Factor out "direct kernel boot" code into its own function aca9c24 hw/arm/boot: Fix block comment style in arm_load_kernel() 78941d8 gdbstub: allow killing QEMU via vKill command 721a432 target/arm: Enable TBI for user-only 362b79a target/arm: Compute TB_FLAGS for TBI for user-only 1fc2220 target/arm: Clean TBI for data operations in the translator 0f5454a target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore 959de98 tests/tcg/aarch64: Add pauth smoke test 642c759 linux-user: Implement PR_PAC_RESET_KEYS 39bd3e6 target/arm: Enable BTI for -cpu max 45c6a61 target/arm: Set btype for indirect branches 668e1ed target/arm: Reset btype for direct branches d58c736 target/arm: Default handling of BTYPE during translation a853f2b target/arm: Cache the GP bit for a page in MemTxAttrs 74d53e2 exec: Add target-specific tlb bits to MemTxAttrs 1f99e8c target/arm: Add BT and BTYPE to tb->flags a95068b target/arm: Add PSTATE.BTYPE a20e5cc target/arm: Introduce isar_feature_aa64_bti === OUTPUT BEGIN === 1/22 Checking commit a20e5cc7a61e (target/arm: Introduce isar_feature_aa64_bti) 2/22 Checking commit a95068bf1254 (target/arm: Add PSTATE.BTYPE) 3/22 Checking commit 1f99e8c899f8 (target/arm: Add BT and BTYPE to tb->flags) 4/22 Checking commit 74d53e27f036 (exec: Add target-specific tlb bits to MemTxAttrs) ERROR: spaces prohibited around that ':' (ctx:WxW) #31: FILE: include/exec/memattrs.h:47: + unsigned int target_tlb_bit0 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #32: FILE: include/exec/memattrs.h:48: + unsigned int target_tlb_bit1 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #33: FILE: include/exec/memattrs.h:49: + unsigned int target_tlb_bit2 : 1; ^ total: 3 errors, 0 warnings, 16 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit a853f2b383d2 (target/arm: Cache the GP bit for a page in MemTxAttrs) 6/22 Checking commit d58c736883d2 (target/arm: Default handling of BTYPE during translation) ERROR: return is not a function, parentheses are not required #99: FILE: target/arm/translate-a64.c:13796: + return (tlb_hit(entry->addr_code, addr) && total: 1 errors, 0 warnings, 196 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 668e1edaf5b8 (target/arm: Reset btype for direct branches) 8/22 Checking commit 45c6a616a907 (target/arm: Set btype for indirect branches) 9/22 Checking commit 39bd3e614f92 (target/arm: Enable BTI for -cpu max) 10/22 Checking commit 642c75987d31 (linux-user: Implement PR_PAC_RESET_KEYS) 11/22 Checking commit 959de989c7b4 (tests/tcg/aarch64: Add pauth smoke test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Patch 11/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/22 Checking commit 0f5454a0fe1d (target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore) 13/22 Checking commit 1fc2220bbf43 (target/arm: Clean TBI for data operations in the translator) WARNING: Block comments use a leading /* on a separate line #514: FILE: target/arm/translate-a64.c:3256: + do_gpr_ld(s, tcg_rt, clean_addr, size, /* is_signed */ false, total: 0 errors, 1 warnings, 574 lines checked Patch 13/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/22 Checking commit 362b79acbbb0 (target/arm: Compute TB_FLAGS for TBI for user-only) 15/22 Checking commit 721a4323d693 (target/arm: Enable TBI for user-only) 16/22 Checking commit 78941d8842e8 (gdbstub: allow killing QEMU via vKill command) 17/22 Checking commit aca9c240aa47 (hw/arm/boot: Fix block comment style in arm_load_kernel()) 18/22 Checking commit 50de45269e4d (hw/arm/boot: Factor out "direct kernel boot" code into its own function) 19/22 Checking commit 25e1889da8c6 (hw/arm/boot: Factor out "set up firmware boot" code) 20/22 Checking commit 7bd500bd874d (hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info) 21/22 Checking commit 30bbbd5fe454 (hw/arm/boot: Support DTB autoload for firmware-only boots) 22/22 Checking commit 6ffc7d7c6eef (target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190205170510.21984-1-peter.maydell@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190205170510.21984-1-peter.maydell@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/22] target-arm queue Type: series Message-id: 20190205170510.21984-1-peter.maydell@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 68df0c30ed..9669c97562 master -> master t [tag update] patchew/20190129175403.18017-1-philmd@redhat.com -> patchew/20190129175403.18017-1-philmd@redhat.com t [tag update] patchew/20190205170510.21984-1-peter.maydell@linaro.org -> patchew/20190205170510.21984-1-peter.maydell@linaro.org Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Switched to a new branch 'test' 66423fc523 target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI a61dad4237 hw/arm/boot: Support DTB autoload for firmware-only boots 7688aee282 hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info 80cc07245c hw/arm/boot: Factor out "set up firmware boot" code 7151744025 hw/arm/boot: Factor out "direct kernel boot" code into its own function c12bf1852c hw/arm/boot: Fix block comment style in arm_load_kernel() ce81361fe5 gdbstub: allow killing QEMU via vKill command 93b4d61e49 target/arm: Enable TBI for user-only 61fd950037 target/arm: Compute TB_FLAGS for TBI for user-only 0f01045999 target/arm: Clean TBI for data operations in the translator 53da7d98c9 target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore 1815ecd95b tests/tcg/aarch64: Add pauth smoke test 7d72b64304 linux-user: Implement PR_PAC_RESET_KEYS 3ace79750d target/arm: Enable BTI for -cpu max 30d7f17830 target/arm: Set btype for indirect branches 073d6dfba5 target/arm: Reset btype for direct branches db8941f759 target/arm: Default handling of BTYPE during translation 81ac570579 target/arm: Cache the GP bit for a page in MemTxAttrs f214b66195 exec: Add target-specific tlb bits to MemTxAttrs 61280f6f09 target/arm: Add BT and BTYPE to tb->flags eee1d0b7f2 target/arm: Add PSTATE.BTYPE 45b2d8472f target/arm: Introduce isar_feature_aa64_bti === OUTPUT BEGIN === 1/22 Checking commit 45b2d8472f6a (target/arm: Introduce isar_feature_aa64_bti) 2/22 Checking commit eee1d0b7f24a (target/arm: Add PSTATE.BTYPE) 3/22 Checking commit 61280f6f09c7 (target/arm: Add BT and BTYPE to tb->flags) 4/22 Checking commit f214b66195e4 (exec: Add target-specific tlb bits to MemTxAttrs) ERROR: spaces prohibited around that ':' (ctx:WxW) #31: FILE: include/exec/memattrs.h:47: + unsigned int target_tlb_bit0 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #32: FILE: include/exec/memattrs.h:48: + unsigned int target_tlb_bit1 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #33: FILE: include/exec/memattrs.h:49: + unsigned int target_tlb_bit2 : 1; ^ total: 3 errors, 0 warnings, 16 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 81ac57057995 (target/arm: Cache the GP bit for a page in MemTxAttrs) 6/22 Checking commit db8941f759b6 (target/arm: Default handling of BTYPE during translation) ERROR: return is not a function, parentheses are not required #99: FILE: target/arm/translate-a64.c:13796: + return (tlb_hit(entry->addr_code, addr) && total: 1 errors, 0 warnings, 196 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 073d6dfba51c (target/arm: Reset btype for direct branches) 8/22 Checking commit 30d7f17830ae (target/arm: Set btype for indirect branches) 9/22 Checking commit 3ace79750d7a (target/arm: Enable BTI for -cpu max) 10/22 Checking commit 7d72b6430427 (linux-user: Implement PR_PAC_RESET_KEYS) 11/22 Checking commit 1815ecd95bfc (tests/tcg/aarch64: Add pauth smoke test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Patch 11/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/22 Checking commit 53da7d98c9f3 (target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore) 13/22 Checking commit 0f01045999c8 (target/arm: Clean TBI for data operations in the translator) WARNING: Block comments use a leading /* on a separate line #514: FILE: target/arm/translate-a64.c:3256: + do_gpr_ld(s, tcg_rt, clean_addr, size, /* is_signed */ false, total: 0 errors, 1 warnings, 574 lines checked Patch 13/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/22 Checking commit 61fd950037dc (target/arm: Compute TB_FLAGS for TBI for user-only) 15/22 Checking commit 93b4d61e491f (target/arm: Enable TBI for user-only) 16/22 Checking commit ce81361fe5a6 (gdbstub: allow killing QEMU via vKill command) 17/22 Checking commit c12bf1852c42 (hw/arm/boot: Fix block comment style in arm_load_kernel()) 18/22 Checking commit 7151744025df (hw/arm/boot: Factor out "direct kernel boot" code into its own function) 19/22 Checking commit 80cc07245c6e (hw/arm/boot: Factor out "set up firmware boot" code) 20/22 Checking commit 7688aee28231 (hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info) 21/22 Checking commit a61dad42374b (hw/arm/boot: Support DTB autoload for firmware-only boots) 22/22 Checking commit 66423fc5237a (target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190205170510.21984-1-peter.maydell@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Tue, 5 Feb 2019 at 17:05, Peter Maydell <peter.maydell@linaro.org> wrote: > > Arm stuff, mostly patches from RTH. > > thanks > -- PMM > > The following changes since commit 01a9a51ffaf4699827ea6425cb2b834a356e159d: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190205-pull-request' into staging (2019-02-05 14:01:29 +0000) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20190205 > > for you to fetch changes up to a15945d98d3a3390c3da344d1b47218e91e49d8b: > > target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI (2019-02-05 16:52:42 +0000) > > ---------------------------------------------------------------- > target-arm queue: > * Implement Armv8.5-BTI extension for system emulation mode > * Implement the PR_PAC_RESET_KEYS prctl() for linux-user mode's Armv8.3-PAuth support > * Support TBI (top-byte-ignore) properly for linux-user mode > * gdbstub: allow killing QEMU via vKill command > * hw/arm/boot: Support DTB autoload for firmware-only boots > * target/arm: Make FPSCR/FPCR trapped-exception bits RAZ/WI > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM