mbox series

[v3,0/6] Add support for firmware update on Cypres CCGx

Message ID 20190202010510.25016-1-ajayg@nvidia.com (mailing list archive)
Headers show
Series Add support for firmware update on Cypres CCGx | expand

Message

Ajay Gupta Feb. 2, 2019, 1:05 a.m. UTC 
Hi Heikki

These changes adds support for updating firmware on Cypress CCGx
controller. New version (v3) fixes comments form you and Greg.

I have tested them on NVIDIA GPU card.

I will be posting firmware binary patch to linux-firmware.git repo soon.

Please help review this set.

Thanks
Ajay

Ajay Gupta (6):
  usb: typec: ucsi: add get_fw_info function
  usb: typec: ucsi: add ccg command framework
  usb: typec: ucsi: add port num info
  usb: typec: ucsi: add cmd used for fw flashing
  usb: typec: ucsi: add fw update needed check
  usb: typec: ucsi: add firmware flashing support

 drivers/usb/typec/ucsi/ucsi_ccg.c | 881 +++++++++++++++++++++++++++++-
 1 file changed, 874 insertions(+), 7 deletions(-)

Comments

Heikki Krogerus Feb. 6, 2019, 12:11 p.m. UTC | #1 
Hi Ajay,

On Fri, Feb 01, 2019 at 05:05:04PM -0800, Ajay Gupta wrote:
> Hi Heikki
> 
> These changes adds support for updating firmware on Cypress CCGx
> controller. New version (v3) fixes comments form you and Greg.
> 
> I have tested them on NVIDIA GPU card.
> 
> I will be posting firmware binary patch to linux-firmware.git repo soon.
> 
> Please help review this set.
> 
> Thanks
> Ajay
> 
> Ajay Gupta (6):
>   usb: typec: ucsi: add get_fw_info function
>   usb: typec: ucsi: add ccg command framework
>   usb: typec: ucsi: add port num info
>   usb: typec: ucsi: add cmd used for fw flashing
>   usb: typec: ucsi: add fw update needed check
>   usb: typec: ucsi: add firmware flashing support
> 
>  drivers/usb/typec/ucsi/ucsi_ccg.c | 881 +++++++++++++++++++++++++++++-
>  1 file changed, 874 insertions(+), 7 deletions(-)

I think in this case you can add this support in a single patch.

Br,
Ajay Gupta Feb. 6, 2019, 5:49 p.m. UTC | #2 
Hi Heikki,

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Sent: Wednesday, February 6, 2019 4:12 AM
> To: Ajay Gupta <ajaykuee@gmail.com>
> Cc: linux-usb@vger.kernel.org; Ajay Gupta <ajayg@nvidia.com>
> Subject: Re: [PATCH v3 0/6] Add support for firmware update on Cypres CCGx
> 
> Hi Ajay,
> 
> On Fri, Feb 01, 2019 at 05:05:04PM -0800, Ajay Gupta wrote:
> > Hi Heikki
> >
> > These changes adds support for updating firmware on Cypress CCGx
> > controller. New version (v3) fixes comments form you and Greg.
> >
> > I have tested them on NVIDIA GPU card.
> >
> > I will be posting firmware binary patch to linux-firmware.git repo soon.
> >
> > Please help review this set.
> >
> > Thanks
> > Ajay
> >
> > Ajay Gupta (6):
> >   usb: typec: ucsi: add get_fw_info function
> >   usb: typec: ucsi: add ccg command framework
> >   usb: typec: ucsi: add port num info
> >   usb: typec: ucsi: add cmd used for fw flashing
> >   usb: typec: ucsi: add fw update needed check
> >   usb: typec: ucsi: add firmware flashing support
> >
> >  drivers/usb/typec/ucsi/ucsi_ccg.c | 881
> > +++++++++++++++++++++++++++++-
> >  1 file changed, 874 insertions(+), 7 deletions(-)
> 
> I think in this case you can add this support in a single patch.
I will merge patches 2,3,4,5 and,6 together to resolve git bisect issue.
Patch #1 is good to go alone.

thanks
> nvpublic
> 
> Br,
> 
> --
> heikki