| Message ID | 20190207165755.1548-2-johan@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: msm8916-wcd: license and documentation fixes | expand |
On Thu, Feb 07, 2019 at 05:57:53PM +0100, Johan Hovold wrote: > +++ b/sound/soc/codecs/msm8916-wcd-analog.c > @@ -1,3 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2016, The Linux Foundation. All rights reserved. > + */ Please use a C++ comment for the whole thing so it looks more consistent with the rest of ASoC (and a bit neater in general).
On Fri, Feb 08, 2019 at 11:53:41AM +0000, Mark Brown wrote: > On Thu, Feb 07, 2019 at 05:57:53PM +0100, Johan Hovold wrote: > > > +++ b/sound/soc/codecs/msm8916-wcd-analog.c > > @@ -1,3 +1,8 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2016, The Linux Foundation. All rights reserved. > > + */ > > Please use a C++ comment for the whole thing so it looks more consistent > with the rest of ASoC (and a bit neater in general). Ah, yes, that makes sense for consistency since you've already enforced that style. And while I don't think the all-c++-comment headers look better in general, for the single copyright statement case it's not too bad. v2 under way. Johan
On Fri, Feb 08, 2019 at 04:15:02PM +0100, Johan Hovold wrote: > Ah, yes, that makes sense for consistency since you've already enforced > that style. And while I don't think the all-c++-comment headers look > better in general, for the single copyright statement case it's not too > bad. Yeah, I'm not really actively a fan either.
diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c index b7cf7cce95fe..1261ddff75eb 100644 --- a/sound/soc/codecs/msm8916-wcd-analog.c +++ b/sound/soc/codecs/msm8916-wcd-analog.c @@ -1,3 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2016, The Linux Foundation. All rights reserved. + */ + #include <linux/module.h> #include <linux/err.h> #include <linux/kernel.h>
Add the missing license and copyright information which never made it into the analog driver when the original driver was split in two as part of the review process. Link: https://lkml.kernel.org/r/1465582725-30183-3-git-send-email-srinivas.kandagatla@linaro.org Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec") Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Johan Hovold <johan@kernel.org> --- sound/soc/codecs/msm8916-wcd-analog.c | 5 +++++ 1 file changed, 5 insertions(+)