| Message ID | 20190208173458.4801-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: davinci: modernize the irq support | expand |
pt., 8 lut 2019 o 18:35 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a): > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > This series ports the davinci platform to using SPARSE_IRQ, cleans up > the irqchip drivers and moves them over to drivers/irqchip. > > The series can be logically split into four parts. The first (1-8) aims > at introducing support for SPARSE_IRQ. It contains a couple changes > required for that functionality and the final patch actually selecting > it. > > Second part (9-19) makes the aintc driver suitable for drivers/irqchip > and eventually moves it over there. > > Part 3 (20-32) does the same for the cp-intc driver. > > Last patch removes unnecessary code. > > The series has been tested on da850-lcdk (for cp-intc) and > dm365-evm (for aintc). > > v1 -> v2: > - made commit messages readable without reading the subject line first > - collected David's Reviewed-by tags for patches that haven been > significantly modified since v1 > - added handling of spurious interrupts in cp-intc > - added comments explaining the irq handlers (C versions translated from > assembly) > - dropped the patches removing the hardware interrupt numbers from > the priority tables > - don't remove irqs.h, make it a local header instead > - rearranged the patches in order not to remove the code added > by earlier ones > - renamed d*_init_irqs to d*_init_irq to fit the name of the relevant > callback in machine info struct > - fixed license identifiers where needed > - added comments to config structures for irqchip drivers > - fixed all off-by-one errors in resource sizes > - clarified the comments on the weird handling of IRQ_TINT1_TINT34 as level > irq and added missing calls to irq_set_handler() to dm3* SoCs > - fixed one function that was missing a correct prefix in cp_intc > - return value variables should be called ret not rv > - added a patch converting calls to _raw_readl/writel() to their _relaxed > counterparts > - fixed the commit message prefix in patches that belong to the irqchip > subsystem > - other minor tweaks > I'm terribly sorry for spamming - I had messed up two e-mail addresses. Best regards, Bartosz Golaszewski > Bartosz Golaszewski (33): > ARM: davinci: remove intc_host_map from davinci_soc_info struct > ARM: davinci: aintc: use irq domain > ARM: davinci: select GENERIC_IRQ_MULTI_HANDLER > ARM: davinci: remove davinci_intc_type > ARM: davinci: pull davinci_intc_base into the respective intc drivers > ARM: davinci: wrap HW interrupt numbers with a macro > ARM: davinci: select SPARSE_IRQ > ARM: davinci: make irqs.h a local header > ARM: davinci: aintc: drop GPL license boilerplate > ARM: davinci: aintc: wrap davinci_irq_init() with a helper > ARM: davinci: aintc: use a common prefix for symbols in the driver > ARM: davinci: aintc: drop the 00 prefix from register offsets > ARM: davinci: aintc: use readl/writel_relaxed() > irqchip: davinci-aintc: add a new config structure > ARM: davinci: aintc: use the new irqchip config structure in dm* SoCs > ARM: davinci: aintc: use the new config structure > ARM: davinci: aintc: move timer-specific irq_set_handler() out of > irq.c > ARM: davinci: aintc: remove unnecessary includes > irqchip: davinci-aintc: move the driver to drivers/irqchip > ARM: davinci: cp-intc: remove cp_intc.h > ARM: davinci: cp-intc: add a wrapper around cp_intc_init() > irqchip: davinci-cp-intc: add a new config structure > ARM: davinci: cp-intc: add the new config structures for da8xx SoCs > ARM: davinci: cp-intc: use a common prefix for all symbols > ARM: davinci: cp-intc: convert all hex numbers to lowercase > ARM: davinci: cp-intc: use the new-style config structure > ARM: davinci: cp-intc: improve coding style > ARM: davinci: cp-intc: unify error handling > ARM: davinci: cp-intc: use readl/writel_relaxed() > ARM: davinci: cp-intc: drop GPL license boilerplate > ARM: davinci: cp-intc: remove redundant comments > irqchip: davinci-cp-intc: move the driver to drivers/irqchip > ARM: davinci: remove intc related fields from davinci_soc_info > > arch/arm/Kconfig | 2 + > arch/arm/mach-davinci/Kconfig | 19 +- > arch/arm/mach-davinci/Makefile | 3 - > arch/arm/mach-davinci/asp.h | 8 +- > arch/arm/mach-davinci/board-da830-evm.c | 5 +- > arch/arm/mach-davinci/board-da850-evm.c | 5 +- > arch/arm/mach-davinci/board-dm355-evm.c | 2 +- > arch/arm/mach-davinci/board-dm355-leopard.c | 2 +- > arch/arm/mach-davinci/board-dm365-evm.c | 2 +- > arch/arm/mach-davinci/board-dm644x-evm.c | 8 +- > arch/arm/mach-davinci/board-dm646x-evm.c | 7 +- > arch/arm/mach-davinci/board-mityomapl138.c | 3 +- > arch/arm/mach-davinci/board-neuros-osd2.c | 2 +- > arch/arm/mach-davinci/board-omapl138-hawk.c | 3 +- > arch/arm/mach-davinci/board-sffsdr.c | 2 +- > arch/arm/mach-davinci/common.c | 3 - > arch/arm/mach-davinci/cp_intc.c | 215 ---------------- > arch/arm/mach-davinci/cp_intc.h | 57 ----- > arch/arm/mach-davinci/da830.c | 128 ++-------- > arch/arm/mach-davinci/da850.c | 154 +++--------- > arch/arm/mach-davinci/davinci.h | 4 + > arch/arm/mach-davinci/devices-da8xx.c | 147 +++++------ > arch/arm/mach-davinci/devices.c | 40 +-- > arch/arm/mach-davinci/dm355.c | 86 ++++--- > arch/arm/mach-davinci/dm365.c | 110 ++++---- > arch/arm/mach-davinci/dm644x.c | 76 +++--- > arch/arm/mach-davinci/dm646x.c | 90 ++++--- > arch/arm/mach-davinci/include/mach/common.h | 14 +- > arch/arm/mach-davinci/include/mach/da8xx.h | 2 + > .../mach-davinci/include/mach/entry-macro.S | 39 --- > arch/arm/mach-davinci/irq.c | 117 --------- > .../mach-davinci/{include/mach => }/irqs.h | 4 - > arch/arm/mach-davinci/usb-da8xx.c | 9 +- > arch/arm/mach-davinci/usb.c | 14 +- > drivers/irqchip/Kconfig | 10 + > drivers/irqchip/Makefile | 2 + > drivers/irqchip/irq-davinci-aintc.c | 144 +++++++++++ > drivers/irqchip/irq-davinci-cp-intc.c | 238 ++++++++++++++++++ > include/linux/irqchip/irq-davinci-aintc.h | 27 ++ > include/linux/irqchip/irq-davinci-cp-intc.h | 25 ++ > 40 files changed, 872 insertions(+), 956 deletions(-) > delete mode 100644 arch/arm/mach-davinci/cp_intc.c > delete mode 100644 arch/arm/mach-davinci/cp_intc.h > delete mode 100644 arch/arm/mach-davinci/include/mach/entry-macro.S > delete mode 100644 arch/arm/mach-davinci/irq.c > rename arch/arm/mach-davinci/{include/mach => }/irqs.h (98%) > create mode 100644 drivers/irqchip/irq-davinci-aintc.c > create mode 100644 drivers/irqchip/irq-davinci-cp-intc.c > create mode 100644 include/linux/irqchip/irq-davinci-aintc.h > create mode 100644 include/linux/irqchip/irq-davinci-cp-intc.h > > -- > 2.20.1 >
+ Jason, Marc Thomas, Jason, Marc, On 08/02/19 11:04 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > This series ports the davinci platform to using SPARSE_IRQ, cleans up > the irqchip drivers and moves them over to drivers/irqchip. > > The series can be logically split into four parts. The first (1-8) aims > at introducing support for SPARSE_IRQ. It contains a couple changes > required for that functionality and the final patch actually selecting > it. > > Second part (9-19) makes the aintc driver suitable for drivers/irqchip > and eventually moves it over there. > > Part 3 (20-32) does the same for the cp-intc driver. > > Last patch removes unnecessary code. > > The series has been tested on da850-lcdk (for cp-intc) and > dm365-evm (for aintc). With your ack, I would like to try get it merged to v5.1 via ARM SoC tree. Bartosz, I noticed that Jason and Marc were not originally CCed. You may have to resend if they don't have the series in their inbox. Thanks, Sekhar
pon., 11 lut 2019 o 12:54 Sekhar Nori <nsekhar@ti.com> napisał(a): > > + Jason, Marc > > Thomas, Jason, Marc, > > On 08/02/19 11:04 PM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > This series ports the davinci platform to using SPARSE_IRQ, cleans up > > the irqchip drivers and moves them over to drivers/irqchip. > > > > The series can be logically split into four parts. The first (1-8) aims > > at introducing support for SPARSE_IRQ. It contains a couple changes > > required for that functionality and the final patch actually selecting > > it. > > > > Second part (9-19) makes the aintc driver suitable for drivers/irqchip > > and eventually moves it over there. > > > > Part 3 (20-32) does the same for the cp-intc driver. > > > > Last patch removes unnecessary code. > > > > The series has been tested on da850-lcdk (for cp-intc) and > > dm365-evm (for aintc). > > With your ack, I would like to try get it merged to v5.1 via ARM SoC tree. > > Bartosz, I noticed that Jason and Marc were not originally CCed. You may > have to resend if they don't have the series in their inbox. > > Thanks, > Sekhar Sorry for that, I'm not sure how this happened, since they do pop up in get_maintainer.pl output for that series. I'll resend it. Bart
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> This series ports the davinci platform to using SPARSE_IRQ, cleans up the irqchip drivers and moves them over to drivers/irqchip. The series can be logically split into four parts. The first (1-8) aims at introducing support for SPARSE_IRQ. It contains a couple changes required for that functionality and the final patch actually selecting it. Second part (9-19) makes the aintc driver suitable for drivers/irqchip and eventually moves it over there. Part 3 (20-32) does the same for the cp-intc driver. Last patch removes unnecessary code. The series has been tested on da850-lcdk (for cp-intc) and dm365-evm (for aintc). v1 -> v2: - made commit messages readable without reading the subject line first - collected David's Reviewed-by tags for patches that haven been significantly modified since v1 - added handling of spurious interrupts in cp-intc - added comments explaining the irq handlers (C versions translated from assembly) - dropped the patches removing the hardware interrupt numbers from the priority tables - don't remove irqs.h, make it a local header instead - rearranged the patches in order not to remove the code added by earlier ones - renamed d*_init_irqs to d*_init_irq to fit the name of the relevant callback in machine info struct - fixed license identifiers where needed - added comments to config structures for irqchip drivers - fixed all off-by-one errors in resource sizes - clarified the comments on the weird handling of IRQ_TINT1_TINT34 as level irq and added missing calls to irq_set_handler() to dm3* SoCs - fixed one function that was missing a correct prefix in cp_intc - return value variables should be called ret not rv - added a patch converting calls to _raw_readl/writel() to their _relaxed counterparts - fixed the commit message prefix in patches that belong to the irqchip subsystem - other minor tweaks Bartosz Golaszewski (33): ARM: davinci: remove intc_host_map from davinci_soc_info struct ARM: davinci: aintc: use irq domain ARM: davinci: select GENERIC_IRQ_MULTI_HANDLER ARM: davinci: remove davinci_intc_type ARM: davinci: pull davinci_intc_base into the respective intc drivers ARM: davinci: wrap HW interrupt numbers with a macro ARM: davinci: select SPARSE_IRQ ARM: davinci: make irqs.h a local header ARM: davinci: aintc: drop GPL license boilerplate ARM: davinci: aintc: wrap davinci_irq_init() with a helper ARM: davinci: aintc: use a common prefix for symbols in the driver ARM: davinci: aintc: drop the 00 prefix from register offsets ARM: davinci: aintc: use readl/writel_relaxed() irqchip: davinci-aintc: add a new config structure ARM: davinci: aintc: use the new irqchip config structure in dm* SoCs ARM: davinci: aintc: use the new config structure ARM: davinci: aintc: move timer-specific irq_set_handler() out of irq.c ARM: davinci: aintc: remove unnecessary includes irqchip: davinci-aintc: move the driver to drivers/irqchip ARM: davinci: cp-intc: remove cp_intc.h ARM: davinci: cp-intc: add a wrapper around cp_intc_init() irqchip: davinci-cp-intc: add a new config structure ARM: davinci: cp-intc: add the new config structures for da8xx SoCs ARM: davinci: cp-intc: use a common prefix for all symbols ARM: davinci: cp-intc: convert all hex numbers to lowercase ARM: davinci: cp-intc: use the new-style config structure ARM: davinci: cp-intc: improve coding style ARM: davinci: cp-intc: unify error handling ARM: davinci: cp-intc: use readl/writel_relaxed() ARM: davinci: cp-intc: drop GPL license boilerplate ARM: davinci: cp-intc: remove redundant comments irqchip: davinci-cp-intc: move the driver to drivers/irqchip ARM: davinci: remove intc related fields from davinci_soc_info arch/arm/Kconfig | 2 + arch/arm/mach-davinci/Kconfig | 19 +- arch/arm/mach-davinci/Makefile | 3 - arch/arm/mach-davinci/asp.h | 8 +- arch/arm/mach-davinci/board-da830-evm.c | 5 +- arch/arm/mach-davinci/board-da850-evm.c | 5 +- arch/arm/mach-davinci/board-dm355-evm.c | 2 +- arch/arm/mach-davinci/board-dm355-leopard.c | 2 +- arch/arm/mach-davinci/board-dm365-evm.c | 2 +- arch/arm/mach-davinci/board-dm644x-evm.c | 8 +- arch/arm/mach-davinci/board-dm646x-evm.c | 7 +- arch/arm/mach-davinci/board-mityomapl138.c | 3 +- arch/arm/mach-davinci/board-neuros-osd2.c | 2 +- arch/arm/mach-davinci/board-omapl138-hawk.c | 3 +- arch/arm/mach-davinci/board-sffsdr.c | 2 +- arch/arm/mach-davinci/common.c | 3 - arch/arm/mach-davinci/cp_intc.c | 215 ---------------- arch/arm/mach-davinci/cp_intc.h | 57 ----- arch/arm/mach-davinci/da830.c | 128 ++-------- arch/arm/mach-davinci/da850.c | 154 +++--------- arch/arm/mach-davinci/davinci.h | 4 + arch/arm/mach-davinci/devices-da8xx.c | 147 +++++------ arch/arm/mach-davinci/devices.c | 40 +-- arch/arm/mach-davinci/dm355.c | 86 ++++--- arch/arm/mach-davinci/dm365.c | 110 ++++---- arch/arm/mach-davinci/dm644x.c | 76 +++--- arch/arm/mach-davinci/dm646x.c | 90 ++++--- arch/arm/mach-davinci/include/mach/common.h | 14 +- arch/arm/mach-davinci/include/mach/da8xx.h | 2 + .../mach-davinci/include/mach/entry-macro.S | 39 --- arch/arm/mach-davinci/irq.c | 117 --------- .../mach-davinci/{include/mach => }/irqs.h | 4 - arch/arm/mach-davinci/usb-da8xx.c | 9 +- arch/arm/mach-davinci/usb.c | 14 +- drivers/irqchip/Kconfig | 10 + drivers/irqchip/Makefile | 2 + drivers/irqchip/irq-davinci-aintc.c | 144 +++++++++++ drivers/irqchip/irq-davinci-cp-intc.c | 238 ++++++++++++++++++ include/linux/irqchip/irq-davinci-aintc.h | 27 ++ include/linux/irqchip/irq-davinci-cp-intc.h | 25 ++ 40 files changed, 872 insertions(+), 956 deletions(-) delete mode 100644 arch/arm/mach-davinci/cp_intc.c delete mode 100644 arch/arm/mach-davinci/cp_intc.h delete mode 100644 arch/arm/mach-davinci/include/mach/entry-macro.S delete mode 100644 arch/arm/mach-davinci/irq.c rename arch/arm/mach-davinci/{include/mach => }/irqs.h (98%) create mode 100644 drivers/irqchip/irq-davinci-aintc.c create mode 100644 drivers/irqchip/irq-davinci-cp-intc.c create mode 100644 include/linux/irqchip/irq-davinci-aintc.h create mode 100644 include/linux/irqchip/irq-davinci-cp-intc.h