diff mbox series

[v2,1/5] btrfs: fix comment its device list mutex not volume lock

Message ID 1549611577-15478-1-git-send-email-anand.jain@oracle.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/5] btrfs: fix comment its device list mutex not volume lock | expand

Commit Message

Anand Jain Feb. 8, 2019, 7:39 a.m. UTC
We have killed volume mutex (commit: dccdb07bc996
btrfs: kill btrfs_fs_info::volume_mutex). This a trival one seems to have
escaped.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v2: Delete the wrong comment instead of fixing it.

 fs/btrfs/volumes.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Sterba Feb. 11, 2019, 6:41 p.m. UTC | #1
On Fri, Feb 08, 2019 at 03:39:37PM +0800, Anand Jain wrote:
> We have killed volume mutex (commit: dccdb07bc996
> btrfs: kill btrfs_fs_info::volume_mutex). This a trival one seems to have
> escaped.
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v2: Delete the wrong comment instead of fixing it.

This patch has been added to misc-next, thanks.
diff mbox series

Patch

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index fe122e6099ae..03f223aa7194 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1129,7 +1129,6 @@  static struct btrfs_fs_devices *clone_fs_devices(struct btrfs_fs_devices *orig)
 	mutex_lock(&orig->device_list_mutex);
 	fs_devices->total_devices = orig->total_devices;
 
-	/* We have held the volume lock, it is safe to get the devices. */
 	list_for_each_entry(orig_dev, &orig->devices, dev_list) {
 		struct rcu_string *name;