| Message ID | 20190212112233.25667-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e8ac9389f0d7c74fd988a5ce77765588f74dacd2 |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [next] RDMA: fix allocation failure on pointer pd | expand |
On Tue, Feb 12, 2019 at 11:22:33AM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The null check on an allocation failure on pd is currently checking > if pd is non-null rather than null. Fix this by adding the missing ! > operator. > > Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks a lot, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Tue, Feb 12, 2019 at 11:22:33AM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The null check on an allocation failure on pd is currently checking > if pd is non-null rather than null. Fix this by adding the missing ! > operator. > > Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks applied to for-next Regards, Jason
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c index a18b88c95995..77c3678f4829 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c @@ -745,7 +745,7 @@ static int hns_roce_v1_rsv_lp_qp(struct hns_roce_dev *hr_dev) ibdev = &hr_dev->ib_dev; pd = rdma_zalloc_drv_obj(ibdev, ib_pd); - if (pd) + if (!pd) goto alloc_mem_failed; pd->device = ibdev;