| Message ID | 20190213183153.23746-1-samuel.thibault@ens-lyon.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190213183153.23746-1-samuel.thibault@ens-lyon.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/2] Fix slirp on windows
Type: series
Message-id: 20190213183153.23746-1-samuel.thibault@ens-lyon.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190213183153.23746-1-samuel.thibault@ens-lyon.org -> patchew/20190213183153.23746-1-samuel.thibault@ens-lyon.org
Switched to a new branch 'test'
6513675ca4 slirp: wrap the remaining socket functions
aca75146a1 slirp: remove slirp_ prefix for socket wrappers
=== OUTPUT BEGIN ===
1/2 Checking commit aca75146a1b5 (slirp: remove slirp_ prefix for socket wrappers)
ERROR: code indent should never use tabs
#116: FILE: slirp/socket.c:188:
+^Inn = recv(so->s, iov[0].iov_base, iov[0].iov_len,0);$
ERROR: space required after that ',' (ctx:VxV)
#116: FILE: slirp/socket.c:188:
+ nn = recv(so->s, iov[0].iov_base, iov[0].iov_len,0);
^
ERROR: code indent should never use tabs
#125: FILE: slirp/socket.c:204:
+^I^I^I^I^Igetsockopt(so->s, SOL_SOCKET, SO_ERROR,$
ERROR: space required after that ',' (ctx:VxV)
#134: FILE: slirp/socket.c:234:
+ ret = recv(so->s, iov[1].iov_base, iov[1].iov_len,0);
^
ERROR: code indent should never use tabs
#143: FILE: slirp/socket.c:555:
+^I ioctlsocket(so->s, FIONREAD, &n);$
ERROR: code indent should never use tabs
#161: FILE: slirp/socket.c:738:
+^Isetsockopt(s, SOL_SOCKET, SO_OOBINLINE, &opt, sizeof(int));$
ERROR: code indent should never use tabs
#164: FILE: slirp/socket.c:740:
+^Isetsockopt(s, IPPROTO_TCP, TCP_NODELAY, &opt, sizeof(int));$
ERROR: code indent should never use tabs
#177: FILE: slirp/tcp_subr.c:340:
+^Iclosesocket(so->s);$
ERROR: code indent should never use tabs
#220: FILE: slirp/udp.c:295:
+^Iclosesocket(so->s);$
total: 9 errors, 0 warnings, 212 lines checked
Patch 1/2 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/2 Checking commit 6513675ca470 (slirp: wrap the remaining socket functions)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190213183153.23746-1-samuel.thibault@ens-lyon.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Wed, 13 Feb 2019 at 18:31, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > > The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-02-12 10:53:37 +0000) > > are available in the Git repository at: > > https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault > > for you to fetch changes up to adf1add2927c7bb652a168f5be627102921cf35f: > > slirp: wrap the remaining socket functions (2019-02-12 20:49:13 +0100) > > ---------------------------------------------------------------- > Fix slirp on windows > > Marc-André Lureau (2): > slirp: remove slirp_ prefix for socket wrappers > slirp: wrap the remaining socket functions > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM
The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-02-12 10:53:37 +0000) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to adf1add2927c7bb652a168f5be627102921cf35f: slirp: wrap the remaining socket functions (2019-02-12 20:49:13 +0100) ---------------------------------------------------------------- Fix slirp on windows Marc-André Lureau (2): slirp: remove slirp_ prefix for socket wrappers slirp: wrap the remaining socket functions ---------------------------------------------------------------- Marc-André Lureau (2): slirp: remove slirp_ prefix for socket wrappers slirp: wrap the remaining socket functions slirp/ip_icmp.c | 4 +- slirp/misc.c | 14 ++--- slirp/slirp.c | 2 +- slirp/socket.c | 14 ++--- slirp/tcp_subr.c | 10 ++-- slirp/udp.c | 2 +- slirp/util.c | 164 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- slirp/util.h | 75 ++++++++++++++++++++----- 8 files changed, 246 insertions(+), 39 deletions(-)