| Message ID | 20190130000653.16267-1-richardw.yang@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Trivial cleanup in hw/acpi | expand |
On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >There are several functions/variable which are not used anymore. > >This serials just remove those without functional change. > >v3: add ack and repost in a new thread >v2: change commit log from "is now used in no place" to "in not used anymore" Michael, Looks this serials is not merged yet. Is there any problem I need to fix? > >Wei Yang (3): > hw/i386/pc.c: remove unused function pc_acpi_init() > hw/acpi: remove unused function acpi_table_add_builtin() > hw/acpi: remove unnecessary variable acpi_table_builtin > > hw/acpi/core.c | 10 +--------- > hw/i386/pc.c | 27 --------------------------- > include/hw/acpi/acpi.h | 1 - > include/hw/i386/pc.h | 1 - > 4 files changed, 1 insertion(+), 38 deletions(-) > >-- >2.19.1
On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: > On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: > >There are several functions/variable which are not used anymore. > > > >This serials just remove those without functional change. > > > >v3: add ack and repost in a new thread > >v2: change commit log from "is now used in no place" to "in not used anymore" > > Michael, > > Looks this serials is not merged yet. > > Is there any problem I need to fix? Yes pls repost with fixed reviewed-by tags. > > > >Wei Yang (3): > > hw/i386/pc.c: remove unused function pc_acpi_init() > > hw/acpi: remove unused function acpi_table_add_builtin() > > hw/acpi: remove unnecessary variable acpi_table_builtin > > > > hw/acpi/core.c | 10 +--------- > > hw/i386/pc.c | 27 --------------------------- > > include/hw/acpi/acpi.h | 1 - > > include/hw/i386/pc.h | 1 - > > 4 files changed, 1 insertion(+), 38 deletions(-) > > > >-- > >2.19.1 > > -- > Wei Yang > Help you, Help me
On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote: >On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >> >There are several functions/variable which are not used anymore. >> > >> >This serials just remove those without functional change. >> > >> >v3: add ack and repost in a new thread >> >v2: change commit log from "is now used in no place" to "in not used anymore" >> >> Michael, >> >> Looks this serials is not merged yet. >> >> Is there any problem I need to fix? > >Yes pls repost with fixed reviewed-by tags. > I tried to use git-sendemail to send those patches again. The character 茅 looks good in patch file, while after git-sendemail this is changed. My encoding property in mail is : MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Looks the same as Philippe's. Any hint on how to send out a correct character with git-sendemail? > >> > >> >Wei Yang (3): >> > hw/i386/pc.c: remove unused function pc_acpi_init() >> > hw/acpi: remove unused function acpi_table_add_builtin() >> > hw/acpi: remove unnecessary variable acpi_table_builtin >> > >> > hw/acpi/core.c | 10 +--------- >> > hw/i386/pc.c | 27 --------------------------- >> > include/hw/acpi/acpi.h | 1 - >> > include/hw/i386/pc.h | 1 - >> > 4 files changed, 1 insertion(+), 38 deletions(-) >> > >> >-- >> >2.19.1 >> >> -- >> Wei Yang >> Help you, Help me
Hi Wei, On 2/13/19 7:26 AM, Wei Yang wrote: > On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote: >> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>> There are several functions/variable which are not used anymore. >>>> >>>> This serials just remove those without functional change. >>>> >>>> v3: add ack and repost in a new thread >>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>> >>> Michael, >>> >>> Looks this serials is not merged yet. >>> >>> Is there any problem I need to fix? >> >> Yes pls repost with fixed reviewed-by tags. >> > > I tried to use git-sendemail to send those patches again. > > The character 茅 looks good in patch file, while after git-sendemail this is > changed. > > My encoding property in mail is : > > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Language: en-US > Content-Transfer-Encoding: 8bit I'm not sure but you can try: Content-Transfer-Encoding: base64 > > Looks the same as Philippe's. > > Any hint on how to send out a correct character with git-sendemail? If it doesn't work, then use my ASCII-reduced lastname, I can live with that: "Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>" Thanks for trying, Phil. > >> >>>> >>>> Wei Yang (3): >>>> hw/i386/pc.c: remove unused function pc_acpi_init() >>>> hw/acpi: remove unused function acpi_table_add_builtin() >>>> hw/acpi: remove unnecessary variable acpi_table_builtin >>>> >>>> hw/acpi/core.c | 10 +--------- >>>> hw/i386/pc.c | 27 --------------------------- >>>> include/hw/acpi/acpi.h | 1 - >>>> include/hw/i386/pc.h | 1 - >>>> 4 files changed, 1 insertion(+), 38 deletions(-)
On Wed, Feb 13, 2019 at 07:32:23AM +0100, Philippe Mathieu-Daudé wrote: >Hi Wei, > >On 2/13/19 7:26 AM, Wei Yang wrote: >> On Tue, Feb 12, 2019 at 12:34:31AM -0500, Michael S. Tsirkin wrote: >>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>> There are several functions/variable which are not used anymore. >>>>> >>>>> This serials just remove those without functional change. >>>>> >>>>> v3: add ack and repost in a new thread >>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>> >>>> Michael, >>>> >>>> Looks this serials is not merged yet. >>>> >>>> Is there any problem I need to fix? >>> >>> Yes pls repost with fixed reviewed-by tags. >>> >> >> I tried to use git-sendemail to send those patches again. >> >> The character 茅 looks good in patch file, while after git-sendemail this is >> changed. >> >> My encoding property in mail is : >> >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Language: en-US >> Content-Transfer-Encoding: 8bit > >I'm not sure but you can try: > > Content-Transfer-Encoding: base64 > Looks not work. git send-email will detect the file's encoding is 8bit, so manually change to base64 doesn't work. >> >> Looks the same as Philippe's. >> >> Any hint on how to send out a correct character with git-sendemail? > >If it doesn't work, then use my ASCII-reduced lastname, I can live with >that: > >"Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>" > >Thanks for trying, Thanks :-) Let's wait a while to see whether someone else has an idea on that. > >Phil. > >> >>> >>>>> >>>>> Wei Yang (3): >>>>> hw/i386/pc.c: remove unused function pc_acpi_init() >>>>> hw/acpi: remove unused function acpi_table_add_builtin() >>>>> hw/acpi: remove unnecessary variable acpi_table_builtin >>>>> >>>>> hw/acpi/core.c | 10 +--------- >>>>> hw/i386/pc.c | 27 --------------------------- >>>>> include/hw/acpi/acpi.h | 1 - >>>>> include/hw/i386/pc.h | 1 - >>>>> 4 files changed, 1 insertion(+), 38 deletions(-)
On 12/02/2019 06:34, Michael S. Tsirkin wrote: > On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>> There are several functions/variable which are not used anymore. >>> >>> This serials just remove those without functional change. >>> >>> v3: add ack and repost in a new thread >>> v2: change commit log from "is now used in no place" to "in not used anymore" >> >> Michael, >> >> Looks this serials is not merged yet. >> >> Is there any problem I need to fix? > > Yes pls repost with fixed reviewed-by tags. Or I can take the series through the trivial branch and update manually Philippe's lastname? Laurent
On Wed, Feb 13, 2019 at 09:49:01AM +0100, Laurent Vivier wrote: >On 12/02/2019 06:34, Michael S. Tsirkin wrote: >> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>> There are several functions/variable which are not used anymore. >>>> >>>> This serials just remove those without functional change. >>>> >>>> v3: add ack and repost in a new thread >>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>> >>> Michael, >>> >>> Looks this serials is not merged yet. >>> >>> Is there any problem I need to fix? >> >> Yes pls repost with fixed reviewed-by tags. > >Or I can take the series through the trivial branch and update manually >Philippe's lastname? > Thanks :-) Let's see Michael's opinion. >Laurent
Hi Laurent, On 2/13/19 9:49 AM, Laurent Vivier wrote: > On 12/02/2019 06:34, Michael S. Tsirkin wrote: >> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>> There are several functions/variable which are not used anymore. >>>> >>>> This serials just remove those without functional change. >>>> >>>> v3: add ack and repost in a new thread >>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>> >>> Michael, >>> >>> Looks this serials is not merged yet. >>> >>> Is there any problem I need to fix? >> >> Yes pls repost with fixed reviewed-by tags. > > Or I can take the series through the trivial branch and update manually > Philippe's lastname? I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags). I'd rather prefer we find a proper configuration setup to help the community. Another (fair) approach is to forbid non-ASCII chars in all part of patches. Regards, Phil.
On Wed, Feb 13, 2019 at 09:56:38AM +0100, Philippe Mathieu-Daudé wrote: >Hi Laurent, > >On 2/13/19 9:49 AM, Laurent Vivier wrote: >> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>> There are several functions/variable which are not used anymore. >>>>> >>>>> This serials just remove those without functional change. >>>>> >>>>> v3: add ack and repost in a new thread >>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>> >>>> Michael, >>>> >>>> Looks this serials is not merged yet. >>>> >>>> Is there any problem I need to fix? >>> >>> Yes pls repost with fixed reviewed-by tags. >> >> Or I can take the series through the trivial branch and update manually >> Philippe's lastname? > >I appreciate the help with manual update, however Wei is not the only >one having this problem (other developpers has non-ASCII in their name, >and use such tags). >I'd rather prefer we find a proper configuration setup to help the >community. > How you configure your git send-email? or related facility? >Another (fair) approach is to forbid non-ASCII chars in all part of patches. > >Regards, > >Phil.
On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: > Hi Laurent, > > On 2/13/19 9:49 AM, Laurent Vivier wrote: >> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>> There are several functions/variable which are not used anymore. >>>>> >>>>> This serials just remove those without functional change. >>>>> >>>>> v3: add ack and repost in a new thread >>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>> >>>> Michael, >>>> >>>> Looks this serials is not merged yet. >>>> >>>> Is there any problem I need to fix? >>> >>> Yes pls repost with fixed reviewed-by tags. >> >> Or I can take the series through the trivial branch and update manually >> Philippe's lastname? > > I appreciate the help with manual update, however Wei is not the only > one having this problem (other developpers has non-ASCII in their name, > and use such tags). > I'd rather prefer we find a proper configuration setup to help the > community. I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail. I think the following tags should cover Latin and Chinese characters: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks, Laurent
On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >> Hi Laurent, >> >> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>> There are several functions/variable which are not used anymore. >>>>>> >>>>>> This serials just remove those without functional change. >>>>>> >>>>>> v3: add ack and repost in a new thread >>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>> >>>>> Michael, >>>>> >>>>> Looks this serials is not merged yet. >>>>> >>>>> Is there any problem I need to fix? >>>> >>>> Yes pls repost with fixed reviewed-by tags. >>> >>> Or I can take the series through the trivial branch and update manually >>> Philippe's lastname? >> >> I appreciate the help with manual update, however Wei is not the only >> one having this problem (other developpers has non-ASCII in their name, >> and use such tags). >> I'd rather prefer we find a proper configuration setup to help the >> community. > >I'm wondering if it can be a problem with cut'n'paste rather than with >git-sendemail. > >I think the following tags should cover Latin and Chinese characters: > >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > Looks not work. I have tried this and also with Content-Language: en-US The character would be modified after git send-email. >Thanks, >Laurent
On 14/02/2019 01:03, Wei Yang wrote: > On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >>> Hi Laurent, >>> >>> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>>> There are several functions/variable which are not used anymore. >>>>>>> >>>>>>> This serials just remove those without functional change. >>>>>>> >>>>>>> v3: add ack and repost in a new thread >>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>>> >>>>>> Michael, >>>>>> >>>>>> Looks this serials is not merged yet. >>>>>> >>>>>> Is there any problem I need to fix? >>>>> >>>>> Yes pls repost with fixed reviewed-by tags. >>>> >>>> Or I can take the series through the trivial branch and update manually >>>> Philippe's lastname? >>> >>> I appreciate the help with manual update, however Wei is not the only >>> one having this problem (other developpers has non-ASCII in their name, >>> and use such tags). >>> I'd rather prefer we find a proper configuration setup to help the >>> community. >> >> I'm wondering if it can be a problem with cut'n'paste rather than with >> git-sendemail. >> >> I think the following tags should cover Latin and Chinese characters: >> >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> > > Looks not work. > > I have tried this and also with > > Content-Language: en-US Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email? Thansk, Laurent
On 14/02/2019 08:57, Laurent Vivier wrote: > On 14/02/2019 01:03, Wei Yang wrote: >> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >>>> Hi Laurent, >>>> >>>> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>>>> There are several functions/variable which are not used anymore. >>>>>>>> >>>>>>>> This serials just remove those without functional change. >>>>>>>> >>>>>>>> v3: add ack and repost in a new thread >>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>>>> >>>>>>> Michael, >>>>>>> >>>>>>> Looks this serials is not merged yet. >>>>>>> >>>>>>> Is there any problem I need to fix? >>>>>> >>>>>> Yes pls repost with fixed reviewed-by tags. >>>>> >>>>> Or I can take the series through the trivial branch and update manually >>>>> Philippe's lastname? >>>> >>>> I appreciate the help with manual update, however Wei is not the only >>>> one having this problem (other developpers has non-ASCII in their name, >>>> and use such tags). >>>> I'd rather prefer we find a proper configuration setup to help the >>>> community. >>> >>> I'm wondering if it can be a problem with cut'n'paste rather than with >>> git-sendemail. >>> >>> I think the following tags should cover Latin and Chinese characters: >>> >>> Content-Type: text/plain; charset=UTF-8 >>> Content-Transfer-Encoding: 8bit >>> >> >> Looks not work. >> >> I have tried this and also with >> >> Content-Language: en-US > > Could you send me a gzipped version of the 0001-XXX.patch in attachment > so I could see the real content before git-send-email? OK, I've got it. What I see is it is already corrupted, thus the problem is not with git-send-email. So either it is corrupted by git-format-patch (which is very unlikely, we could see that if you push it to a public git repo) or it has been corrupted when you have added it to the commit message. Thanks, Laurent
On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote: >On 14/02/2019 08:57, Laurent Vivier wrote: >> On 14/02/2019 01:03, Wei Yang wrote: >>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >>>>> Hi Laurent, >>>>> >>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>>>>> There are several functions/variable which are not used anymore. >>>>>>>>> >>>>>>>>> This serials just remove those without functional change. >>>>>>>>> >>>>>>>>> v3: add ack and repost in a new thread >>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>>>>> >>>>>>>> Michael, >>>>>>>> >>>>>>>> Looks this serials is not merged yet. >>>>>>>> >>>>>>>> Is there any problem I need to fix? >>>>>>> >>>>>>> Yes pls repost with fixed reviewed-by tags. >>>>>> >>>>>> Or I can take the series through the trivial branch and update manually >>>>>> Philippe's lastname? >>>>> >>>>> I appreciate the help with manual update, however Wei is not the only >>>>> one having this problem (other developpers has non-ASCII in their name, >>>>> and use such tags). >>>>> I'd rather prefer we find a proper configuration setup to help the >>>>> community. >>>> >>>> I'm wondering if it can be a problem with cut'n'paste rather than with >>>> git-sendemail. >>>> >>>> I think the following tags should cover Latin and Chinese characters: >>>> >>>> Content-Type: text/plain; charset=UTF-8 >>>> Content-Transfer-Encoding: 8bit >>>> >>> >>> Looks not work. >>> >>> I have tried this and also with >>> >>> Content-Language: en-US >> >> Could you send me a gzipped version of the 0001-XXX.patch in attachment >> so I could see the real content before git-send-email? > >OK, I've got it. > >What I see is it is already corrupted, thus the problem is not with >git-send-email. > >So either it is corrupted by git-format-patch (which is very unlikely, >we could see that if you push it to a public git repo) or it has been >corrupted when you have added it to the commit message. > Hmm... maybe you are right. But I found confused how to fix this. When I use git commit --amend to fix it, the character looks good in my editor. I use vim as my git editor. But when I use git show, it display an unknown character. And if I use git format-patch, the patch file looks good in my vim editor. But corrupted if I use another editor. Do you have any idea on this? >Thanks, >Laurent >
On 14/02/2019 09:18, Wei Yang wrote: > On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote: >> On 14/02/2019 08:57, Laurent Vivier wrote: >>> On 14/02/2019 01:03, Wei Yang wrote: >>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >>>>>> Hi Laurent, >>>>>> >>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>>>>>> There are several functions/variable which are not used anymore. >>>>>>>>>> >>>>>>>>>> This serials just remove those without functional change. >>>>>>>>>> >>>>>>>>>> v3: add ack and repost in a new thread >>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>>>>>> >>>>>>>>> Michael, >>>>>>>>> >>>>>>>>> Looks this serials is not merged yet. >>>>>>>>> >>>>>>>>> Is there any problem I need to fix? >>>>>>>> >>>>>>>> Yes pls repost with fixed reviewed-by tags. >>>>>>> >>>>>>> Or I can take the series through the trivial branch and update manually >>>>>>> Philippe's lastname? >>>>>> >>>>>> I appreciate the help with manual update, however Wei is not the only >>>>>> one having this problem (other developpers has non-ASCII in their name, >>>>>> and use such tags). >>>>>> I'd rather prefer we find a proper configuration setup to help the >>>>>> community. >>>>> >>>>> I'm wondering if it can be a problem with cut'n'paste rather than with >>>>> git-sendemail. >>>>> >>>>> I think the following tags should cover Latin and Chinese characters: >>>>> >>>>> Content-Type: text/plain; charset=UTF-8 >>>>> Content-Transfer-Encoding: 8bit >>>>> >>>> >>>> Looks not work. >>>> >>>> I have tried this and also with >>>> >>>> Content-Language: en-US >>> >>> Could you send me a gzipped version of the 0001-XXX.patch in attachment >>> so I could see the real content before git-send-email? >> >> OK, I've got it. >> >> What I see is it is already corrupted, thus the problem is not with >> git-send-email. >> >> So either it is corrupted by git-format-patch (which is very unlikely, >> we could see that if you push it to a public git repo) or it has been >> corrupted when you have added it to the commit message. >> > > Hmm... maybe you are right. > > But I found confused how to fix this. > > When I use git commit --amend to fix it, the character looks good in my > editor. I use vim as my git editor. > > But when I use git show, it display an unknown character. > > And if I use git format-patch, the patch file looks good in my vim editor. But > corrupted if I use another editor. > > Do you have any idea on this? What is the result of command "locale" in your terminal? How do you copy the characters to vim? Thanks, Laurent
On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote: >On 14/02/2019 09:18, Wei Yang wrote: >> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote: >>> On 14/02/2019 08:57, Laurent Vivier wrote: >>>> On 14/02/2019 01:03, Wei Yang wrote: >>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >>>>>>> Hi Laurent, >>>>>>> >>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>>>>>>> There are several functions/variable which are not used anymore. >>>>>>>>>>> >>>>>>>>>>> This serials just remove those without functional change. >>>>>>>>>>> >>>>>>>>>>> v3: add ack and repost in a new thread >>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>>>>>>> >>>>>>>>>> Michael, >>>>>>>>>> >>>>>>>>>> Looks this serials is not merged yet. >>>>>>>>>> >>>>>>>>>> Is there any problem I need to fix? >>>>>>>>> >>>>>>>>> Yes pls repost with fixed reviewed-by tags. >>>>>>>> >>>>>>>> Or I can take the series through the trivial branch and update manually >>>>>>>> Philippe's lastname? >>>>>>> >>>>>>> I appreciate the help with manual update, however Wei is not the only >>>>>>> one having this problem (other developpers has non-ASCII in their name, >>>>>>> and use such tags). >>>>>>> I'd rather prefer we find a proper configuration setup to help the >>>>>>> community. >>>>>> >>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with >>>>>> git-sendemail. >>>>>> >>>>>> I think the following tags should cover Latin and Chinese characters: >>>>>> >>>>>> Content-Type: text/plain; charset=UTF-8 >>>>>> Content-Transfer-Encoding: 8bit >>>>>> >>>>> >>>>> Looks not work. >>>>> >>>>> I have tried this and also with >>>>> >>>>> Content-Language: en-US >>>> >>>> Could you send me a gzipped version of the 0001-XXX.patch in attachment >>>> so I could see the real content before git-send-email? >>> >>> OK, I've got it. >>> >>> What I see is it is already corrupted, thus the problem is not with >>> git-send-email. >>> >>> So either it is corrupted by git-format-patch (which is very unlikely, >>> we could see that if you push it to a public git repo) or it has been >>> corrupted when you have added it to the commit message. >>> >> >> Hmm... maybe you are right. >> >> But I found confused how to fix this. >> >> When I use git commit --amend to fix it, the character looks good in my >> editor. I use vim as my git editor. >> >> But when I use git show, it display an unknown character. >> >> And if I use git format-patch, the patch file looks good in my vim editor. But >> corrupted if I use another editor. >> >> Do you have any idea on this? > >What is the result of command "locale" in your terminal? >How do you copy the characters to vim? > My locale output: $ locale LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE="en_US.UTF-8" LC_NUMERIC=zh_CN.UTF-8 LC_TIME=zh_CN.UTF-8 LC_COLLATE="en_US.UTF-8" LC_MONETARY=zh_CN.UTF-8 LC_MESSAGES="en_US.UTF-8" LC_PAPER=zh_CN.UTF-8 LC_NAME=zh_CN.UTF-8 LC_ADDRESS=zh_CN.UTF-8 LC_TELEPHONE=zh_CN.UTF-8 LC_MEASUREMENT=zh_CN.UTF-8 LC_IDENTIFICATION=zh_CN.UTF-8 LC_ALL= I copy&paste the character from mutt to vim. Let me see if it would work if I save the character from mutt mail itself. >Thanks, >Laurent
On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote: >On 14/02/2019 09:18, Wei Yang wrote: >> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote: >>> On 14/02/2019 08:57, Laurent Vivier wrote: >>>> On 14/02/2019 01:03, Wei Yang wrote: >>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >>>>>>> Hi Laurent, >>>>>>> >>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>>>>>>> There are several functions/variable which are not used anymore. >>>>>>>>>>> >>>>>>>>>>> This serials just remove those without functional change. >>>>>>>>>>> >>>>>>>>>>> v3: add ack and repost in a new thread >>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>>>>>>> >>>>>>>>>> Michael, >>>>>>>>>> >>>>>>>>>> Looks this serials is not merged yet. >>>>>>>>>> >>>>>>>>>> Is there any problem I need to fix? >>>>>>>>> >>>>>>>>> Yes pls repost with fixed reviewed-by tags. >>>>>>>> >>>>>>>> Or I can take the series through the trivial branch and update manually >>>>>>>> Philippe's lastname? >>>>>>> >>>>>>> I appreciate the help with manual update, however Wei is not the only >>>>>>> one having this problem (other developpers has non-ASCII in their name, >>>>>>> and use such tags). >>>>>>> I'd rather prefer we find a proper configuration setup to help the >>>>>>> community. >>>>>> >>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with >>>>>> git-sendemail. >>>>>> >>>>>> I think the following tags should cover Latin and Chinese characters: >>>>>> >>>>>> Content-Type: text/plain; charset=UTF-8 >>>>>> Content-Transfer-Encoding: 8bit >>>>>> >>>>> >>>>> Looks not work. >>>>> >>>>> I have tried this and also with >>>>> >>>>> Content-Language: en-US >>>> >>>> Could you send me a gzipped version of the 0001-XXX.patch in attachment >>>> so I could see the real content before git-send-email? >>> >>> OK, I've got it. >>> >>> What I see is it is already corrupted, thus the problem is not with >>> git-send-email. >>> >>> So either it is corrupted by git-format-patch (which is very unlikely, >>> we could see that if you push it to a public git repo) or it has been >>> corrupted when you have added it to the commit message. >>> >> >> Hmm... maybe you are right. >> >> But I found confused how to fix this. >> >> When I use git commit --amend to fix it, the character looks good in my >> editor. I use vim as my git editor. >> >> But when I use git show, it display an unknown character. >> >> And if I use git format-patch, the patch file looks good in my vim editor. But >> corrupted if I use another editor. >> >> Do you have any idea on this? > >What is the result of command "locale" in your terminal? >How do you copy the characters to vim? > Hi, Laurent I tried to copied the character directly from Philippe's mail. This time looks good from my mutt client. Hope it works for you. Thanks! >Thanks, >Laurent
On 14/02/2019 09:51, Wei Yang wrote: > On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote: >> On 14/02/2019 09:18, Wei Yang wrote: >>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote: >>>> On 14/02/2019 08:57, Laurent Vivier wrote: >>>>> On 14/02/2019 01:03, Wei Yang wrote: >>>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote: >>>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote: >>>>>>>> Hi Laurent, >>>>>>>> >>>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote: >>>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote: >>>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: >>>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: >>>>>>>>>>>> There are several functions/variable which are not used anymore. >>>>>>>>>>>> >>>>>>>>>>>> This serials just remove those without functional change. >>>>>>>>>>>> >>>>>>>>>>>> v3: add ack and repost in a new thread >>>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not used anymore" >>>>>>>>>>> >>>>>>>>>>> Michael, >>>>>>>>>>> >>>>>>>>>>> Looks this serials is not merged yet. >>>>>>>>>>> >>>>>>>>>>> Is there any problem I need to fix? >>>>>>>>>> >>>>>>>>>> Yes pls repost with fixed reviewed-by tags. >>>>>>>>> >>>>>>>>> Or I can take the series through the trivial branch and update manually >>>>>>>>> Philippe's lastname? >>>>>>>> >>>>>>>> I appreciate the help with manual update, however Wei is not the only >>>>>>>> one having this problem (other developpers has non-ASCII in their name, >>>>>>>> and use such tags). >>>>>>>> I'd rather prefer we find a proper configuration setup to help the >>>>>>>> community. >>>>>>> >>>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with >>>>>>> git-sendemail. >>>>>>> >>>>>>> I think the following tags should cover Latin and Chinese characters: >>>>>>> >>>>>>> Content-Type: text/plain; charset=UTF-8 >>>>>>> Content-Transfer-Encoding: 8bit >>>>>>> >>>>>> >>>>>> Looks not work. >>>>>> >>>>>> I have tried this and also with >>>>>> >>>>>> Content-Language: en-US >>>>> >>>>> Could you send me a gzipped version of the 0001-XXX.patch in attachment >>>>> so I could see the real content before git-send-email? >>>> >>>> OK, I've got it. >>>> >>>> What I see is it is already corrupted, thus the problem is not with >>>> git-send-email. >>>> >>>> So either it is corrupted by git-format-patch (which is very unlikely, >>>> we could see that if you push it to a public git repo) or it has been >>>> corrupted when you have added it to the commit message. >>>> >>> >>> Hmm... maybe you are right. >>> >>> But I found confused how to fix this. >>> >>> When I use git commit --amend to fix it, the character looks good in my >>> editor. I use vim as my git editor. >>> >>> But when I use git show, it display an unknown character. >>> >>> And if I use git format-patch, the patch file looks good in my vim editor. But >>> corrupted if I use another editor. >>> >>> Do you have any idea on this? >> >> What is the result of command "locale" in your terminal? >> How do you copy the characters to vim? >> > > Hi, Laurent > > I tried to copied the character directly from Philippe's mail. > > This time looks good from my mutt client. Hope it works for you. Yes, it's fine. I let Michael to take the series for the pull request. Thanks, Laurent