| Message ID | 20190213170651.3210-3-Akash_Gajjar@mentor.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: rk3399-rockpro64 dts cleanup | expand |
Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar: > lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no impact, > so removing it. > > Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com> vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around for completenes sake. I've now dropped the regulator portions so that only the lcd-pinmux gets removed and reworded the commit message accordingly and applied the result for 5.1 Thanks Heiko
On 2/15/2019 2:48 PM, Heiko Stübner wrote: > Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar: >> lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no impact, >> so removing it. >> >> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com> Hi Heiko, > vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around > for completenes sake. Emmc module is supplied by PMIC vcc3v3_s3 (SWITCH_REG1) and vcc_1v8 (DCD_REG4). So I believe removing vcc1v8_s3 has no impact on emmc supply line. Thanks, Akash > > I've now dropped the regulator portions so that only the lcd-pinmux > gets removed and reworded the commit message accordingly > and applied the result for 5.1 > > Thanks > Heiko > > >
Am Freitag, 15. Februar 2019, 13:08:16 CET schrieb agajjar: > On 2/15/2019 2:48 PM, Heiko Stübner wrote: > > Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar: > >> lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no > >> impact, > >> so removing it. > >> > >> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com> > > Hi Heiko, > > > vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around > > for completenes sake. > > Emmc module is supplied by PMIC vcc3v3_s3 (SWITCH_REG1) and vcc_1v8 > (DCD_REG4). > > So I believe removing vcc1v8_s3 has no impact on emmc supply line. looking at the rockpro64 schematics page 10, I see vcca1v8_s3 linked to the emmc_vdd_1v8 input and obviously also as reference for the saradc. So I think we really could keep it around, so that the power-tree resembles the schematics more.
On 2/16/2019 2:16 AM, Heiko Stübner wrote: > Am Freitag, 15. Februar 2019, 13:08:16 CET schrieb agajjar: >> On 2/15/2019 2:48 PM, Heiko Stübner wrote: >>> Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar: >>>> lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no >>>> impact, >>>> so removing it. >>>> >>>> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com> >> Hi Heiko, >> >>> vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around >>> for completenes sake. >> Emmc module is supplied by PMIC vcc3v3_s3 (SWITCH_REG1) and vcc_1v8 >> (DCD_REG4). >> >> So I believe removing vcc1v8_s3 has no impact on emmc supply line. > looking at the rockpro64 schematics page 10, I see vcca1v8_s3 linked > to the emmc_vdd_1v8 input and obviously also as reference for the saradc. You are referring Pilot production release (rockpro64_v20-SCH.pdf), please refer Second batch production release (rockpro64_v21-SCH.pdf). both the schematic release is available at http://wiki.pine64.org/index.php/ROCKPro64_Main_Page > > So I think we really could keep it around, so that the power-tree resembles > the schematics more. Thanks, Akash
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts index 49e83ba64045..c9a2b26d7cad 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts @@ -83,17 +83,6 @@ regulator-max-microvolt = <12000000>; }; - /* switched by pmic_sleep */ - vcc1v8_s3: vcca1v8_s3: vcc1v8-s3 { - compatible = "regulator-fixed"; - regulator-name = "vcc1v8_s3"; - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - vin-supply = <&vcc_1v8>; - }; - vcc3v3_pcie: vcc3v3-pcie-regulator { compatible = "regulator-fixed"; enable-active-high; @@ -522,12 +511,6 @@ }; }; - lcd-panel { - lcd_panel_reset: lcd-panel-reset { - rockchip,pins = <4 RK_PD6 RK_FUNC_GPIO &pcfg_pull_up>; - }; - }; - pcie { pcie_pwr_en: pcie-pwr-en { rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; @@ -576,7 +559,7 @@ }; &saradc { - vref-supply = <&vcca1v8_s3>; + vref-supply = <&vcca_1v8>; status = "okay"; };
lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no impact, so removing it. Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com> --- .../boot/dts/rockchip/rk3399-rockpro64.dts | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-)