diff mbox series

[v2,5/5] base: soc: Export soc_device_register/unregister APIs

Message ID 20190220045946.7452-1-vaishali.thakkar@linaro.org (mailing list archive)
State Superseded, archived
Headers show
Series soc: qcom: Add SoC info driver | expand

Commit Message

Vaishali Thakkar Feb. 20, 2019, 4:59 a.m. UTC 
From: Vinod Koul <vkoul@kernel.org>

Qcom Socinfo driver can be built as a module, so
export these two APIs.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Vaishali Thakkar <vaishali.thakkar@linaro.org>
---
Changes since v1:
	- None
---
 drivers/base/soc.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Greg Kroah-Hartman Feb. 20, 2019, 6:55 a.m. UTC | #1 
On Wed, Feb 20, 2019 at 10:29:46AM +0530, Vaishali Thakkar wrote:
> From: Vinod Koul <vkoul@kernel.org>
> 
> Qcom Socinfo driver can be built as a module, so
> export these two APIs.
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@linaro.org>
> ---
> Changes since v1:
> 	- None

This is fixing a build breakage introduced by an earlier patch.  Please
rearange the patches so that breakage never happens.

Also, any chance you can properly "thread" your patches so they all show
up together?  git send-email does this automatically...

thanks,

greg k-h
Vaishali Thakkar Feb. 20, 2019, 8:48 a.m. UTC | #2 
On Wed, 20 Feb 2019 at 12:25, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Feb 20, 2019 at 10:29:46AM +0530, Vaishali Thakkar wrote:
> > From: Vinod Koul <vkoul@kernel.org>
> >
> > Qcom Socinfo driver can be built as a module, so
> > export these two APIs.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Signed-off-by: Vaishali Thakkar <vaishali.thakkar@linaro.org>
> > ---
> > Changes since v1:
> >       - None
>
> This is fixing a build breakage introduced by an earlier patch.  Please
> rearange the patches so that breakage never happens.

Ok, yes. I'll put it as patch two [before adding socinfo driver].

> Also, any chance you can properly "thread" your patches so they all show
> up together?  git send-email does this automatically...

I'm using send-email only but I was sending it one by one. I believe
that's the reason why didn't come as a thread. I'll fix that in next version
too.

> thanks,
>
> greg k-h
diff mbox series

Patch

diff --git a/drivers/base/soc.c b/drivers/base/soc.c
index b0933b9fe67f..7c0c5ca5953d 100644
--- a/drivers/base/soc.c
+++ b/drivers/base/soc.c
@@ -164,6 +164,7 @@  struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr
 out1:
 	return ERR_PTR(ret);
 }
+EXPORT_SYMBOL_GPL(soc_device_register);
 
 /* Ensure soc_dev->attr is freed prior to calling soc_device_unregister. */
 void soc_device_unregister(struct soc_device *soc_dev)
@@ -173,6 +174,7 @@  void soc_device_unregister(struct soc_device *soc_dev)
 	device_unregister(&soc_dev->dev);
 	early_soc_dev_attr = NULL;
 }
+EXPORT_SYMBOL_GPL(soc_device_unregister);
 
 static int __init soc_bus_register(void)
 {