| Message ID | 1550685055-13612-2-git-send-email-mathias.nyman@linux.intel.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4ee925dfe017870340ab26503799376073e54759 |
| Headers | show |
| Series | xhci features for usb-next | expand |
On 20.2.2019 19.50, Mathias Nyman wrote: > From: Jean-Philippe Menil <jpmenil@gmail.com> > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > prototype for xhci_free_virt_devices_depth_first. > > This function is only used in xhci-mem.c so just make it static. > > Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com> My Signed-off-by was apparently lost after I did some patch juggling Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Want me to resend? -Mathias
On Wed, Feb 20, 2019 at 08:01:08PM +0200, Mathias Nyman wrote: > On 20.2.2019 19.50, Mathias Nyman wrote: > > From: Jean-Philippe Menil <jpmenil@gmail.com> > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > prototype for xhci_free_virt_devices_depth_first. > > > > This function is only used in xhci-mem.c so just make it static. > > > > Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com> > > My Signed-off-by was apparently lost after I did some patch juggling > > Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> > > Want me to resend? Nah, I can fix it up when I apply it in the morning. thanks, greg k-h
On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > From: Jean-Philippe Menil <jpmenil@gmail.com> > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > prototype for xhci_free_virt_devices_depth_first. There is no normal "build warning", this is a sparse fixup, right?
On Wed, 20 Feb 2019, Greg KH wrote: > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > > From: Jean-Philippe Menil <jpmenil@gmail.com> > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > prototype for xhci_free_virt_devices_depth_first. > > There is no normal "build warning", this is a sparse fixup, right? > > Hi Greg, this is a build warning, at least with W=1 : drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes] void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int slot_id) Regards, Jean-Philippe
On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote: > On Wed, 20 Feb 2019, Greg KH wrote: > > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > > > From: Jean-Philippe Menil <jpmenil@gmail.com> > > > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > > prototype for xhci_free_virt_devices_depth_first. > > > > There is no normal "build warning", this is a sparse fixup, right? > > > > > > Hi Greg, > > this is a build warning, at least with W=1 : > > drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for > ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes] > void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int > slot_id) "W=1" is not a normal build option for anyone to use, except those that wish to find crazy issues like this :) Also, if that is the only way it shows up, you should mention it in the changelog. thanks, greg k-h
On Thu, 21 Feb 2019, Greg KH wrote: > On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote: > > On Wed, 20 Feb 2019, Greg KH wrote: > > > > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > > > > From: Jean-Philippe Menil <jpmenil@gmail.com> > > > > > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > > > prototype for xhci_free_virt_devices_depth_first. > > > > > > There is no normal "build warning", this is a sparse fixup, right? > > > > > > > > > > Hi Greg, > > > > this is a build warning, at least with W=1 : > > > > drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for > > ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes] > > void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int > > slot_id) > > "W=1" is not a normal build option for anyone to use, except those that > wish to find crazy issues like this :) > > Also, if that is the only way it shows up, you should mention it in the > changelog. > > thanks, > > greg k-h > Hmm, rereaind this mail from kernel-janitors https://marc.info/?l=kernel-janitors&m=154178546220848&w=2 seem that you're right, this is not a normal option :) Mathias, do you want me to re-send something? Regards,
On Thu, Feb 21, 2019 at 10:39:46AM +0100, Jean-Philippe Menil wrote: > On Thu, 21 Feb 2019, Greg KH wrote: > > > On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote: > > > On Wed, 20 Feb 2019, Greg KH wrote: > > > > > > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > > > > > From: Jean-Philippe Menil <jpmenil@gmail.com> > > > > > > > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > > > > prototype for xhci_free_virt_devices_depth_first. > > > > > > > > There is no normal "build warning", this is a sparse fixup, right? > > > > > > > > > > > > > > Hi Greg, > > > > > > this is a build warning, at least with W=1 : > > > > > > drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for > > > ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes] > > > void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int > > > slot_id) > > > > "W=1" is not a normal build option for anyone to use, except those that > > wish to find crazy issues like this :) > > > > Also, if that is the only way it shows up, you should mention it in the > > changelog. > > > > thanks, > > > > greg k-h > > > > Hmm, rereaind this mail from kernel-janitors > https://marc.info/?l=kernel-janitors&m=154178546220848&w=2 > seem that you're right, this is not a normal option :) > > Mathias, do you want me to re-send something? No need, I'll go edit the changelog text... greg k-h
On Thu, 21 Feb 2019, Greg KH wrote: > On Thu, Feb 21, 2019 at 10:39:46AM +0100, Jean-Philippe Menil wrote: > > On Thu, 21 Feb 2019, Greg KH wrote: > > > > > On Wed, Feb 20, 2019 at 09:54:12PM +0100, Jean-Philippe Menil wrote: > > > > On Wed, 20 Feb 2019, Greg KH wrote: > > > > > > > > > On Wed, Feb 20, 2019 at 07:50:52PM +0200, Mathias Nyman wrote: > > > > > > From: Jean-Philippe Menil <jpmenil@gmail.com> > > > > > > > > > > > > Fix build warning when building drivers/usb/host/xhci-mem.o due to missing > > > > > > prototype for xhci_free_virt_devices_depth_first. > > > > > > > > > > There is no normal "build warning", this is a sparse fixup, right? > > > > > > > > > > > > > > > > > > Hi Greg, > > > > > > > > this is a build warning, at least with W=1 : > > > > > > > > drivers/usb/host/xhci-mem.c:936:6: warning: no previous prototype for > > > > ‘xhci_free_virt_devices_depth_first’ [-Wmissing-prototypes] > > > > void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int > > > > slot_id) > > > > > > "W=1" is not a normal build option for anyone to use, except those that > > > wish to find crazy issues like this :) > > > > > > Also, if that is the only way it shows up, you should mention it in the > > > changelog. > > > > > > thanks, > > > > > > greg k-h > > > > > > > Hmm, rereaind this mail from kernel-janitors > > https://marc.info/?l=kernel-janitors&m=154178546220848&w=2 > > seem that you're right, this is not a normal option :) > > > > Mathias, do you want me to re-send something? > > No need, I'll go edit the changelog text... > > greg k-h > Ack, many thanks for that, appreciated ! Regards, Jean-Philippe
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 8067f17..cf5e179 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -933,7 +933,7 @@ void xhci_free_virt_device(struct xhci_hcd *xhci, int slot_id) * that tt_info, then free the child first. Recursive. * We can't rely on udev at this point to find child-parent relationships. */ -void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int slot_id) +static void xhci_free_virt_devices_depth_first(struct xhci_hcd *xhci, int slot_id) { struct xhci_virt_device *vdev; struct list_head *tt_list_head;