diff mbox series

[2/4] usb: xhci: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

Message ID 1550685055-13612-3-git-send-email-mathias.nyman@linux.intel.com (mailing list archive)
State Mainlined
Commit 8fde481ef3674ae5ad0dbfef4df18ff507c5675a
Headers show
Series xhci features for usb-next | expand

Commit Message

Mathias Nyman Feb. 20, 2019, 5:50 p.m. UTC 
From: Balaji Manoharan <m.balaji@intel.com>

This fix enables USB role feature on intel commercial nuc
platform which is based on Kabylake chipset.

Signed-off-by: Balaji Manoharan <m.balaji@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
 drivers/usb/host/xhci-pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH Feb. 20, 2019, 7:17 p.m. UTC | #1 
On Wed, Feb 20, 2019 at 07:50:53PM +0200, Mathias Nyman wrote:
> From: Balaji Manoharan <m.balaji@intel.com>
> 
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.
> 
> Signed-off-by: Balaji Manoharan <m.balaji@intel.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> ---
>  drivers/usb/host/xhci-pci.c | 1 +
>  1 file changed, 1 insertion(+)

Shouldn't this be cc: stable?
Mathias Nyman Feb. 21, 2019, 8:56 a.m. UTC | #2 
On 20.2.2019 21.17, Greg KH wrote:
> On Wed, Feb 20, 2019 at 07:50:53PM +0200, Mathias Nyman wrote:
>> From: Balaji Manoharan <m.balaji@intel.com>
>>
>> This fix enables USB role feature on intel commercial nuc
>> platform which is based on Kabylake chipset.
>>
>> Signed-off-by: Balaji Manoharan <m.balaji@intel.com>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>> ---
>>   drivers/usb/host/xhci-pci.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Shouldn't this be cc: stable?

Yes, agree, this would be good to get to stable as well

-Mathias
Greg KH Feb. 21, 2019, 9:50 a.m. UTC | #3 
On Thu, Feb 21, 2019 at 10:56:18AM +0200, Mathias Nyman wrote:
> On 20.2.2019 21.17, Greg KH wrote:
> > On Wed, Feb 20, 2019 at 07:50:53PM +0200, Mathias Nyman wrote:
> > > From: Balaji Manoharan <m.balaji@intel.com>
> > > 
> > > This fix enables USB role feature on intel commercial nuc
> > > platform which is based on Kabylake chipset.
> > > 
> > > Signed-off-by: Balaji Manoharan <m.balaji@intel.com>
> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> > > ---
> > >   drivers/usb/host/xhci-pci.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > 
> > Shouldn't this be cc: stable?
> 
> Yes, agree, this would be good to get to stable as well

Ok, will add the cc: stable tag to it, thanks.

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index a9ec705..c2fe218 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -194,6 +194,7 @@  static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
 	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
+	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
 		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&