| Message ID | 20190130192102.7065-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: imx8mq: Fix the CLKO2 source select list | expand |
Quoting Fabio Estevam (2019-01-30 11:21:02) > The CLKO2 clock source select list is the following as per the i.MX8M > Reference Manual: > > 000 - 25M_REF_CLK > 001 - SYSTEM_PLL2_DIV5 > 010 - SYSTEM_PLL1_DIV2 > 011 - SYSTEM_PLL2_DIV6 > 100 - SYSTEM_PLL3_CLK > 101 - AUDIO_PLL1_CLK > 110 - VIDEO_PLL1_CLK > 111 - 32K_REF_CLK > > However, in imx8mq_clko2_sels[] only the first four entries are correct. > > Fix it by adding the missing "sys3_pll2_out" entry in order to match > the description from the manual. > > Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM") > Reported-by: Rogerio Pimentel <rogerio.silva@nxp.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- Do I need to fast track this into v5.0 final? Or this is a non-critical fix for something that isn't used right now?
Hi Stephen, On Tue, Feb 5, 2019 at 8:29 PM Stephen Boyd <sboyd@kernel.org> wrote: > Do I need to fast track this into v5.0 final? Or this is a non-critical > fix for something that isn't used right now? This is a non-critical fix and it can wait until v5.1. Thanks
Quoting Fabio Estevam (2019-02-05 14:35:49) > Hi Stephen, > > On Tue, Feb 5, 2019 at 8:29 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > Do I need to fast track this into v5.0 final? Or this is a non-critical > > fix for something that isn't used right now? > > This is a non-critical fix and it can wait until v5.1. > Alright, thanks!
Hi Stephen, On Wed, Feb 6, 2019 at 3:30 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Fabio Estevam (2019-02-05 14:35:49) > > Hi Stephen, > > > > On Tue, Feb 5, 2019 at 8:29 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > > > Do I need to fast track this into v5.0 final? Or this is a non-critical > > > fix for something that isn't used right now? > > > > This is a non-critical fix and it can wait until v5.1. > > > > Alright, thanks! Can this go to clk-next?
Quoting Fabio Estevam (2019-01-30 11:21:02) > The CLKO2 clock source select list is the following as per the i.MX8M > Reference Manual: > > 000 - 25M_REF_CLK > 001 - SYSTEM_PLL2_DIV5 > 010 - SYSTEM_PLL1_DIV2 > 011 - SYSTEM_PLL2_DIV6 > 100 - SYSTEM_PLL3_CLK > 101 - AUDIO_PLL1_CLK > 110 - VIDEO_PLL1_CLK > 111 - 32K_REF_CLK > > However, in imx8mq_clko2_sels[] only the first four entries are correct. > > Fix it by adding the missing "sys3_pll2_out" entry in order to match > the description from the manual. > > Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM") > Reported-by: Rogerio Pimentel <rogerio.silva@nxp.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- Applied to clk-next
diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c index 398ab0bcd9de..63001bc891d4 100644 --- a/drivers/clk/imx/clk-imx8mq.c +++ b/drivers/clk/imx/clk-imx8mq.c @@ -264,8 +264,8 @@ static const char * const imx8mq_ecspi3_sels[] = {"osc_25m", "sys2_pll_200m", "s "sys1_pll_800m", "sys3_pll2_out", "sys2_pll_250m", "audio_pll2_out", }; static const char * const imx8mq_dram_core_sels[] = {"dram_pll_out", "dram_alt_root", }; -static const char * const imx8mq_clko2_sels[] = {"osc_25m", "sys2_pll_200m", "sys1_pll_400m", "sys2_pll_166m", "audio_pll1_out", - "video_pll1_out", "ckil", }; +static const char * const imx8mq_clko2_sels[] = {"osc_25m", "sys2_pll_200m", "sys1_pll_400m", "sys2_pll_166m", + "sys3_pll2_out", "audio_pll1_out", "video_pll1_out", "ckil", }; static struct clk_onecell_data clk_data;
The CLKO2 clock source select list is the following as per the i.MX8M Reference Manual: 000 - 25M_REF_CLK 001 - SYSTEM_PLL2_DIV5 010 - SYSTEM_PLL1_DIV2 011 - SYSTEM_PLL2_DIV6 100 - SYSTEM_PLL3_CLK 101 - AUDIO_PLL1_CLK 110 - VIDEO_PLL1_CLK 111 - 32K_REF_CLK However, in imx8mq_clko2_sels[] only the first four entries are correct. Fix it by adding the missing "sys3_pll2_out" entry in order to match the description from the manual. Fixes: b80522040cd3f ("clk: imx: Add clock driver for i.MX8MQ CCM") Reported-by: Rogerio Pimentel <rogerio.silva@nxp.com> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/clk/imx/clk-imx8mq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)