| Message ID | 20190222003403.128243-2-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] Bluetooth: btusb: add QCA6174A compatible properties | expand |
On Thu, Feb 21, 2019 at 04:34:02PM -0800, Brian Norris wrote: > There are two USB PID/VID variations I've seen for this chip, and I want > to utilize the 'interrupts' property defined here already. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > Documentation/devicetree/bindings/net/btusb.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/btusb.txt b/Documentation/devicetree/bindings/net/btusb.txt > index 37d67926dd6d..43c96c3380a6 100644 > --- a/Documentation/devicetree/bindings/net/btusb.txt > +++ b/Documentation/devicetree/bindings/net/btusb.txt > @@ -9,6 +9,9 @@ Required properties: > (more may be added later) are: > > "usb1286,204e" (Marvell 8997) > + "usb0cf3,e300" (Qualcomm QCA6174A) > + "usb04ca,301a" (Qualcomm QCA6174A (Lite-On)) > + > > Also, vendors that use btusb may have device additional properties, e.g: > Documentation/devicetree/bindings/net/marvell-bt-8xxx.txt Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On 2019-02-22 12:34 am, Brian Norris wrote: > There are two USB PID/VID variations I've seen for this chip, and I want > to utilize the 'interrupts' property defined here already. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > Documentation/devicetree/bindings/net/btusb.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/btusb.txt b/Documentation/devicetree/bindings/net/btusb.txt > index 37d67926dd6d..43c96c3380a6 100644 > --- a/Documentation/devicetree/bindings/net/btusb.txt > +++ b/Documentation/devicetree/bindings/net/btusb.txt > @@ -9,6 +9,9 @@ Required properties: > (more may be added later) are: > > "usb1286,204e" (Marvell 8997) > + "usb0cf3,e300" (Qualcomm QCA6174A) > + "usb04ca,301a" (Qualcomm QCA6174A (Lite-On)) Nit: the USB device binding states that those leading zeroes in the VIDs should be suppressed. Otherwise, thanks for the tip-off - I hadn't realised that OOB interrupt support was fully implemented already. I'll have to give this a go for the Realtek module in one of my TV boxes :) Robin. > + > > Also, vendors that use btusb may have device additional properties, e.g: > Documentation/devicetree/bindings/net/marvell-bt-8xxx.txt >
On Fri, Feb 22, 2019 at 1:57 PM Robin Murphy <robin.murphy@arm.com> wrote: > On 2019-02-22 12:34 am, Brian Norris wrote: > > + "usb0cf3,e300" (Qualcomm QCA6174A) > > + "usb04ca,301a" (Qualcomm QCA6174A (Lite-On)) > > Nit: the USB device binding states that those leading zeroes in the VIDs > should be suppressed. Ah, thanks. Didn't notice that part. I'll remove the zeroes and resend. Brian
diff --git a/Documentation/devicetree/bindings/net/btusb.txt b/Documentation/devicetree/bindings/net/btusb.txt index 37d67926dd6d..43c96c3380a6 100644 --- a/Documentation/devicetree/bindings/net/btusb.txt +++ b/Documentation/devicetree/bindings/net/btusb.txt @@ -9,6 +9,9 @@ Required properties: (more may be added later) are: "usb1286,204e" (Marvell 8997) + "usb0cf3,e300" (Qualcomm QCA6174A) + "usb04ca,301a" (Qualcomm QCA6174A (Lite-On)) + Also, vendors that use btusb may have device additional properties, e.g: Documentation/devicetree/bindings/net/marvell-bt-8xxx.txt
There are two USB PID/VID variations I've seen for this chip, and I want to utilize the 'interrupts' property defined here already. Signed-off-by: Brian Norris <briannorris@chromium.org> --- Documentation/devicetree/bindings/net/btusb.txt | 3 +++ 1 file changed, 3 insertions(+)