| Message ID | 1550730831-14995-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
| Series | [V8,1/4] dt-bindings: fsl: scu: add thermal binding | expand |
On Thu, Feb 21, 2019 at 06:38:30AM +0000, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller via MU (message unit) > IPC to get temperature from thermal sensors, this patch adds > binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes since V7: > - remove unused property "tsens-num"; > - improve the compatible description; > - update examples according to latest dts file. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 72d481c..d89147e 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -122,6 +122,19 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Thermal bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. > + > +- imx,sensor-resource-id: Property array to specify each thermal zone's sensor resource ID. If this is an array... > + > Example (imx8qxp): > ------------- > lsio_mu1: mailbox@5d1c0000 { > @@ -168,6 +181,12 @@ firmware { > rtc: rtc { > compatible = "fsl,imx8qxp-sc-rtc"; > }; > + > + tsens: thermal-sensor { > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal"; > + #thermal-sensor-cells = <0>; > + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>; then this example should have an array, to be better express how this is supposed to work. Can you please resend this with an array instead? > + }; > }; > }; > > -- > 2.7.4 >
On Sat, Feb 23, 2019 at 01:38:00PM -0800, Eduardo Valentin wrote: > On Thu, Feb 21, 2019 at 06:38:30AM +0000, Anson Huang wrote: > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > system controller, the system controller is in charge of system > > power, clock and thermal sensors etc. management, Linux kernel > > has to communicate with system controller via MU (message unit) > > IPC to get temperature from thermal sensors, this patch adds > > binding doc for i.MX system controller thermal driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > Changes since V7: > > - remove unused property "tsens-num"; > > - improve the compatible description; > > - update examples according to latest dts file. > > --- > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > index 72d481c..d89147e 100644 > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -122,6 +122,19 @@ RTC bindings based on SCU Message Protocol > > Required properties: > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > +Thermal bindings based on SCU Message Protocol > > +------------------------------------------------------------ > > + > > +Required properties: > > +- compatible: Should be : > > + "fsl,imx8qxp-sc-thermal" > > + followed by "fsl,imx-sc-thermal"; > > + > > +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt > > + for a description. > > + > > +- imx,sensor-resource-id: Property array to specify each thermal zone's sensor resource ID. > > If this is an array... > > > + > > Example (imx8qxp): > > ------------- > > lsio_mu1: mailbox@5d1c0000 { > > @@ -168,6 +181,12 @@ firmware { > > rtc: rtc { > > compatible = "fsl,imx8qxp-sc-rtc"; > > }; > > + > > + tsens: thermal-sensor { > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal"; > > + #thermal-sensor-cells = <0>; > > + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>; > > then this example should have an array, to be better express how this is > supposed to work. Can you please resend this with an array instead? I mean this could be one example of an array with more than one element. > > > + }; > > }; > > }; > > > > -- > > 2.7.4 > >
Hi, Eduardo Best Regards! Anson Huang > -----Original Message----- > From: Eduardo Valentin [mailto:edubezval@gmail.com] > Sent: 2019年2月24日 5:38 > To: Anson Huang <anson.huang@nxp.com> > Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com; > daniel.lezcano@linaro.org; Aisheng Dong <aisheng.dong@nxp.com>; > ulf.hansson@linaro.org; sboyd@kernel.org; Daniel Baluta > <daniel.baluta@nxp.com>; Andy Gross <andy.gross@linaro.org>; > horms+renesas@verge.net.au; heiko@sntech.de; arnd@arndb.de; > maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding > > On Thu, Feb 21, 2019 at 06:38:30AM +0000, Anson Huang wrote: > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > controller, the system controller is in charge of system power, clock > > and thermal sensors etc. management, Linux kernel has to communicate > > with system controller via MU (message unit) IPC to get temperature > > from thermal sensors, this patch adds binding doc for i.MX system > > controller thermal driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > Changes since V7: > > - remove unused property "tsens-num"; > > - improve the compatible description; > > - update examples according to latest dts file. > > --- > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 19 > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > index 72d481c..d89147e 100644 > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -122,6 +122,19 @@ RTC bindings based on SCU Message Protocol > > Required properties: > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > +Thermal bindings based on SCU Message Protocol > > +------------------------------------------------------------ > > + > > +Required properties: > > +- compatible: Should be : > > + "fsl,imx8qxp-sc-thermal" > > + followed by "fsl,imx-sc-thermal"; > > + > > +- #thermal-sensor-cells: See > Documentation/devicetree/bindings/thermal/thermal.txt > > + for a description. > > + > > +- imx,sensor-resource-id: Property array to specify each thermal zone's > sensor resource ID. > > If this is an array... > > > + > > Example (imx8qxp): > > ------------- > > lsio_mu1: mailbox@5d1c0000 { > > @@ -168,6 +181,12 @@ firmware { > > rtc: rtc { > > compatible = "fsl,imx8qxp-sc-rtc"; > > }; > > + > > + tsens: thermal-sensor { > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > thermal"; > > + #thermal-sensor-cells = <0>; > > + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>; > > then this example should have an array, to be better express how this is > supposed to work. Can you please resend this with an array instead? On i.MX8QXP, there is ONLY 1 thermal zone available currently, but the thermal driver is supposed to support multi thermal zones as well for i.MX8QM, in V9 patch set I just sent, I use the " imx,sensor-resource-id " element count to determine how many thermal sensors will be supported, so that we can also get rid of searching the thermal-zones' child node, I improved the description as below, is it OK? 41 +- imx,sensor-resource-id: A single integer for single thermal zone's resource ID or 42 + an array of integers to specify each thermal zone's sensor 43 + resource ID. Thanks, Anson. > > > + }; > > }; > > }; > > > > -- > > 2.7.4 > >
[...] > > On Thu, Feb 21, 2019 at 06:38:30AM +0000, Anson Huang wrote: > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > > controller, the system controller is in charge of system power, > > > clock and thermal sensors etc. management, Linux kernel has to > > > communicate with system controller via MU (message unit) IPC to get > > > temperature from thermal sensors, this patch adds binding doc for > > > i.MX system controller thermal driver. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> You need drop the former Reviewed-by once there's significant changes. > > > +Thermal bindings based on SCU Message Protocol > > > +------------------------------------------------------------ > > > + > > > +Required properties: > > > +- compatible: Should be : > > > + "fsl,imx8qxp-sc-thermal" > > > + followed by "fsl,imx-sc-thermal"; > > > + > > > +- #thermal-sensor-cells: See > > Documentation/devicetree/bindings/thermal/thermal.txt > > > + for a description. > > > + > > > +- imx,sensor-resource-id: Property array to specify each thermal > zone's > > sensor resource ID. > > > > If this is an array... > > > > > + > > > Example (imx8qxp): > > > ------------- > > > lsio_mu1: mailbox@5d1c0000 { > > > @@ -168,6 +181,12 @@ firmware { > > > rtc: rtc { > > > compatible = "fsl,imx8qxp-sc-rtc"; > > > }; > > > + > > > + tsens: thermal-sensor { > > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > > thermal"; > > > + #thermal-sensor-cells = <0>; > > > + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>; > > > > then this example should have an array, to be better express how this > > is supposed to work. Can you please resend this with an array instead? > > On i.MX8QXP, there is ONLY 1 thermal zone available currently, but the thermal > driver is supposed to support multi thermal zones as well for i.MX8QM, in V9 > patch set I just sent, I use the " imx,sensor-resource-id " element count to > determine how many thermal sensors will be supported, so that we can also > get rid of searching the thermal-zones' child node, I improved the description > as below, is it OK? > Device tree is used to describe HW. #thermal-sensor-cells is less to be an optional parameter to me. If HW supports, then it should be 1 and update the example accordingly. Regards Dong Aisheng > 41 +- imx,sensor-resource-id: A single integer for single thermal zone's > resource ID or > 42 + an array of integers to specify each > thermal zone's sensor > 43 + resource ID.
Best Regards! Anson Huang > -----Original Message----- > From: Aisheng Dong > Sent: 2019年2月26日 20:01 > To: Anson Huang <anson.huang@nxp.com>; Eduardo Valentin > <edubezval@gmail.com> > Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > catalin.marinas@arm.com; will.deacon@arm.com; rui.zhang@intel.com; > daniel.lezcano@linaro.org; ulf.hansson@linaro.org; sboyd@kernel.org; > Daniel Baluta <daniel.baluta@nxp.com>; Andy Gross > <andy.gross@linaro.org>; horms+renesas@verge.net.au; heiko@sntech.de; > arnd@arndb.de; maxime.ripard@bootlin.com; bjorn.andersson@linaro.org; > jagan@amarulasolutions.com; enric.balletbo@collabora.com; > marc.w.gonzalez@free.fr; olof@lixom.net; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > pm@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: RE: [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding > > [...] > > > On Thu, Feb 21, 2019 at 06:38:30AM +0000, Anson Huang wrote: > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > > > > system controller, the system controller is in charge of system > > > > power, clock and thermal sensors etc. management, Linux kernel has > > > > to communicate with system controller via MU (message unit) IPC to > > > > get temperature from thermal sensors, this patch adds binding doc > > > > for i.MX system controller thermal driver. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > You need drop the former Reviewed-by once there's significant changes. > > > > > +Thermal bindings based on SCU Message Protocol > > > > +------------------------------------------------------------ > > > > + > > > > +Required properties: > > > > +- compatible: Should be : > > > > + "fsl,imx8qxp-sc-thermal" > > > > + followed by "fsl,imx-sc-thermal"; > > > > + > > > > +- #thermal-sensor-cells: See > > > Documentation/devicetree/bindings/thermal/thermal.txt > > > > + for a description. > > > > + > > > > +- imx,sensor-resource-id: Property array to specify each > thermal > > zone's > > > sensor resource ID. > > > > > > If this is an array... > > > > > > > + > > > > Example (imx8qxp): > > > > ------------- > > > > lsio_mu1: mailbox@5d1c0000 { > > > > @@ -168,6 +181,12 @@ firmware { > > > > rtc: rtc { > > > > compatible = "fsl,imx8qxp-sc-rtc"; > > > > }; > > > > + > > > > + tsens: thermal-sensor { > > > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > > > thermal"; > > > > + #thermal-sensor-cells = <0>; > > > > + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>; > > > > > > then this example should have an array, to be better express how > > > this is supposed to work. Can you please resend this with an array > instead? > > > > On i.MX8QXP, there is ONLY 1 thermal zone available currently, but the > > thermal driver is supposed to support multi thermal zones as well for > > i.MX8QM, in V9 patch set I just sent, I use the " > > imx,sensor-resource-id " element count to determine how many thermal > > sensors will be supported, so that we can also get rid of searching > > the thermal-zones' child node, I improved the description as below, is it OK? > > > > Device tree is used to describe HW. > #thermal-sensor-cells is less to be an optional parameter to me. > If HW supports, then it should be 1 and update the example accordingly. OK, I changed it to "1" in V10 patch series. Thanks, Anson. > > Regards > Dong Aisheng > > > 41 +- imx,sensor-resource-id: A single integer for single thermal zone's > > resource ID or > > 42 + an array of integers to specify each > > thermal zone's sensor > > 43 + resource ID.
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt index 72d481c..d89147e 100644 --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt @@ -122,6 +122,19 @@ RTC bindings based on SCU Message Protocol Required properties: - compatible: should be "fsl,imx8qxp-sc-rtc"; +Thermal bindings based on SCU Message Protocol +------------------------------------------------------------ + +Required properties: +- compatible: Should be : + "fsl,imx8qxp-sc-thermal" + followed by "fsl,imx-sc-thermal"; + +- #thermal-sensor-cells: See Documentation/devicetree/bindings/thermal/thermal.txt + for a description. + +- imx,sensor-resource-id: Property array to specify each thermal zone's sensor resource ID. + Example (imx8qxp): ------------- lsio_mu1: mailbox@5d1c0000 { @@ -168,6 +181,12 @@ firmware { rtc: rtc { compatible = "fsl,imx8qxp-sc-rtc"; }; + + tsens: thermal-sensor { + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal"; + #thermal-sensor-cells = <0>; + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>; + }; }; };