mbox series

[v15,00/16] drm/i915: Implement HDCP2.2

Message ID 1550772730-23280-1-git-send-email-ramalingam.c@intel.com (mailing list archive)
Headers show
Series drm/i915: Implement HDCP2.2 | expand

Message

Ramalingam C Feb. 21, 2019, 6:11 p.m. UTC
This series enables the HDCP2.2 Type 0 for I915. The sequence for
HDCP2.2 authentication and encryption is implemented as a generic flow
between HDMI and DP. Encoder specific implementations are moved
into hdcp_shim.

Intel HWs supports HDCP2.2 through ME FW. Hence this series
introduces a client driver for mei bus, so that for HDCP2.2
authentication, HDCP2.2 stack in I915 can avail the services from
ME FW. To enable this client driver set the config variable
CONFIG_INTEL_MEI_HDCP.

Userspace interface remains unchanged as version agnostic. When
userspace request for HDCP enable, Kernel will detect the HDCP source
and sink's HDCP version(1.4/2.2)capability and enable the best capable
version for that combination.

This series enables the HDCP2.2 for Type0 content streams.

Test-with: <1549566452-30175-1-git-send-email-ramalingam.c@intel.com>
So that CP will be tested on BAT machine too.

Major changes in v15
  - All I915 patches are merged. So dropping them.
  - Few minor suggestions are incorporated at mei changes.

To ease the review process, series is hosted at
https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v15

Ramalingam C (15):
  misc/mei/hdcp: Client driver for HDCP application
  misc/mei/hdcp: Define ME FW interface for HDCP2.2
  misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
  misc/mei/hdcp: Verify Receiver Cert and prepare km
  misc/mei/hdcp: Verify H_prime
  misc/mei/hdcp: Store the HDCP Pairing info
  misc/mei/hdcp: Initiate Locality check
  misc/mei/hdcp: Verify L_prime
  misc/mei/hdcp: Prepare Session Key
  misc/mei/hdcp: Repeater topology verification and ack
  misc/mei/hdcp: Verify M_prime
  misc/mei/hdcp: Enabling the HDCP authentication
  misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
  misc/mei/hdcp: Component framework for I915 Interface
  FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915

Tomas Winkler (1):
  mei: bus: whitelist hdcp client

 drivers/misc/mei/Kconfig         |  11 +
 drivers/misc/mei/Makefile        |   2 +
 drivers/misc/mei/bus-fixup.c     |  16 +
 drivers/misc/mei/hdcp/Makefile   |   7 +
 drivers/misc/mei/hdcp/mei_hdcp.c | 849 +++++++++++++++++++++++++++++++++++++++
 drivers/misc/mei/hdcp/mei_hdcp.h | 377 +++++++++++++++++
 6 files changed, 1262 insertions(+)
 create mode 100644 drivers/misc/mei/hdcp/Makefile
 create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
 create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h

Comments

Ramalingam C Feb. 24, 2019, 4:33 p.m. UTC | #1
Tomas,

Could you please help to review and give final "Go" for the series?

Thanks
--Ram.

On 2/21/2019 11:41 PM, Ramalingam C wrote:
> This series enables the HDCP2.2 Type 0 for I915. The sequence for
> HDCP2.2 authentication and encryption is implemented as a generic flow
> between HDMI and DP. Encoder specific implementations are moved
> into hdcp_shim.
>
> Intel HWs supports HDCP2.2 through ME FW. Hence this series
> introduces a client driver for mei bus, so that for HDCP2.2
> authentication, HDCP2.2 stack in I915 can avail the services from
> ME FW. To enable this client driver set the config variable
> CONFIG_INTEL_MEI_HDCP.
>
> Userspace interface remains unchanged as version agnostic. When
> userspace request for HDCP enable, Kernel will detect the HDCP source
> and sink's HDCP version(1.4/2.2)capability and enable the best capable
> version for that combination.
>
> This series enables the HDCP2.2 for Type0 content streams.
>
> Test-with: <1549566452-30175-1-git-send-email-ramalingam.c@intel.com>
> So that CP will be tested on BAT machine too.
>
> Major changes in v15
>    - All I915 patches are merged. So dropping them.
>    - Few minor suggestions are incorporated at mei changes.
>
> To ease the review process, series is hosted at
> https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v15
>
> Ramalingam C (15):
>    misc/mei/hdcp: Client driver for HDCP application
>    misc/mei/hdcp: Define ME FW interface for HDCP2.2
>    misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
>    misc/mei/hdcp: Verify Receiver Cert and prepare km
>    misc/mei/hdcp: Verify H_prime
>    misc/mei/hdcp: Store the HDCP Pairing info
>    misc/mei/hdcp: Initiate Locality check
>    misc/mei/hdcp: Verify L_prime
>    misc/mei/hdcp: Prepare Session Key
>    misc/mei/hdcp: Repeater topology verification and ack
>    misc/mei/hdcp: Verify M_prime
>    misc/mei/hdcp: Enabling the HDCP authentication
>    misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
>    misc/mei/hdcp: Component framework for I915 Interface
>    FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
>
> Tomas Winkler (1):
>    mei: bus: whitelist hdcp client
>
>   drivers/misc/mei/Kconfig         |  11 +
>   drivers/misc/mei/Makefile        |   2 +
>   drivers/misc/mei/bus-fixup.c     |  16 +
>   drivers/misc/mei/hdcp/Makefile   |   7 +
>   drivers/misc/mei/hdcp/mei_hdcp.c | 849 +++++++++++++++++++++++++++++++++++++++
>   drivers/misc/mei/hdcp/mei_hdcp.h | 377 +++++++++++++++++
>   6 files changed, 1262 insertions(+)
>   create mode 100644 drivers/misc/mei/hdcp/Makefile
>   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
>   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h
>
Winkler, Tomas Feb. 24, 2019, 8:14 p.m. UTC | #2
Have you fixed the lkp issue? 
I didn't see you pushed the code to github.
Thanks


> -----Original Message-----
> From: C, Ramalingam
> Sent: Sunday, February 24, 2019 18:33
> To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> daniel.vetter@ffwll.ch; Winkler, Tomas <tomas.winkler@intel.com>; Shankar,
> Uma <uma.shankar@intel.com>
> Subject: Re: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> 
> Tomas,
> 
> Could you please help to review and give final "Go" for the series?
> 
> Thanks
> --Ram.
> 
> On 2/21/2019 11:41 PM, Ramalingam C wrote:
> > This series enables the HDCP2.2 Type 0 for I915. The sequence for
> > HDCP2.2 authentication and encryption is implemented as a generic flow
> > between HDMI and DP. Encoder specific implementations are moved into
> > hdcp_shim.
> >
> > Intel HWs supports HDCP2.2 through ME FW. Hence this series introduces
> > a client driver for mei bus, so that for HDCP2.2 authentication,
> > HDCP2.2 stack in I915 can avail the services from ME FW. To enable
> > this client driver set the config variable CONFIG_INTEL_MEI_HDCP.
> >
> > Userspace interface remains unchanged as version agnostic. When
> > userspace request for HDCP enable, Kernel will detect the HDCP source
> > and sink's HDCP version(1.4/2.2)capability and enable the best capable
> > version for that combination.
> >
> > This series enables the HDCP2.2 for Type0 content streams.
> >
> > Test-with: <1549566452-30175-1-git-send-email-ramalingam.c@intel.com>
> > So that CP will be tested on BAT machine too.
> >
> > Major changes in v15
> >    - All I915 patches are merged. So dropping them.
> >    - Few minor suggestions are incorporated at mei changes.
> >
> > To ease the review process, series is hosted at
> > https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v15
> >
> > Ramalingam C (15):
> >    misc/mei/hdcp: Client driver for HDCP application
> >    misc/mei/hdcp: Define ME FW interface for HDCP2.2
> >    misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
> >    misc/mei/hdcp: Verify Receiver Cert and prepare km
> >    misc/mei/hdcp: Verify H_prime
> >    misc/mei/hdcp: Store the HDCP Pairing info
> >    misc/mei/hdcp: Initiate Locality check
> >    misc/mei/hdcp: Verify L_prime
> >    misc/mei/hdcp: Prepare Session Key
> >    misc/mei/hdcp: Repeater topology verification and ack
> >    misc/mei/hdcp: Verify M_prime
> >    misc/mei/hdcp: Enabling the HDCP authentication
> >    misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
> >    misc/mei/hdcp: Component framework for I915 Interface
> >    FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
> >
> > Tomas Winkler (1):
> >    mei: bus: whitelist hdcp client
> >
> >   drivers/misc/mei/Kconfig         |  11 +
> >   drivers/misc/mei/Makefile        |   2 +
> >   drivers/misc/mei/bus-fixup.c     |  16 +
> >   drivers/misc/mei/hdcp/Makefile   |   7 +
> >   drivers/misc/mei/hdcp/mei_hdcp.c | 849
> +++++++++++++++++++++++++++++++++++++++
> >   drivers/misc/mei/hdcp/mei_hdcp.h | 377 +++++++++++++++++
> >   6 files changed, 1262 insertions(+)
> >   create mode 100644 drivers/misc/mei/hdcp/Makefile
> >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
> >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h
> >
Ramalingam C Feb. 25, 2019, 5:12 a.m. UTC | #3
Tomas,

Lkp issue is complaining about the header drm/i915_mei_hdcp_interface.h, Which is already merged in drm-tip through below commit. So don’t think this is a genuine issue. May be this build was tried in different tree, where this commit is not added yet?

commit 1626eab70ebc61d015e69a4bc3479d9228539343
Author: Ramalingam C <ramalingam.c@intel.com>
Date:   Fri Feb 15 14:04:58 2019 +0530

    drm/i915: header for i915 - MEI_HDCP interface

v15 is now part of github.

Best Regards,
Ramalingam C


> -----Original Message-----
> From: Winkler, Tomas
> Sent: Monday, February 25, 2019 1:45 AM
> To: C, Ramalingam <ramalingam.c@intel.com>; intel-gfx@lists.freedesktop.org;
> dri-devel@lists.freedesktop.org; daniel.vetter@ffwll.ch; Shankar, Uma
> <uma.shankar@intel.com>
> Subject: RE: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> 
> Have you fixed the lkp issue?
> I didn't see you pushed the code to github.
> Thanks
> 
> 
> > -----Original Message-----
> > From: C, Ramalingam
> > Sent: Sunday, February 24, 2019 18:33
> > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> > daniel.vetter@ffwll.ch; Winkler, Tomas <tomas.winkler@intel.com>;
> > Shankar, Uma <uma.shankar@intel.com>
> > Subject: Re: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> >
> > Tomas,
> >
> > Could you please help to review and give final "Go" for the series?
> >
> > Thanks
> > --Ram.
> >
> > On 2/21/2019 11:41 PM, Ramalingam C wrote:
> > > This series enables the HDCP2.2 Type 0 for I915. The sequence for
> > > HDCP2.2 authentication and encryption is implemented as a generic
> > > flow between HDMI and DP. Encoder specific implementations are moved
> > > into hdcp_shim.
> > >
> > > Intel HWs supports HDCP2.2 through ME FW. Hence this series
> > > introduces a client driver for mei bus, so that for HDCP2.2
> > > authentication,
> > > HDCP2.2 stack in I915 can avail the services from ME FW. To enable
> > > this client driver set the config variable CONFIG_INTEL_MEI_HDCP.
> > >
> > > Userspace interface remains unchanged as version agnostic. When
> > > userspace request for HDCP enable, Kernel will detect the HDCP
> > > source and sink's HDCP version(1.4/2.2)capability and enable the
> > > best capable version for that combination.
> > >
> > > This series enables the HDCP2.2 for Type0 content streams.
> > >
> > > Test-with:
> > > <1549566452-30175-1-git-send-email-ramalingam.c@intel.com>
> > > So that CP will be tested on BAT machine too.
> > >
> > > Major changes in v15
> > >    - All I915 patches are merged. So dropping them.
> > >    - Few minor suggestions are incorporated at mei changes.
> > >
> > > To ease the review process, series is hosted at
> > > https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v15
> > >
> > > Ramalingam C (15):
> > >    misc/mei/hdcp: Client driver for HDCP application
> > >    misc/mei/hdcp: Define ME FW interface for HDCP2.2
> > >    misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
> > >    misc/mei/hdcp: Verify Receiver Cert and prepare km
> > >    misc/mei/hdcp: Verify H_prime
> > >    misc/mei/hdcp: Store the HDCP Pairing info
> > >    misc/mei/hdcp: Initiate Locality check
> > >    misc/mei/hdcp: Verify L_prime
> > >    misc/mei/hdcp: Prepare Session Key
> > >    misc/mei/hdcp: Repeater topology verification and ack
> > >    misc/mei/hdcp: Verify M_prime
> > >    misc/mei/hdcp: Enabling the HDCP authentication
> > >    misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
> > >    misc/mei/hdcp: Component framework for I915 Interface
> > >    FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
> > >
> > > Tomas Winkler (1):
> > >    mei: bus: whitelist hdcp client
> > >
> > >   drivers/misc/mei/Kconfig         |  11 +
> > >   drivers/misc/mei/Makefile        |   2 +
> > >   drivers/misc/mei/bus-fixup.c     |  16 +
> > >   drivers/misc/mei/hdcp/Makefile   |   7 +
> > >   drivers/misc/mei/hdcp/mei_hdcp.c | 849
> > +++++++++++++++++++++++++++++++++++++++
> > >   drivers/misc/mei/hdcp/mei_hdcp.h | 377 +++++++++++++++++
> > >   6 files changed, 1262 insertions(+)
> > >   create mode 100644 drivers/misc/mei/hdcp/Makefile
> > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
> > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h
> > >
Daniel Vetter Feb. 25, 2019, 8:18 a.m. UTC | #4
On Mon, Feb 25, 2019 at 05:12:09AM +0000, C, Ramalingam wrote:
> Tomas,
> 
> Lkp issue is complaining about the header drm/i915_mei_hdcp_interface.h,
> Which is already merged in drm-tip through below commit. So don’t think
> this is a genuine issue. May be this build was tried in different tree,
> where this commit is not added yet?

Yeah our topic trees aren't pushed into linux-next, 0day can't find them.
Usually it will then fail to apply (and in that case it doesn't complain),
but it does complain if everything applies but doesn't build.
-Daniel

> 
> commit 1626eab70ebc61d015e69a4bc3479d9228539343
> Author: Ramalingam C <ramalingam.c@intel.com>
> Date:   Fri Feb 15 14:04:58 2019 +0530
> 
>     drm/i915: header for i915 - MEI_HDCP interface
> 
> v15 is now part of github.
> 
> Best Regards,
> Ramalingam C
> 
> 
> > -----Original Message-----
> > From: Winkler, Tomas
> > Sent: Monday, February 25, 2019 1:45 AM
> > To: C, Ramalingam <ramalingam.c@intel.com>; intel-gfx@lists.freedesktop.org;
> > dri-devel@lists.freedesktop.org; daniel.vetter@ffwll.ch; Shankar, Uma
> > <uma.shankar@intel.com>
> > Subject: RE: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> > 
> > Have you fixed the lkp issue?
> > I didn't see you pushed the code to github.
> > Thanks
> > 
> > 
> > > -----Original Message-----
> > > From: C, Ramalingam
> > > Sent: Sunday, February 24, 2019 18:33
> > > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> > > daniel.vetter@ffwll.ch; Winkler, Tomas <tomas.winkler@intel.com>;
> > > Shankar, Uma <uma.shankar@intel.com>
> > > Subject: Re: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> > >
> > > Tomas,
> > >
> > > Could you please help to review and give final "Go" for the series?
> > >
> > > Thanks
> > > --Ram.
> > >
> > > On 2/21/2019 11:41 PM, Ramalingam C wrote:
> > > > This series enables the HDCP2.2 Type 0 for I915. The sequence for
> > > > HDCP2.2 authentication and encryption is implemented as a generic
> > > > flow between HDMI and DP. Encoder specific implementations are moved
> > > > into hdcp_shim.
> > > >
> > > > Intel HWs supports HDCP2.2 through ME FW. Hence this series
> > > > introduces a client driver for mei bus, so that for HDCP2.2
> > > > authentication,
> > > > HDCP2.2 stack in I915 can avail the services from ME FW. To enable
> > > > this client driver set the config variable CONFIG_INTEL_MEI_HDCP.
> > > >
> > > > Userspace interface remains unchanged as version agnostic. When
> > > > userspace request for HDCP enable, Kernel will detect the HDCP
> > > > source and sink's HDCP version(1.4/2.2)capability and enable the
> > > > best capable version for that combination.
> > > >
> > > > This series enables the HDCP2.2 for Type0 content streams.
> > > >
> > > > Test-with:
> > > > <1549566452-30175-1-git-send-email-ramalingam.c@intel.com>
> > > > So that CP will be tested on BAT machine too.
> > > >
> > > > Major changes in v15
> > > >    - All I915 patches are merged. So dropping them.
> > > >    - Few minor suggestions are incorporated at mei changes.
> > > >
> > > > To ease the review process, series is hosted at
> > > > https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v15
> > > >
> > > > Ramalingam C (15):
> > > >    misc/mei/hdcp: Client driver for HDCP application
> > > >    misc/mei/hdcp: Define ME FW interface for HDCP2.2
> > > >    misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
> > > >    misc/mei/hdcp: Verify Receiver Cert and prepare km
> > > >    misc/mei/hdcp: Verify H_prime
> > > >    misc/mei/hdcp: Store the HDCP Pairing info
> > > >    misc/mei/hdcp: Initiate Locality check
> > > >    misc/mei/hdcp: Verify L_prime
> > > >    misc/mei/hdcp: Prepare Session Key
> > > >    misc/mei/hdcp: Repeater topology verification and ack
> > > >    misc/mei/hdcp: Verify M_prime
> > > >    misc/mei/hdcp: Enabling the HDCP authentication
> > > >    misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
> > > >    misc/mei/hdcp: Component framework for I915 Interface
> > > >    FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
> > > >
> > > > Tomas Winkler (1):
> > > >    mei: bus: whitelist hdcp client
> > > >
> > > >   drivers/misc/mei/Kconfig         |  11 +
> > > >   drivers/misc/mei/Makefile        |   2 +
> > > >   drivers/misc/mei/bus-fixup.c     |  16 +
> > > >   drivers/misc/mei/hdcp/Makefile   |   7 +
> > > >   drivers/misc/mei/hdcp/mei_hdcp.c | 849
> > > +++++++++++++++++++++++++++++++++++++++
> > > >   drivers/misc/mei/hdcp/mei_hdcp.h | 377 +++++++++++++++++
> > > >   6 files changed, 1262 insertions(+)
> > > >   create mode 100644 drivers/misc/mei/hdcp/Makefile
> > > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
> > > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h
> > > >
>
Winkler, Tomas Feb. 25, 2019, 3:13 p.m. UTC | #5
> On Mon, Feb 25, 2019 at 05:12:09AM +0000, C, Ramalingam wrote:
> > Tomas,
> >
> > Lkp issue is complaining about the header
> > drm/i915_mei_hdcp_interface.h, Which is already merged in drm-tip
> > through below commit. So don’t think this is a genuine issue. May be
> > this build was tried in different tree, where this commit is not added yet?
> 
> Yeah our topic trees aren't pushed into linux-next, 0day can't find them.
> Usually it will then fail to apply (and in that case it doesn't complain), but it
> does complain if everything applies but doesn't build.
> -Daniel
> 
> >
> > commit 1626eab70ebc61d015e69a4bc3479d9228539343
> > Author: Ramalingam C <ramalingam.c@intel.com>
> > Date:   Fri Feb 15 14:04:58 2019 +0530
> >
> >     drm/i915: header for i915 - MEI_HDCP interface
> >
> > v15 is now part of github.

I'm okay to go with this.
Thanks
Tomas

> >
> > Best Regards,
> > Ramalingam C
> >
> >
> > > -----Original Message-----
> > > From: Winkler, Tomas
> > > Sent: Monday, February 25, 2019 1:45 AM
> > > To: C, Ramalingam <ramalingam.c@intel.com>;
> > > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> > > daniel.vetter@ffwll.ch; Shankar, Uma <uma.shankar@intel.com>
> > > Subject: RE: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> > >
> > > Have you fixed the lkp issue?
> > > I didn't see you pushed the code to github.
> > > Thanks
> > >
> > >
> > > > -----Original Message-----
> > > > From: C, Ramalingam
> > > > Sent: Sunday, February 24, 2019 18:33
> > > > To: intel-gfx@lists.freedesktop.org;
> > > > dri-devel@lists.freedesktop.org; daniel.vetter@ffwll.ch; Winkler,
> > > > Tomas <tomas.winkler@intel.com>; Shankar, Uma
> > > > <uma.shankar@intel.com>
> > > > Subject: Re: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> > > >
> > > > Tomas,
> > > >
> > > > Could you please help to review and give final "Go" for the series?
> > > >
> > > > Thanks
> > > > --Ram.
> > > >
> > > > On 2/21/2019 11:41 PM, Ramalingam C wrote:
> > > > > This series enables the HDCP2.2 Type 0 for I915. The sequence
> > > > > for
> > > > > HDCP2.2 authentication and encryption is implemented as a
> > > > > generic flow between HDMI and DP. Encoder specific
> > > > > implementations are moved into hdcp_shim.
> > > > >
> > > > > Intel HWs supports HDCP2.2 through ME FW. Hence this series
> > > > > introduces a client driver for mei bus, so that for HDCP2.2
> > > > > authentication,
> > > > > HDCP2.2 stack in I915 can avail the services from ME FW. To
> > > > > enable this client driver set the config variable
> CONFIG_INTEL_MEI_HDCP.
> > > > >
> > > > > Userspace interface remains unchanged as version agnostic. When
> > > > > userspace request for HDCP enable, Kernel will detect the HDCP
> > > > > source and sink's HDCP version(1.4/2.2)capability and enable the
> > > > > best capable version for that combination.
> > > > >
> > > > > This series enables the HDCP2.2 for Type0 content streams.
> > > > >
> > > > > Test-with:
> > > > > <1549566452-30175-1-git-send-email-ramalingam.c@intel.com>
> > > > > So that CP will be tested on BAT machine too.
> > > > >
> > > > > Major changes in v15
> > > > >    - All I915 patches are merged. So dropping them.
> > > > >    - Few minor suggestions are incorporated at mei changes.
> > > > >
> > > > > To ease the review process, series is hosted at
> > > > > https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v15
> > > > >
> > > > > Ramalingam C (15):
> > > > >    misc/mei/hdcp: Client driver for HDCP application
> > > > >    misc/mei/hdcp: Define ME FW interface for HDCP2.2
> > > > >    misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
> > > > >    misc/mei/hdcp: Verify Receiver Cert and prepare km
> > > > >    misc/mei/hdcp: Verify H_prime
> > > > >    misc/mei/hdcp: Store the HDCP Pairing info
> > > > >    misc/mei/hdcp: Initiate Locality check
> > > > >    misc/mei/hdcp: Verify L_prime
> > > > >    misc/mei/hdcp: Prepare Session Key
> > > > >    misc/mei/hdcp: Repeater topology verification and ack
> > > > >    misc/mei/hdcp: Verify M_prime
> > > > >    misc/mei/hdcp: Enabling the HDCP authentication
> > > > >    misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
> > > > >    misc/mei/hdcp: Component framework for I915 Interface
> > > > >    FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
> > > > >
> > > > > Tomas Winkler (1):
> > > > >    mei: bus: whitelist hdcp client
> > > > >
> > > > >   drivers/misc/mei/Kconfig         |  11 +
> > > > >   drivers/misc/mei/Makefile        |   2 +
> > > > >   drivers/misc/mei/bus-fixup.c     |  16 +
> > > > >   drivers/misc/mei/hdcp/Makefile   |   7 +
> > > > >   drivers/misc/mei/hdcp/mei_hdcp.c | 849
> > > > +++++++++++++++++++++++++++++++++++++++
> > > > >   drivers/misc/mei/hdcp/mei_hdcp.h | 377 +++++++++++++++++
> > > > >   6 files changed, 1262 insertions(+)
> > > > >   create mode 100644 drivers/misc/mei/hdcp/Makefile
> > > > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
> > > > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h
> > > > >
> >
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
Daniel Vetter Feb. 25, 2019, 5:54 p.m. UTC | #6
On Mon, Feb 25, 2019 at 03:13:04PM +0000, Winkler, Tomas wrote:
> > On Mon, Feb 25, 2019 at 05:12:09AM +0000, C, Ramalingam wrote:
> > > Tomas,
> > >
> > > Lkp issue is complaining about the header
> > > drm/i915_mei_hdcp_interface.h, Which is already merged in drm-tip
> > > through below commit. So don’t think this is a genuine issue. May be
> > > this build was tried in different tree, where this commit is not added yet?
> > 
> > Yeah our topic trees aren't pushed into linux-next, 0day can't find them.
> > Usually it will then fail to apply (and in that case it doesn't complain), but it
> > does complain if everything applies but doesn't build.
> > -Daniel
> > 
> > >
> > > commit 1626eab70ebc61d015e69a4bc3479d9228539343
> > > Author: Ramalingam C <ramalingam.c@intel.com>
> > > Date:   Fri Feb 15 14:04:58 2019 +0530
> > >
> > >     drm/i915: header for i915 - MEI_HDCP interface
> > >
> > > v15 is now part of github.
> 
> I'm okay to go with this.

Ok, merged all the 15 patches into a topic branch. Assuming nothing goes
wrong I'll send a pull to Greg tomorrow. And then it's up to him to take
it for 5.1 or delay for 5.2.

Thanks a lot for patches&review.
-Daniel

> Thanks
> Tomas
> 
> > >
> > > Best Regards,
> > > Ramalingam C
> > >
> > >
> > > > -----Original Message-----
> > > > From: Winkler, Tomas
> > > > Sent: Monday, February 25, 2019 1:45 AM
> > > > To: C, Ramalingam <ramalingam.c@intel.com>;
> > > > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> > > > daniel.vetter@ffwll.ch; Shankar, Uma <uma.shankar@intel.com>
> > > > Subject: RE: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> > > >
> > > > Have you fixed the lkp issue?
> > > > I didn't see you pushed the code to github.
> > > > Thanks
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: C, Ramalingam
> > > > > Sent: Sunday, February 24, 2019 18:33
> > > > > To: intel-gfx@lists.freedesktop.org;
> > > > > dri-devel@lists.freedesktop.org; daniel.vetter@ffwll.ch; Winkler,
> > > > > Tomas <tomas.winkler@intel.com>; Shankar, Uma
> > > > > <uma.shankar@intel.com>
> > > > > Subject: Re: [PATCH v15 00/16] drm/i915: Implement HDCP2.2
> > > > >
> > > > > Tomas,
> > > > >
> > > > > Could you please help to review and give final "Go" for the series?
> > > > >
> > > > > Thanks
> > > > > --Ram.
> > > > >
> > > > > On 2/21/2019 11:41 PM, Ramalingam C wrote:
> > > > > > This series enables the HDCP2.2 Type 0 for I915. The sequence
> > > > > > for
> > > > > > HDCP2.2 authentication and encryption is implemented as a
> > > > > > generic flow between HDMI and DP. Encoder specific
> > > > > > implementations are moved into hdcp_shim.
> > > > > >
> > > > > > Intel HWs supports HDCP2.2 through ME FW. Hence this series
> > > > > > introduces a client driver for mei bus, so that for HDCP2.2
> > > > > > authentication,
> > > > > > HDCP2.2 stack in I915 can avail the services from ME FW. To
> > > > > > enable this client driver set the config variable
> > CONFIG_INTEL_MEI_HDCP.
> > > > > >
> > > > > > Userspace interface remains unchanged as version agnostic. When
> > > > > > userspace request for HDCP enable, Kernel will detect the HDCP
> > > > > > source and sink's HDCP version(1.4/2.2)capability and enable the
> > > > > > best capable version for that combination.
> > > > > >
> > > > > > This series enables the HDCP2.2 for Type0 content streams.
> > > > > >
> > > > > > Test-with:
> > > > > > <1549566452-30175-1-git-send-email-ramalingam.c@intel.com>
> > > > > > So that CP will be tested on BAT machine too.
> > > > > >
> > > > > > Major changes in v15
> > > > > >    - All I915 patches are merged. So dropping them.
> > > > > >    - Few minor suggestions are incorporated at mei changes.
> > > > > >
> > > > > > To ease the review process, series is hosted at
> > > > > > https://github.com/ramalingampc2008/drm-tip.git hdcp2_2_v15
> > > > > >
> > > > > > Ramalingam C (15):
> > > > > >    misc/mei/hdcp: Client driver for HDCP application
> > > > > >    misc/mei/hdcp: Define ME FW interface for HDCP2.2
> > > > > >    misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
> > > > > >    misc/mei/hdcp: Verify Receiver Cert and prepare km
> > > > > >    misc/mei/hdcp: Verify H_prime
> > > > > >    misc/mei/hdcp: Store the HDCP Pairing info
> > > > > >    misc/mei/hdcp: Initiate Locality check
> > > > > >    misc/mei/hdcp: Verify L_prime
> > > > > >    misc/mei/hdcp: Prepare Session Key
> > > > > >    misc/mei/hdcp: Repeater topology verification and ack
> > > > > >    misc/mei/hdcp: Verify M_prime
> > > > > >    misc/mei/hdcp: Enabling the HDCP authentication
> > > > > >    misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
> > > > > >    misc/mei/hdcp: Component framework for I915 Interface
> > > > > >    FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915
> > > > > >
> > > > > > Tomas Winkler (1):
> > > > > >    mei: bus: whitelist hdcp client
> > > > > >
> > > > > >   drivers/misc/mei/Kconfig         |  11 +
> > > > > >   drivers/misc/mei/Makefile        |   2 +
> > > > > >   drivers/misc/mei/bus-fixup.c     |  16 +
> > > > > >   drivers/misc/mei/hdcp/Makefile   |   7 +
> > > > > >   drivers/misc/mei/hdcp/mei_hdcp.c | 849
> > > > > +++++++++++++++++++++++++++++++++++++++
> > > > > >   drivers/misc/mei/hdcp/mei_hdcp.h | 377 +++++++++++++++++
> > > > > >   6 files changed, 1262 insertions(+)
> > > > > >   create mode 100644 drivers/misc/mei/hdcp/Makefile
> > > > > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.c
> > > > > >   create mode 100644 drivers/misc/mei/hdcp/mei_hdcp.h
> > > > > >
> > >
> > 
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch