| Message ID | 20190223063434.6793-7-joel@joelfernandes.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RCU fixes for rcu_assign_pointer() usage | expand |
On Sat, Feb 23, 2019 at 01:34:34AM -0500, Joel Fernandes (Google) wrote: > This fixes the following sparse errors in sched/fair.c: > > fair.c:6506:14: error: incompatible types in comparison expression > fair.c:8642:21: error: incompatible types in comparison expression > > Using __rcu will also help sparse catch any future bugs. > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> From an RCU perspective: Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com> > --- > kernel/sched/sched.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index ca6a79f57e7a..c8e6514433a9 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -780,7 +780,7 @@ struct root_domain { > * NULL-terminated list of performance domains intersecting with the > * CPUs of the rd. Protected by RCU. > */ > - struct perf_domain *pd; > + struct perf_domain __rcu *pd; > }; > > extern struct root_domain def_root_domain; > -- > 2.21.0.rc0.258.g878e2cd30e-goog >
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index ca6a79f57e7a..c8e6514433a9 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -780,7 +780,7 @@ struct root_domain { * NULL-terminated list of performance domains intersecting with the * CPUs of the rd. Protected by RCU. */ - struct perf_domain *pd; + struct perf_domain __rcu *pd; }; extern struct root_domain def_root_domain;
This fixes the following sparse errors in sched/fair.c: fair.c:6506:14: error: incompatible types in comparison expression fair.c:8642:21: error: incompatible types in comparison expression Using __rcu will also help sparse catch any future bugs. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> --- kernel/sched/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)