| Message ID | 20190227170608.27963-21-steven.price@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert x86 & arm64 to use generic page walk | expand |
From: Steven Price <steven.price@arm.com> Date: Wed, 27 Feb 2019 17:05:54 +0000 > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information is provided by the > p?d_large() functions/macros. > > For sparc, we don't support large pages, so add stubs returning 0. > > CC: "David S. Miller" <davem@davemloft.net> > CC: sparclinux@vger.kernel.org > Signed-off-by: Steven Price <steven.price@arm.com> Sparc does support large pages on 64-bit, just not at this level. It would be nice if the commit message was made more accurate. Other than that: Acked-by: David S. Miller <davem@davemloft.net>
On 27/02/2019 18:38, David Miller wrote: > From: Steven Price <steven.price@arm.com> > Date: Wed, 27 Feb 2019 17:05:54 +0000 > >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is provided by the >> p?d_large() functions/macros. >> >> For sparc, we don't support large pages, so add stubs returning 0. >> >> CC: "David S. Miller" <davem@davemloft.net> >> CC: sparclinux@vger.kernel.org >> Signed-off-by: Steven Price <steven.price@arm.com> > > Sparc does support large pages on 64-bit, just not at this level. It > would be nice if the commit message was made more accurate. Yes you are right, I fear I only looked at the 32 bit changes when I wrote the commit message. I'll clarify the difference between 32/64 bit. > Other than that: > > Acked-by: David S. Miller <davem@davemloft.net> Thanks, Steve
diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h index 4eebed6c6781..dbc533e4c460 100644 --- a/arch/sparc/include/asm/pgtable_32.h +++ b/arch/sparc/include/asm/pgtable_32.h @@ -177,6 +177,11 @@ static inline int pmd_none(pmd_t pmd) return !pmd_val(pmd); } +static inline int pmd_large(pmd_t pmd) +{ + return 0; +} + static inline void pmd_clear(pmd_t *pmdp) { int i; @@ -199,6 +204,11 @@ static inline int pgd_present(pgd_t pgd) return ((pgd_val(pgd) & SRMMU_ET_MASK) == SRMMU_ET_PTD); } +static inline int pgd_large(pgd_t pgd) +{ + return 0; +} + static inline void pgd_clear(pgd_t *pgdp) { set_pte((pte_t *)pgdp, __pte(0)); diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index 1393a8ac596b..c32b26bdea53 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -892,6 +892,7 @@ static inline unsigned long pud_page_vaddr(pud_t pud) #define pgd_page_vaddr(pgd) \ ((unsigned long) __va(pgd_val(pgd))) #define pgd_present(pgd) (pgd_val(pgd) != 0U) +#define pgd_large(pgd) (0) #define pgd_clear(pgdp) (pgd_val(*(pgdp)) = 0UL) static inline unsigned long pud_large(pud_t pud)
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For sparc, we don't support large pages, so add stubs returning 0. CC: "David S. Miller" <davem@davemloft.net> CC: sparclinux@vger.kernel.org Signed-off-by: Steven Price <steven.price@arm.com> --- arch/sparc/include/asm/pgtable_32.h | 10 ++++++++++ arch/sparc/include/asm/pgtable_64.h | 1 + 2 files changed, 11 insertions(+)