| Message ID | 20190227170608.27963-10-steven.price@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert x86 & arm64 to use generic page walk | expand |
Hi Steven, On Wed, Feb 27, 2019 at 6:07 PM Steven Price <steven.price@arm.com> wrote: > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information is provided by the > p?d_large() functions/macros. > > For m68k, we don't support large pages, so add stubs returning 0 > > CC: Geert Uytterhoeven <geert@linux-m68k.org> > CC: linux-m68k@lists.linux-m68k.org > Signed-off-by: Steven Price <steven.price@arm.com> Thanks for your patch! > arch/m68k/include/asm/mcf_pgtable.h | 2 ++ > arch/m68k/include/asm/motorola_pgtable.h | 2 ++ > arch/m68k/include/asm/pgtable_no.h | 1 + > arch/m68k/include/asm/sun3_pgtable.h | 2 ++ > 4 files changed, 7 insertions(+) If the definitions are the same, why not add them to arch/m68k/include/asm/pgtable.h instead? Gr{oetje,eeting}s, Geert
Hi, On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: > Hi Steven, > > On Wed, Feb 27, 2019 at 6:07 PM Steven Price <steven.price@arm.com> wrote: > > walk_page_range() is going to be allowed to walk page tables other than > > those of user space. For this it needs to know when it has reached a > > 'leaf' entry in the page tables. This information is provided by the > > p?d_large() functions/macros. > > > > For m68k, we don't support large pages, so add stubs returning 0 > > > > CC: Geert Uytterhoeven <geert@linux-m68k.org> > > CC: linux-m68k@lists.linux-m68k.org > > Signed-off-by: Steven Price <steven.price@arm.com> > > Thanks for your patch! > > > arch/m68k/include/asm/mcf_pgtable.h | 2 ++ > > arch/m68k/include/asm/motorola_pgtable.h | 2 ++ > > arch/m68k/include/asm/pgtable_no.h | 1 + > > arch/m68k/include/asm/sun3_pgtable.h | 2 ++ > > 4 files changed, 7 insertions(+) > > If the definitions are the same, why not add them to > arch/m68k/include/asm/pgtable.h instead? Maybe I'm missing something, but why the stubs have to be defined in arch/*/include/asm/pgtable.h rather than in include/asm-generic/pgtable.h? > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
Hi Mike, On Thu, Feb 28, 2019 at 12:37 PM Mike Rapoport <rppt@linux.ibm.com> wrote: > On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: > > On Wed, Feb 27, 2019 at 6:07 PM Steven Price <steven.price@arm.com> wrote: > > > walk_page_range() is going to be allowed to walk page tables other than > > > those of user space. For this it needs to know when it has reached a > > > 'leaf' entry in the page tables. This information is provided by the > > > p?d_large() functions/macros. > > > > > > For m68k, we don't support large pages, so add stubs returning 0 > > > > > > CC: Geert Uytterhoeven <geert@linux-m68k.org> > > > CC: linux-m68k@lists.linux-m68k.org > > > Signed-off-by: Steven Price <steven.price@arm.com> > > > > Thanks for your patch! > > > > > arch/m68k/include/asm/mcf_pgtable.h | 2 ++ > > > arch/m68k/include/asm/motorola_pgtable.h | 2 ++ > > > arch/m68k/include/asm/pgtable_no.h | 1 + > > > arch/m68k/include/asm/sun3_pgtable.h | 2 ++ > > > 4 files changed, 7 insertions(+) > > > > If the definitions are the same, why not add them to > > arch/m68k/include/asm/pgtable.h instead? > > Maybe I'm missing something, but why the stubs have to be defined in > arch/*/include/asm/pgtable.h rather than in include/asm-generic/pgtable.h? That would even make more sense, given most architectures don't support huge pages. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 28/02/2019 11:53, Geert Uytterhoeven wrote: > Hi Mike, > > On Thu, Feb 28, 2019 at 12:37 PM Mike Rapoport <rppt@linux.ibm.com> wrote: >> On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: >>> On Wed, Feb 27, 2019 at 6:07 PM Steven Price <steven.price@arm.com> wrote: >>>> walk_page_range() is going to be allowed to walk page tables other than >>>> those of user space. For this it needs to know when it has reached a >>>> 'leaf' entry in the page tables. This information is provided by the >>>> p?d_large() functions/macros. >>>> >>>> For m68k, we don't support large pages, so add stubs returning 0 >>>> >>>> CC: Geert Uytterhoeven <geert@linux-m68k.org> >>>> CC: linux-m68k@lists.linux-m68k.org >>>> Signed-off-by: Steven Price <steven.price@arm.com> >>> >>> Thanks for your patch! >>> >>>> arch/m68k/include/asm/mcf_pgtable.h | 2 ++ >>>> arch/m68k/include/asm/motorola_pgtable.h | 2 ++ >>>> arch/m68k/include/asm/pgtable_no.h | 1 + >>>> arch/m68k/include/asm/sun3_pgtable.h | 2 ++ >>>> 4 files changed, 7 insertions(+) >>> >>> If the definitions are the same, why not add them to >>> arch/m68k/include/asm/pgtable.h instead? I don't really understand the structure of m68k, so I just followed the existing layout (arch/m68k/include/asm/pgtable.h is basically empty). I believe the following patch would be functionally equivalent. ----8<---- diff --git a/arch/m68k/include/asm/pgtable.h b/arch/m68k/include/asm/pgtable.h index ad15d655a9bf..6f6d463e69c1 100644 --- a/arch/m68k/include/asm/pgtable.h +++ b/arch/m68k/include/asm/pgtable.h @@ -3,4 +3,9 @@ #include <asm/pgtable_no.h> #else #include <asm/pgtable_mm.h> + +#define pmd_large(pmd) (0) + #endif + +#define pgd_large(pgd) (0) ----8<---- Let me know if you'd prefer that >> Maybe I'm missing something, but why the stubs have to be defined in >> arch/*/include/asm/pgtable.h rather than in include/asm-generic/pgtable.h? > > That would even make more sense, given most architectures don't > support huge pages. Where the architecture has folded a level stubs are provided by the asm-generic layer, see this later patch: https://lore.kernel.org/lkml/20190227170608.27963-25-steven.price@arm.com/ However just because an architecture port doesn't (currently) support huge pages doesn't mean that the architecture itself can't have large[1] mappings at higher levels of the page table. For instance an architecture might use large pages for the linear map but not support huge page mappings for user space. My previous posting of this series attempted to define generic versions of p?d_large(), but it was pointed out to me that this was fragile and having a way of knowing whether the page table was a 'leaf' is actually useful, so I've attempted to implement for all architectures. See the discussion here: https://lore.kernel.org/lkml/20190221113502.54153-1-steven.price@arm.com/T/#mf0bd0155f185a19681b48a288be212ed1596e85d Steve [1] Note I've tried to use the term "large page" where I mean that page table walk terminates early, and "huge page" for the Linux concept of combining a large area of memory to reduce TLB pressure. Some architectures have ways of mapping a large block in the TLB without reducing the number of levels in the table walk - for example contiguous hint bits in the page table entries.
On Thu, Feb 28, 2019 at 12:04:08PM +0000, Steven Price wrote: > On 28/02/2019 11:53, Geert Uytterhoeven wrote: > > Hi Mike, > > > > On Thu, Feb 28, 2019 at 12:37 PM Mike Rapoport <rppt@linux.ibm.com> wrote: > >> On Wed, Feb 27, 2019 at 08:27:40PM +0100, Geert Uytterhoeven wrote: > >>> On Wed, Feb 27, 2019 at 6:07 PM Steven Price <steven.price@arm.com> wrote: > >>>> walk_page_range() is going to be allowed to walk page tables other than > >>>> those of user space. For this it needs to know when it has reached a > >>>> 'leaf' entry in the page tables. This information is provided by the > >>>> p?d_large() functions/macros. > >>>> > >>>> For m68k, we don't support large pages, so add stubs returning 0 > >>>> > >>>> CC: Geert Uytterhoeven <geert@linux-m68k.org> > >>>> CC: linux-m68k@lists.linux-m68k.org > >>>> Signed-off-by: Steven Price <steven.price@arm.com> > >>> > >>> Thanks for your patch! > >>> > >>>> arch/m68k/include/asm/mcf_pgtable.h | 2 ++ > >>>> arch/m68k/include/asm/motorola_pgtable.h | 2 ++ > >>>> arch/m68k/include/asm/pgtable_no.h | 1 + > >>>> arch/m68k/include/asm/sun3_pgtable.h | 2 ++ > >>>> 4 files changed, 7 insertions(+) > >>> > >> Maybe I'm missing something, but why the stubs have to be defined in > >> arch/*/include/asm/pgtable.h rather than in include/asm-generic/pgtable.h? > > > > That would even make more sense, given most architectures don't > > support huge pages. > > Where the architecture has folded a level stubs are provided by the > asm-generic layer, see this later patch: > > https://lore.kernel.org/lkml/20190227170608.27963-25-steven.price@arm.com/ > > However just because an architecture port doesn't (currently) support > huge pages doesn't mean that the architecture itself can't have large[1] > mappings at higher levels of the page table. For instance an > architecture might use large pages for the linear map but not support > huge page mappings for user space. Well, I doubt m68k can support large mappings at higher levels at all. This, IMHO, applies to many other architectures and spreading p?d_large all over those architecture seems wrong to me... > My previous posting of this series attempted to define generic versions > of p?d_large(), but it was pointed out to me that this was fragile and > having a way of knowing whether the page table was a 'leaf' is actually > useful, so I've attempted to implement for all architectures. See the > discussion here: > https://lore.kernel.org/lkml/20190221113502.54153-1-steven.price@arm.com/T/#mf0bd0155f185a19681b48a288be212ed1596e85d I'll reply on that thread, somehow I missed it then. > Steve >
diff --git a/arch/m68k/include/asm/mcf_pgtable.h b/arch/m68k/include/asm/mcf_pgtable.h index 5d5502cb2b2d..63827d28a017 100644 --- a/arch/m68k/include/asm/mcf_pgtable.h +++ b/arch/m68k/include/asm/mcf_pgtable.h @@ -196,11 +196,13 @@ static inline int pmd_none2(pmd_t *pmd) { return !pmd_val(*pmd); } static inline int pmd_bad2(pmd_t *pmd) { return 0; } #define pmd_bad(pmd) pmd_bad2(&(pmd)) #define pmd_present(pmd) (!pmd_none2(&(pmd))) +#define pmd_large(pmd) (0) static inline void pmd_clear(pmd_t *pmdp) { pmd_val(*pmdp) = 0; } static inline int pgd_none(pgd_t pgd) { return 0; } static inline int pgd_bad(pgd_t pgd) { return 0; } static inline int pgd_present(pgd_t pgd) { return 1; } +static inline int pgd_large(pgd_t pgd) { return 0; } static inline void pgd_clear(pgd_t *pgdp) {} #define pte_ERROR(e) \ diff --git a/arch/m68k/include/asm/motorola_pgtable.h b/arch/m68k/include/asm/motorola_pgtable.h index 7f66a7bad7a5..a649eb8a91de 100644 --- a/arch/m68k/include/asm/motorola_pgtable.h +++ b/arch/m68k/include/asm/motorola_pgtable.h @@ -138,6 +138,7 @@ static inline void pgd_set(pgd_t *pgdp, pmd_t *pmdp) #define pmd_none(pmd) (!pmd_val(pmd)) #define pmd_bad(pmd) ((pmd_val(pmd) & _DESCTYPE_MASK) != _PAGE_TABLE) #define pmd_present(pmd) (pmd_val(pmd) & _PAGE_TABLE) +#define pmd_large(pmd) (0) #define pmd_clear(pmdp) ({ \ unsigned long *__ptr = pmdp->pmd; \ short __i = 16; \ @@ -150,6 +151,7 @@ static inline void pgd_set(pgd_t *pgdp, pmd_t *pmdp) #define pgd_none(pgd) (!pgd_val(pgd)) #define pgd_bad(pgd) ((pgd_val(pgd) & _DESCTYPE_MASK) != _PAGE_TABLE) #define pgd_present(pgd) (pgd_val(pgd) & _PAGE_TABLE) +#define pgd_large(pgd) (0) #define pgd_clear(pgdp) ({ pgd_val(*pgdp) = 0; }) #define pgd_page(pgd) (mem_map + ((unsigned long)(__va(pgd_val(pgd)) - PAGE_OFFSET) >> PAGE_SHIFT)) diff --git a/arch/m68k/include/asm/pgtable_no.h b/arch/m68k/include/asm/pgtable_no.h index fc3a96c77bd8..eeef17b2eae8 100644 --- a/arch/m68k/include/asm/pgtable_no.h +++ b/arch/m68k/include/asm/pgtable_no.h @@ -17,6 +17,7 @@ * Trivial page table functions. */ #define pgd_present(pgd) (1) +#define pgd_large(pgd) (0) #define pgd_none(pgd) (0) #define pgd_bad(pgd) (0) #define pgd_clear(pgdp) diff --git a/arch/m68k/include/asm/sun3_pgtable.h b/arch/m68k/include/asm/sun3_pgtable.h index c987d50866b4..eea72e3515db 100644 --- a/arch/m68k/include/asm/sun3_pgtable.h +++ b/arch/m68k/include/asm/sun3_pgtable.h @@ -143,6 +143,7 @@ static inline int pmd_bad2 (pmd_t *pmd) { return 0; } static inline int pmd_present2 (pmd_t *pmd) { return pmd_val (*pmd) & SUN3_PMD_VALID; } /* #define pmd_present(pmd) pmd_present2(&(pmd)) */ #define pmd_present(pmd) (!pmd_none2(&(pmd))) +#define pmd_large(pmd) (0) static inline void pmd_clear (pmd_t *pmdp) { pmd_val (*pmdp) = 0; } static inline int pgd_none (pgd_t pgd) { return 0; } @@ -150,6 +151,7 @@ static inline int pgd_bad (pgd_t pgd) { return 0; } static inline int pgd_present (pgd_t pgd) { return 1; } static inline void pgd_clear (pgd_t *pgdp) {} +static inline int pgd_large(pgd_t pgd) { return 0; } #define pte_ERROR(e) \ pr_err("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, pte_val(e))
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For m68k, we don't support large pages, so add stubs returning 0 CC: Geert Uytterhoeven <geert@linux-m68k.org> CC: linux-m68k@lists.linux-m68k.org Signed-off-by: Steven Price <steven.price@arm.com> --- arch/m68k/include/asm/mcf_pgtable.h | 2 ++ arch/m68k/include/asm/motorola_pgtable.h | 2 ++ arch/m68k/include/asm/pgtable_no.h | 1 + arch/m68k/include/asm/sun3_pgtable.h | 2 ++ 4 files changed, 7 insertions(+)