| Message ID | 20190223211928.9899-1-howl.nsp@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330 | expand |
Done Jani. I think it's ok now. Don't worry, at least I could get little familiar with git send-email also with multiple patches :) El sáb., 23 feb. 2019 a las 22:19, David Santamaría Rogado (<howl.nsp@gmail.com>) escribió: > > Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. > Console output gets rotated at boot as Miix 310. > > Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com> > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c > index 52e445bb1aa5..521aff99b08a 100644 > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { > .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > }; > > +static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = { > + .width = 1200, > + .height = 1920, > + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > +}; > + > static const struct dmi_system_id orientation_data[] = { > { /* Acer One 10 (S1003) */ > .matches = { > @@ -148,6 +154,13 @@ static const struct dmi_system_id orientation_data[] = { > DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), > }, > .driver_data = (void *)&lcd800x1280_rightside_up, > + }, { /* Lenovo Ideapad D330 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), > + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), > + }, > + .driver_data = (void *)&lcd1200x1920_rightside_up, > }, { /* VIOS LTH17 */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), > -- > 2.20.1 >
On Sat, 23 Feb 2019, David Santamaría Rogado <howl.nsp@gmail.com> wrote: > Done Jani. I think it's ok now. Don't worry, at least I could get > little familiar with git send-email also with multiple patches :) Sorry about all the hassle, pushed to drm-misc-next, thanks for the patch. BR, Jani. > > El sáb., 23 feb. 2019 a las 22:19, David Santamaría Rogado > (<howl.nsp@gmail.com>) escribió: >> >> Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. >> Console output gets rotated at boot as Miix 310. >> >> Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com> >> --- >> drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> index 52e445bb1aa5..521aff99b08a 100644 >> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c >> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { >> .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, >> }; >> >> +static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = { >> + .width = 1200, >> + .height = 1920, >> + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, >> +}; >> + >> static const struct dmi_system_id orientation_data[] = { >> { /* Acer One 10 (S1003) */ >> .matches = { >> @@ -148,6 +154,13 @@ static const struct dmi_system_id orientation_data[] = { >> DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), >> }, >> .driver_data = (void *)&lcd800x1280_rightside_up, >> + }, { /* Lenovo Ideapad D330 */ >> + .matches = { >> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), >> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), >> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), >> + }, >> + .driver_data = (void *)&lcd1200x1920_rightside_up, >> }, { /* VIOS LTH17 */ >> .matches = { >> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), >> -- >> 2.20.1 >>
Hi Jani, When are the changes in drm-misc-next pushed? I'm testing recent kernels that don't work with some models because the dsi display problem you are aware. Works with 4.15 but not with more recent kernels. The model I have by going to sleep state and awake it gets the display on, I want to see if this change makes the display behave different in recent kernels in more ways than only rotating the display. Thanks in advance. El vie., 1 mar. 2019 a las 11:12, Jani Nikula (<jani.nikula@linux.intel.com>) escribió: > > On Sat, 23 Feb 2019, David Santamaría Rogado <howl.nsp@gmail.com> wrote: > > Done Jani. I think it's ok now. Don't worry, at least I could get > > little familiar with git send-email also with multiple patches :) > > Sorry about all the hassle, pushed to drm-misc-next, thanks for the > patch. > > BR, > Jani. > > > > > El sáb., 23 feb. 2019 a las 22:19, David Santamaría Rogado > > (<howl.nsp@gmail.com>) escribió: > >> > >> Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. > >> Console output gets rotated at boot as Miix 310. > >> > >> Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com> > >> --- > >> drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ > >> 1 file changed, 13 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c > >> index 52e445bb1aa5..521aff99b08a 100644 > >> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > >> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > >> @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { > >> .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > >> }; > >> > >> +static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = { > >> + .width = 1200, > >> + .height = 1920, > >> + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > >> +}; > >> + > >> static const struct dmi_system_id orientation_data[] = { > >> { /* Acer One 10 (S1003) */ > >> .matches = { > >> @@ -148,6 +154,13 @@ static const struct dmi_system_id orientation_data[] = { > >> DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), > >> }, > >> .driver_data = (void *)&lcd800x1280_rightside_up, > >> + }, { /* Lenovo Ideapad D330 */ > >> + .matches = { > >> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), > >> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), > >> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), > >> + }, > >> + .driver_data = (void *)&lcd1200x1920_rightside_up, > >> }, { /* VIOS LTH17 */ > >> .matches = { > >> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), > >> -- > >> 2.20.1 > >> > > -- > Jani Nikula, Intel Open Source Graphics Center
On Tue, 23 Apr 2019, David Santamaría Rogado <howl.nsp@gmail.com> wrote: > Hi Jani, > > When are the changes in drm-misc-next pushed? > > I'm testing recent kernels that don't work with some models because > the dsi display problem you are aware. Works with 4.15 but not with > more recent kernels. > > The model I have by going to sleep state and awake it gets the display on, > I want to see if this change makes the display behave different in recent > kernels in more ways than only rotating the display. The patches are headed for v5.2. In retrospect could've added them to drm-misc-fixes, but regardless we can still make the backport request to older kernel once it hits upstream. BR, Jani. > > Thanks in advance. > > El vie., 1 mar. 2019 a las 11:12, Jani Nikula > (<jani.nikula@linux.intel.com>) escribió: >> >> On Sat, 23 Feb 2019, David Santamaría Rogado <howl.nsp@gmail.com> wrote: >> > Done Jani. I think it's ok now. Don't worry, at least I could get >> > little familiar with git send-email also with multiple patches :) >> >> Sorry about all the hassle, pushed to drm-misc-next, thanks for the >> patch. >> >> BR, >> Jani. >> >> > >> > El sáb., 23 feb. 2019 a las 22:19, David Santamaría Rogado >> > (<howl.nsp@gmail.com>) escribió: >> >> >> >> Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. >> >> Console output gets rotated at boot as Miix 310. >> >> >> >> Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com> >> >> --- >> >> drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ >> >> 1 file changed, 13 insertions(+) >> >> >> >> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> >> index 52e445bb1aa5..521aff99b08a 100644 >> >> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c >> >> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> >> @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { >> >> .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, >> >> }; >> >> >> >> +static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = { >> >> + .width = 1200, >> >> + .height = 1920, >> >> + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, >> >> +}; >> >> + >> >> static const struct dmi_system_id orientation_data[] = { >> >> { /* Acer One 10 (S1003) */ >> >> .matches = { >> >> @@ -148,6 +154,13 @@ static const struct dmi_system_id orientation_data[] = { >> >> DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), >> >> }, >> >> .driver_data = (void *)&lcd800x1280_rightside_up, >> >> + }, { /* Lenovo Ideapad D330 */ >> >> + .matches = { >> >> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), >> >> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), >> >> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), >> >> + }, >> >> + .driver_data = (void *)&lcd1200x1920_rightside_up, >> >> }, { /* VIOS LTH17 */ >> >> .matches = { >> >> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), >> >> -- >> >> 2.20.1 >> >> >> >> -- >> Jani Nikula, Intel Open Source Graphics Center
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 52e445bb1aa5..521aff99b08a 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, }; +static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = { + .width = 1200, + .height = 1920, + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, +}; + static const struct dmi_system_id orientation_data[] = { { /* Acer One 10 (S1003) */ .matches = { @@ -148,6 +154,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, .driver_data = (void *)&lcd800x1280_rightside_up, + }, { /* Lenovo Ideapad D330 */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), + }, + .driver_data = (void *)&lcd1200x1920_rightside_up, }, { /* VIOS LTH17 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console output gets rotated at boot as Miix 310. Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)