| Message ID | 1536589878-26218-2-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add VIN support to RZ/G2M | expand |
Hi Biju, Thanks for your work. On 2018-09-10 15:31:14 +0100, Biju Das wrote: > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > index 2d385b6..12fe685 100644 > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 > ------------------------ > > The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the > -Renesas R-Car family of devices. It is used in conjunction with the > -R-Car VIN module, which provides the video capture capabilities. > +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction > +with the R-Car VIN module, which provides the video capture capabilities. > > Mandatory properties > -------------------- > - compatible: Must be one or more of the following > + - "renesas,r8a774a1-csi2" for the R8A774A1 device. > - "renesas,r8a7795-csi2" for the R8A7795 device. > - "renesas,r8a7796-csi2" for the R8A7796 device. > - "renesas,r8a77965-csi2" for the R8A77965 device. > -- > 2.7.4 >
Dear All, Who is the best person to take this patch? Thanks, Fab > From: Biju Das <biju.das@bp.renesas.com> > Sent: 10 September 2018 15:31 > Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > --- > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > index 2d385b6..12fe685 100644 > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 > ------------------------ > > The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the > -Renesas R-Car family of devices. It is used in conjunction with the > -R-Car VIN module, which provides the video capture capabilities. > +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction > +with the R-Car VIN module, which provides the video capture capabilities. > > Mandatory properties > -------------------- > - compatible: Must be one or more of the following > + - "renesas,r8a774a1-csi2" for the R8A774A1 device. > - "renesas,r8a7795-csi2" for the R8A7795 device. > - "renesas,r8a7796-csi2" for the R8A7796 device. > - "renesas,r8a77965-csi2" for the R8A77965 device. > -- > 2.7.4 Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Thu, Nov 08, 2018 at 12:50:22PM +0000, Fabrizio Castro wrote: > Dear All, > > Who is the best person to take this patch? I believe this patch is for Mauro.
On Mon, Sep 10, 2018 at 03:31:14PM +0100, Biju Das wrote: > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Hello Mauro, Does this patch look ok to you? Thanks, Fab > From: Biju Das <biju.das@bp.renesas.com> > Sent: 10 September 2018 15:31 > Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > --- > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > index 2d385b6..12fe685 100644 > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 > ------------------------ > > The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the > -Renesas R-Car family of devices. It is used in conjunction with the > -R-Car VIN module, which provides the video capture capabilities. > +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction > +with the R-Car VIN module, which provides the video capture capabilities. > > Mandatory properties > -------------------- > - compatible: Must be one or more of the following > + - "renesas,r8a774a1-csi2" for the R8A774A1 device. > - "renesas,r8a7795-csi2" for the R8A7795 device. > - "renesas,r8a7796-csi2" for the R8A7796 device. > - "renesas,r8a77965-csi2" for the R8A77965 device. > -- > 2.7.4 Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Thank you Simon for getting back to me. Cheers, Fab > Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > On Thu, Nov 08, 2018 at 12:50:22PM +0000, Fabrizio Castro wrote: > > Dear All, > > > > Who is the best person to take this patch? > > I believe this patch is for Mauro. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello Mauro, This is a gentle reminder. Thanks, Fab > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Fabrizio Castro > Sent: 08 November 2018 14:19 > Subject: RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > Hello Mauro, > > Does this patch look ok to you? > > Thanks, > Fab > > > From: Biju Das <biju.das@bp.renesas.com> > > Sent: 10 September 2018 15:31 > > Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > > > Document RZ/G2M (R8A774A1) SoC bindings. > > > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > > b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > > index 2d385b6..12fe685 100644 > > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > > @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 > > ------------------------ > > > > The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the > > -Renesas R-Car family of devices. It is used in conjunction with the > > -R-Car VIN module, which provides the video capture capabilities. > > +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction > > +with the R-Car VIN module, which provides the video capture capabilities. > > > > Mandatory properties > > -------------------- > > - compatible: Must be one or more of the following > > + - "renesas,r8a774a1-csi2" for the R8A774A1 device. > > - "renesas,r8a7795-csi2" for the R8A7795 device. > > - "renesas,r8a7796-csi2" for the R8A7796 device. > > - "renesas,r8a77965-csi2" for the R8A77965 device. > > -- > > 2.7.4 > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & > Wales under Registered No. 04586709. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello Mauro, This patch has been around for some time now, do you think you can take it? Cheers, Fab > From: Biju Das <biju.das@bp.renesas.com> > Sent: 10 September 2018 15:31 > Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > --- > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > index 2d385b6..12fe685 100644 > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 > ------------------------ > > The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the > -Renesas R-Car family of devices. It is used in conjunction with the > -R-Car VIN module, which provides the video capture capabilities. > +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction > +with the R-Car VIN module, which provides the video capture capabilities. > > Mandatory properties > -------------------- > - compatible: Must be one or more of the following > + - "renesas,r8a774a1-csi2" for the R8A774A1 device. > - "renesas,r8a7795-csi2" for the R8A7795 device. > - "renesas,r8a7796-csi2" for the R8A7796 device. > - "renesas,r8a77965-csi2" for the R8A77965 device. > -- > 2.7.4
Hi Fabrizio, It looks like this series fell through the cracks. I looked at it and the main problem is that it is missing a Reviewed-by from Rob Herring (devicetree maintainer). It's a bit surprising since he is usually fairly prompt. I recommend that you rebase and repost it and I'll delegate the v2 series to me so we can hopefully get it in for 5.2 (5.1 is likely too late) once Rob reviews it. BTW, I'm the one who usually processes rcar patches. But it was delegated in patchwork to Laurent, so I never saw it. Regards, Hans On 3/1/19 1:09 PM, Fabrizio Castro wrote: > Hello Mauro, > > This patch has been around for some time now, do you think you can take it? > > Cheers, > Fab > >> From: Biju Das <biju.das@bp.renesas.com> >> Sent: 10 September 2018 15:31 >> Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support >> >> Document RZ/G2M (R8A774A1) SoC bindings. >> >> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). >> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> >> --- >> Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt >> b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt >> index 2d385b6..12fe685 100644 >> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt >> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt >> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 >> ------------------------ >> >> The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the >> -Renesas R-Car family of devices. It is used in conjunction with the >> -R-Car VIN module, which provides the video capture capabilities. >> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction >> +with the R-Car VIN module, which provides the video capture capabilities. >> >> Mandatory properties >> -------------------- >> - compatible: Must be one or more of the following >> + - "renesas,r8a774a1-csi2" for the R8A774A1 device. >> - "renesas,r8a7795-csi2" for the R8A7795 device. >> - "renesas,r8a7796-csi2" for the R8A7796 device. >> - "renesas,r8a77965-csi2" for the R8A77965 device. >> -- >> 2.7.4 >
Hi Hans, On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: > It looks like this series fell through the cracks. > > I looked at it and the main problem is that it is missing a Reviewed-by > from Rob Herring (devicetree maintainer). It's a bit surprising since he > is usually fairly prompt. He actually did provide his Rb on Sep 17. Gr{oetje,eeting}s, Geert
Hi Hans, On Fri, Mar 01, 2019 at 01:55:53PM +0100, Hans Verkuil wrote: > Hi Fabrizio, > > It looks like this series fell through the cracks. > > I looked at it and the main problem is that it is missing a Reviewed-by > from Rob Herring (devicetree maintainer). It's a bit surprising since he > is usually fairly prompt. > > I recommend that you rebase and repost it and I'll delegate the v2 series > to me so we can hopefully get it in for 5.2 (5.1 is likely too late) once > Rob reviews it. > > BTW, I'm the one who usually processes rcar patches. But it was delegated in > patchwork to Laurent, so I never saw it. I handle the VSP and FDP patches. I propose delegating the CSI-2 and VIN to Niklas. > On 3/1/19 1:09 PM, Fabrizio Castro wrote: > > Hello Mauro, > > > > This patch has been around for some time now, do you think you can take it? > > > > Cheers, > > Fab > > > >> From: Biju Das <biju.das@bp.renesas.com> > >> Sent: 10 September 2018 15:31 > >> Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support > >> > >> Document RZ/G2M (R8A774A1) SoC bindings. > >> > >> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > >> > >> Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > >> --- > >> Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > >> b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > >> index 2d385b6..12fe685 100644 > >> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > >> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt > >> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 > >> ------------------------ > >> > >> The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the > >> -Renesas R-Car family of devices. It is used in conjunction with the > >> -R-Car VIN module, which provides the video capture capabilities. > >> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction > >> +with the R-Car VIN module, which provides the video capture capabilities. > >> > >> Mandatory properties > >> -------------------- > >> - compatible: Must be one or more of the following > >> + - "renesas,r8a774a1-csi2" for the R8A774A1 device. > >> - "renesas,r8a7795-csi2" for the R8A7795 device. > >> - "renesas,r8a7796-csi2" for the R8A7796 device. > >> - "renesas,r8a77965-csi2" for the R8A77965 device.
On 3/1/19 1:58 PM, Geert Uytterhoeven wrote: > Hi Hans, > > On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: >> It looks like this series fell through the cracks. >> >> I looked at it and the main problem is that it is missing a Reviewed-by >> from Rob Herring (devicetree maintainer). It's a bit surprising since he >> is usually fairly prompt. > > He actually did provide his Rb on Sep 17. Hmm, I don't see anything about that in my linux-media archive, and patchwork didn't pick that up either. Was linux-media in the CC list of Rob's reply? Regards, Hans > > Gr{oetje,eeting}s, > > Geert >
Hi Hans, Thanks for the feedback. > -----Original Message----- > From: Hans Verkuil <hverkuil@xs4all.nl> > Sent: 01 March 2019 13:09 > To: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho > Chehab <mchehab@kernel.org>; Biju Das <biju.das@bp.renesas.com>; > Niklas Söderlund <niklas.soderlund@ragnatech.se>; linux- > media@vger.kernel.org; linux-renesas-soc@vger.kernel.org; > devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert > Uytterhoeven <geert+renesas@glider.be>; Chris Paterson > <Chris.Paterson2@renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark > Rutland <mark.rutland@arm.com>; Laurent Pinchart > <laurent.pinchart@ideasonboard.com> > Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 > support > > On 3/1/19 1:58 PM, Geert Uytterhoeven wrote: > > Hi Hans, > > > > On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: > >> It looks like this series fell through the cracks. > >> > >> I looked at it and the main problem is that it is missing a > >> Reviewed-by from Rob Herring (devicetree maintainer). It's a bit > >> surprising since he is usually fairly prompt. > > > > He actually did provide his Rb on Sep 17. > > Hmm, I don't see anything about that in my linux-media archive, and > patchwork didn't pick that up either. > > Was linux-media in the CC list of Rob's reply? Yes. Please see below. > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 17 September 2018 06:45 > To: Biju Das <biju.das@bp.renesas.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mark Rutland > <mark.rutland@arm.com>; Biju Das <biju.das@bp.renesas.com>; Niklas > Söderlund <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org; > linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Simon > Horman <horms@verge.net.au>; Geert Uytterhoeven > <geert+renesas@glider.be>; Chris Paterson > <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro@bp.renesas.com> > Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 > support > > On Mon, 10 Sep 2018 15:31:14 +0100, Biju Das wrote: > > Document RZ/G2M (R8A774A1) SoC bindings. > > > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Regards, Biju Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
Hi Hans, On Fri, Mar 1, 2019 at 2:08 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: > On 3/1/19 1:58 PM, Geert Uytterhoeven wrote: > > On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: > >> It looks like this series fell through the cracks. > >> > >> I looked at it and the main problem is that it is missing a Reviewed-by > >> from Rob Herring (devicetree maintainer). It's a bit surprising since he > >> is usually fairly prompt. > > > > He actually did provide his Rb on Sep 17. > > Hmm, I don't see anything about that in my linux-media archive, and patchwork > didn't pick that up either. > > Was linux-media in the CC list of Rob's reply? Yes it was, just like linux-renesas-soc. But lore.kernel.org also has no evidence. I have received it directly, as I was on CC. Gr{oetje,eeting}s, Geert
Hi Biju, Can you do the following: 1) forward both of Rob's replies with his Reviewed-by tag to linux-media, that way I have seen it. 2) rebase the patch series and add all Reviewed-by etc. tags and post as a v2. I'll pick it up and make sure it will get merged. Not sure if we can manage 5.1, but it will certainly get in 5.2. Regards, Hans On 3/1/19 2:12 PM, Biju Das wrote: > Hi Hans, > > Thanks for the feedback. > >> -----Original Message----- >> From: Hans Verkuil <hverkuil@xs4all.nl> >> Sent: 01 March 2019 13:09 >> To: Geert Uytterhoeven <geert@linux-m68k.org> >> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho >> Chehab <mchehab@kernel.org>; Biju Das <biju.das@bp.renesas.com>; >> Niklas Söderlund <niklas.soderlund@ragnatech.se>; linux- >> media@vger.kernel.org; linux-renesas-soc@vger.kernel.org; >> devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert >> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson >> <Chris.Paterson2@renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark >> Rutland <mark.rutland@arm.com>; Laurent Pinchart >> <laurent.pinchart@ideasonboard.com> >> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 >> support >> >> On 3/1/19 1:58 PM, Geert Uytterhoeven wrote: >>> Hi Hans, >>> >>> On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: >>>> It looks like this series fell through the cracks. >>>> >>>> I looked at it and the main problem is that it is missing a >>>> Reviewed-by from Rob Herring (devicetree maintainer). It's a bit >>>> surprising since he is usually fairly prompt. >>> >>> He actually did provide his Rb on Sep 17. >> >> Hmm, I don't see anything about that in my linux-media archive, and >> patchwork didn't pick that up either. >> >> Was linux-media in the CC list of Rob's reply? > > Yes. Please see below. > >> -----Original Message----- >> From: Rob Herring <robh@kernel.org> >> Sent: 17 September 2018 06:45 >> To: Biju Das <biju.das@bp.renesas.com> >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mark Rutland >> <mark.rutland@arm.com>; Biju Das <biju.das@bp.renesas.com>; Niklas >> Söderlund <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org; >> linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Simon >> Horman <horms@verge.net.au>; Geert Uytterhoeven >> <geert+renesas@glider.be>; Chris Paterson >> <Chris.Paterson2@renesas.com>; Fabrizio Castro >> <fabrizio.castro@bp.renesas.com> >> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 >> support >> >> On Mon, 10 Sep 2018 15:31:14 +0100, Biju Das wrote: >>> Document RZ/G2M (R8A774A1) SoC bindings. >>> >>> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). >>> >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >>> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> >>> --- >>> Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Regards, > Biju > > > Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647 >
Hi Hans, Yes. Will do. Regards, Biju > -----Original Message----- > From: Hans Verkuil <hverkuil@xs4all.nl> > Sent: 01 March 2019 13:19 > To: Biju Das <biju.das@bp.renesas.com>; Geert Uytterhoeven > <geert@linux-m68k.org> > Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho > Chehab <mchehab@kernel.org>; Niklas Söderlund > <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org; linux- > renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Simon Horman > <horms@verge.net.au>; Geert Uytterhoeven <geert+renesas@glider.be>; > Chris Paterson <Chris.Paterson2@renesas.com>; Rob Herring > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Laurent > Pinchart <laurent.pinchart@ideasonboard.com> > Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 > support > > Hi Biju, > > Can you do the following: > > 1) forward both of Rob's replies with his Reviewed-by tag to linux-media, > that way I have seen it. > 2) rebase the patch series and add all Reviewed-by etc. tags and post as > a v2. I'll pick it up and make sure it will get merged. Not sure if we > can manage 5.1, but it will certainly get in 5.2. > > Regards, > > Hans > > On 3/1/19 2:12 PM, Biju Das wrote: > > Hi Hans, > > > > Thanks for the feedback. > > > >> -----Original Message----- > >> From: Hans Verkuil <hverkuil@xs4all.nl> > >> Sent: 01 March 2019 13:09 > >> To: Geert Uytterhoeven <geert@linux-m68k.org> > >> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho > >> Chehab <mchehab@kernel.org>; Biju Das <biju.das@bp.renesas.com>; > >> Niklas Söderlund <niklas.soderlund@ragnatech.se>; linux- > >> media@vger.kernel.org; linux-renesas-soc@vger.kernel.org; > >> devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; > Geert > >> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson > >> <Chris.Paterson2@renesas.com>; Rob Herring <robh+dt@kernel.org>; > Mark > >> Rutland <mark.rutland@arm.com>; Laurent Pinchart > >> <laurent.pinchart@ideasonboard.com> > >> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add > >> r8a774a1 support > >> > >> On 3/1/19 1:58 PM, Geert Uytterhoeven wrote: > >>> Hi Hans, > >>> > >>> On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: > >>>> It looks like this series fell through the cracks. > >>>> > >>>> I looked at it and the main problem is that it is missing a > >>>> Reviewed-by from Rob Herring (devicetree maintainer). It's a bit > >>>> surprising since he is usually fairly prompt. > >>> > >>> He actually did provide his Rb on Sep 17. > >> > >> Hmm, I don't see anything about that in my linux-media archive, and > >> patchwork didn't pick that up either. > >> > >> Was linux-media in the CC list of Rob's reply? > > > > Yes. Please see below. > > > >> -----Original Message----- > >> From: Rob Herring <robh@kernel.org> > >> Sent: 17 September 2018 06:45 > >> To: Biju Das <biju.das@bp.renesas.com> > >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mark Rutland > >> <mark.rutland@arm.com>; Biju Das <biju.das@bp.renesas.com>; Niklas > >> Söderlund <niklas.soderlund@ragnatech.se>; > >> linux-media@vger.kernel.org; linux-renesas-soc@vger.kernel.org; > >> devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; > Geert > >> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson > >> <Chris.Paterson2@renesas.com>; Fabrizio Castro > >> <fabrizio.castro@bp.renesas.com> > >> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add > >> r8a774a1 support > >> > >> On Mon, 10 Sep 2018 15:31:14 +0100, Biju Das wrote: > >>> Document RZ/G2M (R8A774A1) SoC bindings. > >>> > >>> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > >>> > >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >>> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > >>> --- > >>> Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 > >>> +++-- > >>> 1 file changed, 3 insertions(+), 2 deletions(-) > >>> > >> > >> Reviewed-by: Rob Herring <robh@kernel.org> > > > > Regards, > > Biju > > > > > > Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael > > Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, > > Arcadiastrasse 10, 40472 Duesseldorf, > > Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 > > USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. > > no.: DE 14978647 > > Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
-----Original Message----- From: Rob Herring <robh@kernel.org> Sent: 17 September 2018 06:45 To: Biju Das <biju.das@bp.renesas.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Biju Das <biju.das@bp.renesas.com>; Niklas Söderlund <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org; linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert Uytterhoeven <geert+renesas@glider.be>; Chris Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro <fabrizio.castro@bp.renesas.com> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support On Mon, 10 Sep 2018 15:31:14 +0100, Biju Das wrote: > Document RZ/G2M (R8A774A1) SoC bindings. > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796). > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > --- > Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org> Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
Hi Hans, Laurent, On 2019-03-01 15:06:13 +0200, Laurent Pinchart wrote: > Hi Hans, > > On Fri, Mar 01, 2019 at 01:55:53PM +0100, Hans Verkuil wrote: > > Hi Fabrizio, > > > > It looks like this series fell through the cracks. > > > > I looked at it and the main problem is that it is missing a Reviewed-by > > from Rob Herring (devicetree maintainer). It's a bit surprising since he > > is usually fairly prompt. > > > > I recommend that you rebase and repost it and I'll delegate the v2 series > > to me so we can hopefully get it in for 5.2 (5.1 is likely too late) once > > Rob reviews it. > > > > BTW, I'm the one who usually processes rcar patches. But it was delegated in > > patchwork to Laurent, so I never saw it. > > I handle the VSP and FDP patches. I propose delegating the CSI-2 and VIN > to Niklas. I be more then happy to collect patches for R-Car VIN and CSI-2 and send PRs for them to you Hans. Would that work for you Hans?
diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt index 2d385b6..12fe685 100644 --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2 ------------------------ The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the -Renesas R-Car family of devices. It is used in conjunction with the -R-Car VIN module, which provides the video capture capabilities. +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction +with the R-Car VIN module, which provides the video capture capabilities. Mandatory properties -------------------- - compatible: Must be one or more of the following + - "renesas,r8a774a1-csi2" for the R8A774A1 device. - "renesas,r8a7795-csi2" for the R8A7795 device. - "renesas,r8a7796-csi2" for the R8A7796 device. - "renesas,r8a77965-csi2" for the R8A77965 device.