| Message ID | 20190301140254.19341-1-k.konieczny@partner.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: s5p-sss - fix AES support for Exynos5433 | expand |
On Fri, 1 Mar 2019 at 15:03, Kamil Konieczny <k.konieczny@partner.samsung.com> wrote: > > Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433") > introduced bug in dereferencing clk_names[1] on platforms different from > Exynos5433. On Exynos board XU3 call trace is: > > "Unable to handle kernel paging request at virtual address 00004000" > (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0) > ... > (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0) > (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4) > > Fix this by setting array clk_names size to 2. > > Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433") > Reported-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> > --- > drivers/crypto/s5p-sss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for fast fix! Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Tested on Exynos5422 Odroid HC1: Tested-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Fri, Mar 01, 2019 at 03:02:54PM +0100, Kamil Konieczny wrote: > Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433") > introduced bug in dereferencing clk_names[1] on platforms different from > Exynos5433. On Exynos board XU3 call trace is: > > "Unable to handle kernel paging request at virtual address 00004000" > (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0) > ... > (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0) > (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4) > > Fix this by setting array clk_names size to 2. > > Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433") > Reported-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> > --- > drivers/crypto/s5p-sss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 3f45cc5cb94a..2fb4ae459c45 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -241,7 +241,7 @@ struct samsung_aes_variant { unsigned int aes_offset; unsigned int hash_offset; - const char *clk_names[]; + const char *clk_names[2]; }; struct s5p_aes_reqctx {
Commit 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433") introduced bug in dereferencing clk_names[1] on platforms different from Exynos5433. On Exynos board XU3 call trace is: "Unable to handle kernel paging request at virtual address 00004000" (strcmp) from [<c0774014>] (of_property_match_string+0x58/0xd0) ... (devm_clk_get) from [<c075c248>] (s5p_aes_probe+0xd4/0x4a0) (s5p_aes_probe) from [<c059dbc4>] (platform_drv_probe+0x6c/0xa4) Fix this by setting array clk_names size to 2. Fixes: 0918f18c7179 ("crypto: s5p - add AES support for Exynos5433") Reported-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> --- drivers/crypto/s5p-sss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)