diff mbox series

[RESEND,v2,1/2] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

Message ID 1551450253-63390-1-git-send-email-biju.das@bp.renesas.com (mailing list archive)
State New, archived
Headers show
Series [RESEND,v2,1/2] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support | expand

Commit Message

Biju Das March 1, 2019, 2:24 p.m. UTC
Document RZ/G2M (R8A774A1) SoC bindings.

The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Rob Herring <robh@kernel.org>
---
V1->V2
   * No change
---
 Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Hans Verkuil March 1, 2019, 2:35 p.m. UTC | #1
On 3/1/19 3:24 PM, Biju Das wrote:
> Document RZ/G2M (R8A774A1) SoC bindings.

Please resend the whole series, not just the dt-bindings patches.

Also note that the original v1 series said that there were 5 patches in
the series, but only the first 4 were received on linux-media. So I have
no idea what the 5th patch was (dts change perhaps?).

Having a newly posted patch series avoids confusion.

Regards,

	Hans

> 
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> V1->V2
>    * No change
> ---
>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> index d63275e..9932458 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -8,6 +8,7 @@ R-Car VIN module, which provides the video capture capabilities.
>  Mandatory properties
>  --------------------
>   - compatible: Must be one or more of the following
> +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
>     - "renesas,r8a774c0-csi2" for the R8A774C0 device.
>     - "renesas,r8a7795-csi2" for the R8A7795 device.
>     - "renesas,r8a7796-csi2" for the R8A7796 device.
>
Biju Das March 1, 2019, 2:52 p.m. UTC | #2
Hi Hans,

Thanks for the feedback.

> Subject: Re: [PATCH RESEND v2 1/2] media: dt-bindings: media: rcar-csi2: Add
> r8a774a1 support
>
> On 3/1/19 3:24 PM, Biju Das wrote:
> > Document RZ/G2M (R8A774A1) SoC bindings.
>
> Please resend the whole series, not just the dt-bindings patches.
>
> Also note that the original v1 series said that there were 5 patches in the
> series, but only the first 4 were received on linux-media. So I have no idea
> what the 5th patch was (dts change perhaps?).

Yes,  It is dts patch

> Having a newly posted patch series avoids confusion.

OK. Will send the whole series again..

Regards,
Biju

> >
> > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> > V1->V2
> >    * No change
> > ---
> >  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > index d63275e..9932458 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > @@ -8,6 +8,7 @@ R-Car VIN module, which provides the video capture
> capabilities.
> >  Mandatory properties
> >  --------------------
> >   - compatible: Must be one or more of the following
> > +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
> >     - "renesas,r8a774c0-csi2" for the R8A774C0 device.
> >     - "renesas,r8a7795-csi2" for the R8A7795 device.
> >     - "renesas,r8a7796-csi2" for the R8A7796 device.
> >



Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
Biju Das March 1, 2019, 3:18 p.m. UTC | #3
Hi Hans,

> Subject: RE: [PATCH RESEND v2 1/2] media: dt-bindings: media: rcar-csi2: Add
> r8a774a1 support
>
> Hi Hans,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH RESEND v2 1/2] media: dt-bindings: media:
> > rcar-csi2: Add
> > r8a774a1 support
> >
> > On 3/1/19 3:24 PM, Biju Das wrote:
> > > Document RZ/G2M (R8A774A1) SoC bindings.
> >
> > Please resend the whole series, not just the dt-bindings patches.
> >
> > Also note that the original v1 series said that there were 5 patches
> > in the series, but only the first 4 were received on linux-media. So I
> > have no idea what the 5th patch was (dts change perhaps?).
>
> Yes,  It is dts patch.

This 5th patch is already in media tree . commit 0c85e78fb1d3742c ("arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes")
So I will resend the patch series with first 4 patches.

Regards,
Biju

>
> > >
> > > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > ---
> > > V1->V2
> > >    * No change
> > > ---
> > >  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > > b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > > index d63275e..9932458 100644
> > > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > > @@ -8,6 +8,7 @@ R-Car VIN module, which provides the video capture
> > capabilities.
> > >  Mandatory properties
> > >  --------------------
> > >   - compatible: Must be one or more of the following
> > > +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
> > >     - "renesas,r8a774c0-csi2" for the R8A774C0 device.
> > >     - "renesas,r8a7795-csi2" for the R8A7795 device.
> > >     - "renesas,r8a7796-csi2" for the R8A7796 device.
> > >



Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
index d63275e..9932458 100644
--- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
+++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
@@ -8,6 +8,7 @@  R-Car VIN module, which provides the video capture capabilities.
 Mandatory properties
 --------------------
  - compatible: Must be one or more of the following
+   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
    - "renesas,r8a774c0-csi2" for the R8A774C0 device.
    - "renesas,r8a7795-csi2" for the R8A7795 device.
    - "renesas,r8a7796-csi2" for the R8A7796 device.