| Message ID | 20190304151827.1813-2-davidkiarie4@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | update copyright notice | expand |
On 3/4/19 4:18 PM, David Kiarie wrote: > Signed-off-by: David Kiarie <davidkiarie4@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/i386/amd_iommu.c | 2 +- > hw/i386/amd_iommu.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > index 8ad707a..6eabdf9 100644 > --- a/hw/i386/amd_iommu.c > +++ b/hw/i386/amd_iommu.c > @@ -2,7 +2,7 @@ > * QEMU emulation of AMD IOMMU (AMD-Vi) > * > * Copyright (C) 2011 Eduard - Gabriel Munteanu > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > index c52886f..0ff9095 100644 > --- a/hw/i386/amd_iommu.h > +++ b/hw/i386/amd_iommu.h > @@ -2,7 +2,7 @@ > * QEMU emulation of an AMD IOMMU (AMD-Vi) > * > * Copyright (C) 2011 Eduard - Gabriel Munteanu > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by >
On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > On 3/4/19 4:18 PM, David Kiarie wrote: > > Signed-off-by: David Kiarie <davidkiarie4@gmail.com> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > would i be wrong to say this patch received unwarranted scrutiny from you, Philippe? > > --- > > hw/i386/amd_iommu.c | 2 +- > > hw/i386/amd_iommu.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > > index 8ad707a..6eabdf9 100644 > > --- a/hw/i386/amd_iommu.c > > +++ b/hw/i386/amd_iommu.c > > @@ -2,7 +2,7 @@ > > * QEMU emulation of AMD IOMMU (AMD-Vi) > > * > > * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > > * > > * This program is free software; you can redistribute it and/or modify > > * it under the terms of the GNU General Public License as published by > > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > > index c52886f..0ff9095 100644 > > --- a/hw/i386/amd_iommu.h > > +++ b/hw/i386/amd_iommu.h > > @@ -2,7 +2,7 @@ > > * QEMU emulation of an AMD IOMMU (AMD-Vi) > > * > > * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > > * > > * This program is free software; you can redistribute it and/or modify > > * it under the terms of the GNU General Public License as published by > > >
On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <davidkiarie4@gmail.com> wrote: > > > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com> > wrote: > >> On 3/4/19 4:18 PM, David Kiarie wrote: >> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> > > would i be wrong to say this patch received unwarranted scrutiny from you, > Philippe? > i mean, given you have never been involved in any IOMMU work, i wouldn't expect that you're in a position to asking questions about the copyright. > > >> > --- >> > hw/i386/amd_iommu.c | 2 +- >> > hw/i386/amd_iommu.h | 2 +- >> > 2 files changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c >> > index 8ad707a..6eabdf9 100644 >> > --- a/hw/i386/amd_iommu.c >> > +++ b/hw/i386/amd_iommu.c >> > @@ -2,7 +2,7 @@ >> > * QEMU emulation of AMD IOMMU (AMD-Vi) >> > * >> > * Copyright (C) 2011 Eduard - Gabriel Munteanu >> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani >> > * >> > * This program is free software; you can redistribute it and/or modify >> > * it under the terms of the GNU General Public License as published by >> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >> > index c52886f..0ff9095 100644 >> > --- a/hw/i386/amd_iommu.h >> > +++ b/hw/i386/amd_iommu.h >> > @@ -2,7 +2,7 @@ >> > * QEMU emulation of an AMD IOMMU (AMD-Vi) >> > * >> > * Copyright (C) 2011 Eduard - Gabriel Munteanu >> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani >> > * >> > * This program is free software; you can redistribute it and/or modify >> > * it under the terms of the GNU General Public License as published by >> > >> >
On Mon, Mar 4, 2019 at 10:29 PM David Kiarie <davidkiarie4@gmail.com> wrote: > > > On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <davidkiarie4@gmail.com> > wrote: > >> >> >> On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com> >> wrote: >> >>> On 3/4/19 4:18 PM, David Kiarie wrote: >>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >>> >>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>> >> >> would i be wrong to say this patch received unwarranted scrutiny from >> you, Philippe? >> > > i mean, given you have never been involved in any IOMMU work, i wouldn't > expect that you're in a position to asking questions about the copyright. > yet, for some strange reason, you just couldn't help it. ok. > > >> >> >>> > --- >>> > hw/i386/amd_iommu.c | 2 +- >>> > hw/i386/amd_iommu.h | 2 +- >>> > 2 files changed, 2 insertions(+), 2 deletions(-) >>> > >>> > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c >>> > index 8ad707a..6eabdf9 100644 >>> > --- a/hw/i386/amd_iommu.c >>> > +++ b/hw/i386/amd_iommu.c >>> > @@ -2,7 +2,7 @@ >>> > * QEMU emulation of AMD IOMMU (AMD-Vi) >>> > * >>> > * Copyright (C) 2011 Eduard - Gabriel Munteanu >>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >>> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani >>> > * >>> > * This program is free software; you can redistribute it and/or >>> modify >>> > * it under the terms of the GNU General Public License as published >>> by >>> > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>> > index c52886f..0ff9095 100644 >>> > --- a/hw/i386/amd_iommu.h >>> > +++ b/hw/i386/amd_iommu.h >>> > @@ -2,7 +2,7 @@ >>> > * QEMU emulation of an AMD IOMMU (AMD-Vi) >>> > * >>> > * Copyright (C) 2011 Eduard - Gabriel Munteanu >>> > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >>> > + * Copyright (C) 2015, 2016 David Kiarie Kahurani >>> > * >>> > * This program is free software; you can redistribute it and/or >>> modify >>> > * it under the terms of the GNU General Public License as published >>> by >>> > >>> >>
>>> >>> On 3/4/19 4:18 PM, David Kiarie wrote: >>>> > Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >>>> >>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>>> >>> >>> would i be wrong to say this patch received unwarranted scrutiny from >>> you, Philippe? >>> >> >> i mean, given you have never been involved in any IOMMU work, i wouldn't >> expect that you're in a position to asking questions about the copyright. >> > > yet, for some strange reason, you just couldn't help it. > > ok. > and, by the way, if you can't answer my question, then your review is just as good as none. > > >> >> >>> >>>>
Hi David, On 3/4/19 8:29 PM, David Kiarie wrote: > > > On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <davidkiarie4@gmail.com > <mailto:davidkiarie4@gmail.com>> wrote: > > > > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé > <philmd@redhat.com <mailto:philmd@redhat.com>> wrote: > > On 3/4/19 4:18 PM, David Kiarie wrote: > > Signed-off-by: David Kiarie <davidkiarie4@gmail.com > <mailto:davidkiarie4@gmail.com>> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com > <mailto:philmd@redhat.com>> > > > would i be wrong to say this patch received unwarranted scrutiny > from you, Philippe? > > > i mean, given you have never been involved in any IOMMU work, i wouldn't > expect that you're in a position to asking questions about the copyright. IANAL and I have no knowledge of IOMMU indeed. I noticed first this patch is sent from the same email used in this copyright notice, then the patch content merged in commit d29a09ca684 was accepted in 2016 with a copyright date of 2015, hence your copyright modification looks correct to me. Regards, Philippe. > > > > > > --- > > hw/i386/amd_iommu.c | 2 +- > > hw/i386/amd_iommu.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > > index 8ad707a..6eabdf9 100644 > > --- a/hw/i386/amd_iommu.c > > +++ b/hw/i386/amd_iommu.c > > @@ -2,7 +2,7 @@ > > * QEMU emulation of AMD IOMMU (AMD-Vi) > > * > > * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com > <mailto:davidkiarie4@gmail.com>> > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > > * > > * This program is free software; you can redistribute it > and/or modify > > * it under the terms of the GNU General Public License as > published by > > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > > index c52886f..0ff9095 100644 > > --- a/hw/i386/amd_iommu.h > > +++ b/hw/i386/amd_iommu.h > > @@ -2,7 +2,7 @@ > > * QEMU emulation of an AMD IOMMU (AMD-Vi) > > * > > * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com > <mailto:davidkiarie4@gmail.com>> > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > > * > > * This program is free software; you can redistribute it > and/or modify > > * it under the terms of the GNU General Public License as > published by > > >
> > IANAL and I have no knowledge of IOMMU indeed. > I noticed first this patch is sent from the same email used in this > copyright notice, then the patch content merged in commit d29a09ca684 > was accepted in 2016 with a copyright date of 2015, hence your copyright > modification looks correct to me. > > Regards, > > Philippe. it looks like i already discarded(in the confusion that issued from Qemu not being able to merge a simple patch and creating theories around it) Daniel's review, wouldn't it be unfair to keep yours? > > > > >
i hope you don't find this offensive, Eric but i'm forwarding this message to all the people on this thread. i don't find anything exactly private in this email. [off-list] On 3/4/19 1:20 PM, David Kiarie wrote: > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com> > wrote: > >> On 3/4/19 4:18 PM, David Kiarie wrote: >>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> > > would i be wrong to say this patch received unwarranted scrutiny from you, > Philippe? David, please calm down, and don't write emails that can sound like you are attacking your reviewers on list. Assume good intent - Philippe reviewed your patch with the same level of scrutiny as many other patches he reviews, and his question for your previous patch revision about whether you intended to change the copyright year was not an attack, but an honest question. Open source works best when anyone feels like they can contribute. Copyright lines are an interesting beast - they carry legal significance, so care should be taken that they aren't changed by mistake, but at the same time, you do not have to know the code that the copyright is protecting to ask an honest question about whether a change is intentional.
On Tue, Mar 5, 2019 at 5:36 PM David Kiarie <davidkiarie4@gmail.com> wrote: > i hope you don't find this offensive, Eric but i'm forwarding this message > to all the people on this thread. > > i don't find anything exactly private in this email. > > [off-list] > > On 3/4/19 1:20 PM, David Kiarie wrote: > > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <philmd@redhat.com > > > > wrote: > > > >> On 3/4/19 4:18 PM, David Kiarie wrote: > >>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com> > >> > >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > >> > > > > would i be wrong to say this patch received unwarranted scrutiny from > you, > > Philippe? > > David, please calm down, and don't write emails that can sound like you > are attacking your reviewers on list. Assume good intent - Philippe > reviewed your patch with the same level of scrutiny as many other > patches he reviews, and his question for your previous patch revision > about whether you intended to change the copyright year was not an > attack, but an honest question. > > Open source works best when anyone feels like they can contribute. > Copyright lines are an interesting beast - they carry legal > significance, so care should be taken that they aren't changed by > mistake, but at the same time, you do not have to know the code that the > copyright is protecting to ask an honest question about whether a change > is intentional. > it's simply not fair for me to waiting for you guys to merge this patch. i sent both, you can pick whichever. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org >
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 8ad707a..6eabdf9 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -2,7 +2,7 @@ * QEMU emulation of AMD IOMMU (AMD-Vi) * * Copyright (C) 2011 Eduard - Gabriel Munteanu - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> + * Copyright (C) 2015, 2016 David Kiarie Kahurani * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h index c52886f..0ff9095 100644 --- a/hw/i386/amd_iommu.h +++ b/hw/i386/amd_iommu.h @@ -2,7 +2,7 @@ * QEMU emulation of an AMD IOMMU (AMD-Vi) * * Copyright (C) 2011 Eduard - Gabriel Munteanu - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> + * Copyright (C) 2015, 2016 David Kiarie Kahurani * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
Signed-off-by: David Kiarie <davidkiarie4@gmail.com> --- hw/i386/amd_iommu.c | 2 +- hw/i386/amd_iommu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)